From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 6/7] drm/msm: Remove redundant calls to drm_connector_register_all() Date: Fri, 17 Jun 2016 14:44:43 +0530 Message-ID: <5763BF83.50905@codeaurora.org> References: <1466151923-1572-1-git-send-email-chris@chris-wilson.co.uk> <1466151923-1572-7-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49460 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbcFQJOt (ORCPT ); Fri, 17 Jun 2016 05:14:49 -0400 In-Reply-To: <1466151923-1572-7-git-send-email-chris@chris-wilson.co.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Chris Wilson , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org On 06/17/2016 01:55 PM, Chris Wilson wrote: > Up to now, the recommendation was for drivers to call drm_dev_register() > followed by drm_connector_register_all(). Now that > drm_connector_register() is safe against multiple invocations, we can > move drm_connector_register_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > Tested-by: Archit Taneja > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Rob Clark > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > --- > drivers/gpu/drm/msm/msm_drv.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 9c654092ef78..568fcc328f27 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -197,8 +197,6 @@ static int msm_drm_uninit(struct device *dev) > > drm_kms_helper_poll_fini(ddev); > > - drm_connector_unregister_all(ddev); > - > drm_dev_unregister(ddev); > > #ifdef CONFIG_DRM_FBDEV_EMULATION > @@ -431,12 +429,6 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) > if (ret) > goto fail; > > - ret = drm_connector_register_all(ddev); > - if (ret) { > - dev_err(dev, "failed to register connectors\n"); > - goto fail; > - } > - > drm_mode_config_reset(ddev); > > #ifdef CONFIG_DRM_FBDEV_EMULATION > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation