Re: [PATCH v3 5/5] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/12/2024 00:25, Dmitry Baryshkov wrote:
>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in
>>>>>> changes related to thermal which will be added later in devicetree.
>>>>>
>>>>> Since this can't be inferred from just looking at the changes, please
>>>>> make sure to add that to the commit message
>>>>
>>>> Any include of other DTS is clear sign something is odd here. Including
>>>> multiple times without any added nodes is showing these are not real
>>>> products/boards .
>>>
>>> We're adding DTS to reuse the common board changes, with plans to
>>> include the differences in upcoming patches. To provide more clarity, I
>>> will include patches in this series to highlight the differences between
>>> the 9100 and 9075 boards.
>>
>> Sure, still do not include DTS. Just like C files don't include C files.
> 
> So, is the solution simple, rename .dts to .dtsi and include it from
> both .dts files?

For example. This leads to more questions - what is common here? We do
not create shared DTSI files just because someone wants, but to really
note shared components or shared designs.

Best regards,
Krzysztof