From: Archit Taneja <architt@codeaurora.org>
To: Rob Herring <robh@kernel.org>, robdclark@gmail.com
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] drm/msm/hdmi: Use more DT friendly GPIO names
Date: Thu, 14 Jul 2016 14:04:44 +0530 [thread overview]
Message-ID: <57874EA4.3010605@codeaurora.org> (raw)
In-Reply-To: <20160713134555.GA7799@rob-hp-laptop>
On 07/13/2016 07:15 PM, Rob Herring wrote:
> On Fri, Jul 08, 2016 at 11:25:52AM +0530, Archit Taneja wrote:
>> Update the gpio name parsing code to try to search for without the
>> "qcom,hdmi-tx-" prefix. The older downstream bindings that expect
>> "qcom,hdmi-tx-xyz" or "qcom,hdmi-tx-xyz-gpio" would work as the
>> property name would work as before.
>
> Why?
Why we want the older names to work? Just to make life easier if
backporting the drm driver to a downstream msm kernel (like a 3.10,
or 3.18).
>
>> Update the binding doc. Add an entry for the missing hpd and lpm
>> gpios.
>>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>>
>> Signed-off-by: Archit Taneja <architt@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/display/msm/hdmi.txt | 6 ++++--
>> drivers/gpu/drm/msm/hdmi/hdmi.c | 16 ++++++++++++++++
>> 2 files changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.txt b/Documentation/devicetree/bindings/display/msm/hdmi.txt
>> index b63f614..4da1abd 100644
>> --- a/Documentation/devicetree/bindings/display/msm/hdmi.txt
>> +++ b/Documentation/devicetree/bindings/display/msm/hdmi.txt
>> @@ -23,8 +23,10 @@ Required properties:
>> - phy-names: the name of the corresponding PHY device
>>
>> Optional properties:
>> -- qcom,hdmi-tx-mux-en-gpio: hdmi mux enable pin
>> -- qcom,hdmi-tx-mux-sel-gpio: hdmi mux select pin
>> +- hpd-gpio: hdmi hpd pin
>
> hpd-gpios is the somewhat standard name.
>
>> +- mux-en-gpio: hdmi mux enable pin
>> +- mux-sel-gpio: hdmi mux select pin
>> +- mux-lpm-gpio: hdmi mux lpm pin
>
> These look pretty QCom specific and should keep the vendor prefix.
Okay.
>
> I understand why you don't have '-gpios', but if we change these they
> should use the preferred form.
Sure, I'll update these to the preferred form.
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-14 8:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 5:55 [PATCH 0/4] drm/msm: HDMI support on IFC6410 Archit Taneja
2016-07-08 5:55 ` [PATCH 1/4] drm/msm/mdp4: Fix issue with LCDC/LVDS port parsing Archit Taneja
2016-07-08 5:55 ` [PATCH 2/4] drm/msm/hdmi: Use more DT friendly GPIO names Archit Taneja
2016-07-13 13:45 ` Rob Herring
2016-07-14 8:34 ` Archit Taneja [this message]
2016-07-08 5:55 ` [PATCH 3/4] arm: dts: qcom: apq8064: Add display DT nodes Archit Taneja
2016-07-08 5:55 ` [PATCH 4/4] arm: dts: qcom: apq8064-ifc6410: Add HDMI support Archit Taneja
2016-09-01 13:36 ` [PATCH v2 0/4] drm/msm: HDMI support on IFC6410 Archit Taneja
2016-09-01 13:36 ` [PATCH v2 1/4] drm/msm/mdp4: Fix issue with LCDC/LVDS port parsing Archit Taneja
2016-09-07 22:17 ` John Stultz
2016-09-01 13:36 ` [PATCH v2 2/4] drm/msm/hdmi: Clean up HDMI gpio DT bindings Archit Taneja
[not found] ` <1472737015-29382-3-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-07 22:18 ` John Stultz
2016-09-12 13:19 ` Rob Herring
2016-09-13 7:12 ` Archit Taneja
2016-09-13 13:15 ` Archit Taneja
2016-09-01 13:36 ` [PATCH v2 3/4] arm: dts: qcom: apq8064: Add display DT nodes Archit Taneja
2016-09-07 22:19 ` John Stultz
2016-09-01 13:36 ` [PATCH v2 4/4] arm: dts: qcom: apq8064-ifc6410: Add HDMI support Archit Taneja
2016-09-07 23:32 ` [RFC][PATCH 5/4] arm: dts: qcom: apq8064: Add dsi, gpu and iommu nodes John Stultz
2016-09-07 23:32 ` [PATCH 6/4] arm: dts: qcom: apq8064-nexus7: Add DSI and panel nodes John Stultz
2016-09-08 5:05 ` vinay simha
2016-09-08 4:58 ` [RFC][PATCH 5/4] arm: dts: qcom: apq8064: Add dsi, gpu and iommu nodes vinay simha
2016-09-12 8:46 ` Archit Taneja
2016-09-13 15:21 ` [PATCH v3 0/4] drm/msm: HDMI support on IFC6410 Archit Taneja
2016-09-13 15:21 ` [PATCH v3 1/4] drm/msm/mdp4: Fix issue with LCDC/LVDS port parsing Archit Taneja
[not found] ` <1473780097-11388-1-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-13 15:21 ` [PATCH v3 2/4] drm/msm/hdmi: Clean up HDMI gpio DT bindings Archit Taneja
2016-09-13 19:31 ` Rob Herring
2016-09-13 15:21 ` [PATCH v3 4/4] arm: dts: qcom: apq8064-ifc6410: Add HDMI support Archit Taneja
2016-09-13 15:21 ` [PATCH v3 3/4] arm: dts: qcom: apq8064: Add display DT nodes Archit Taneja
[not found] ` <1473780097-11388-4-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-13 21:44 ` Stephen Boyd
2016-09-14 17:57 ` Archit Taneja
2016-09-23 6:33 ` [PATCH v4 0/2] drm/msm: HDMI support on IFC6410 Archit Taneja
2016-09-23 6:33 ` [PATCH v4 1/2] arm: dts: qcom: apq8064: Add display DT nodes Archit Taneja
2016-09-23 6:33 ` [PATCH v4 2/2] arm: dts: qcom: apq8064-ifc6410: Add HDMI support Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57874EA4.3010605@codeaurora.org \
--to=architt@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).