From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH V2] dmaengine: qcom_hidma: release the descriptor before the callback Date: Sun, 31 Jul 2016 09:13:48 -0500 Message-ID: <579E079C.2040500@codeaurora.org> References: <1469974266-28023-1-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35201 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbcGaONu (ORCPT ); Sun, 31 Jul 2016 10:13:50 -0400 In-Reply-To: <1469974266-28023-1-git-send-email-okaya@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya , dmaengine@vger.kernel.org, cov@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sinan Kaya wrote: > + list_for_each_entry_safe(mdesc, next, &list, node) { > enum dma_status llstat; > + dma_async_tx_callback callback; > + void *param; > > desc = &mdesc->desc; > > @@ -132,18 +135,19 @@ static void hidma_process_completed(struct hidma_chan *mchan) > spin_unlock_irqrestore(&mchan->lock, irqflags); > > llstat = hidma_ll_status(mdma->lldev, mdesc->tre_ch); > - if (desc->callback && (llstat == DMA_COMPLETE)) > - desc->callback(desc->callback_param); > + callback = desc->callback; > + param = desc->callback_param; It looks to me like 'callback' and 'param' are never actually used. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.