From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH v2 09/10] clk: qcom: Add .is_enabled ops for clk-alpha-pll Date: Thu, 25 Aug 2016 14:45:25 +0530 Message-ID: <57BEB72D.30504@codeaurora.org> References: <1470904858-11930-1-git-send-email-rnayak@codeaurora.org> <1470904858-11930-10-git-send-email-rnayak@codeaurora.org> <20160824062832.GX6502@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160824062832.GX6502@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, tdas@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org On 08/24/2016 11:58 AM, Stephen Boyd wrote: > On 08/11, Rajendra Nayak wrote: >> This would be useful in subsequent patches when the .set_rate operation >> would need to identify if the PLL is actually enabled >> >> Signed-off-by: Rajendra Nayak >> --- > > Hmmm I suspect I never implemented the is_enabled op because that > will happen to turn off clks during late init that shouldn't > otherwise be disabled because the framework now can see that some > PLL is enabled out of the bootloader. Is that happening now? We > really should fix the framework to make this not be a problem, > mostly by finishing off the clk handoff patches that Mike posted > a while back. But either way, I'm worried with these patches that > implement is_enabled ops. I did not see any, but will try and test some more to see if we indeed run into such issues -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation