From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 3/3] arm64: dts: apq8016-sbc: Set up LDO2, LDO6 and LDO17 regulator voltage ranges Date: Thu, 1 Sep 2016 11:42:03 +0530 Message-ID: <57C7C6B3.3040705@codeaurora.org> References: <1472640730-24326-1-git-send-email-architt@codeaurora.org> <1472640730-24326-4-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43117 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbcIAGM6 (ORCPT ); Thu, 1 Sep 2016 02:12:58 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , andy.gross@linaro.org, robh@kernel.org Cc: linux-arm-msm@vger.kernel.org On 09/01/2016 02:24 AM, Stephen Boyd wrote: > On 08/31/2016 03:52 AM, Archit Taneja wrote: >> On the APQ8016 SBC, the LDO2 PM8916 regulator feeds 1.2V to the following: >> >> - VDDA_1P2_MIPI_DSI and VDDA_MIPI_CSI pins on APQ8016. >> - VCCCAD pins on the LPDDR3 chip. >> - VDDPX_1 pins on APQ8016. >> >> The LDO6 regulator feeds 1.8V to: >> - VDAA_MIPI_DSI0_PLL pin on APQ8016. >> - QFPROM_BLOW_VDD pin on PM8916. >> - The AVDD, A2VDD and DVDD pins on ADV7533 bridge. >> >> The LDO17 regulator feeds 3.3V to: >> - The V3P3 pin on ADV7533 bridge. >> >> Currently, the regulator min/max voltages for all the LDOs are set to the >> range of what the PMIC supports. Set the ranges for L2, L6 and L17 to what >> we need, i.e. 1.2V, 1.8V and 3.3V respectively. > > Why doesn't the consuming driver request a particular voltage on these > LDOs? It doesn't seem correct to modify board constraints to satisfy a > consumer (even if that consumer is on the board). Mark Brown suggested that drivers setting only a single voltage should specify the constrains via board files, etc: https://patchwork.freedesktop.org/patch/78789/ Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project