From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 907C635674C for ; Thu, 21 May 2026 08:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353154; cv=none; b=ET5DL5m7AiL0Moo0SRAvS+YyNNYd1rPgb1GWdtNnrJnXkVsAnMcX8Igtc6YiJyOR1wG7JkBzEGAIKpE3cgq19XCXmBYW0L23DzzT0CsUhIka8Ki672riWCmaDvJdOtIb/wte85vzpM8FnG3UVVSdLNjKJdunKKMkUzJ/xzMnCMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353154; c=relaxed/simple; bh=LI1P7U0gaKVb0FmucV8auUmJuUJiOS5F8FS12dF2UIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XxyfEpai6EnYMRGC+qxfuhkj6H1yKnTz1ch5LUwBYBHzKHyVEy+XkM1TYycj71q+b0KfF0EAIpcgB39mQtt4XePHHWK9ClmZBPwSKPqcloGbyGqeIAp/4cz04wSlFAh7rkoME51L5vV9768hh9W2a6gmtmE302QQ5hSy0f7PyJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KpoblIp4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dfk8qgv5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KpoblIp4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dfk8qgv5" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L6m0uA3680440 for ; Thu, 21 May 2026 08:45:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=KpoblIp4FrCA7WaY V0aY174JYcUU4bEHOb41Z1Bp0vTX6wVHCNGVSD6LkHlJOKSlEM6pMyCchKMWcI+L /FNSpJpvJrPYTW2QcASurlNney0kg8k3i4HM1a1ehtm/ckxjrfjUZ/mbYitG93PW kTikwmzGWt0vQk0lL5Iq2AfhfxwguQDqEW8AwlkY7H8eBD54eQeleAGYZ6Oajzp7 fyfzICeTNV+SCEiVwa+7W66AbpOAarA+WaB8kVMgt+Gk9mFFDoZl75iHWCWO4oid dva7CrlwIQtw7Q9S3DmKdpxHHYzFeXEni4Cv/aP+L0g+zR5bblIqcxaYUFqGvfx/ g+VS4w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9e9j42au-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:45:52 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36642d2f4deso12474964a91.3 for ; Thu, 21 May 2026 01:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779353152; x=1779957952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=Dfk8qgv5hpROW86sINUAEQxJgcT+F4cvcIbOhO2ceBzhMK419m283sHyNIGASV3mqp 1R1GOTm+OkDvS/an8UYLT4WLvLoDMbJeYn+Z/ncpSX5KenDGG+2TzUT0FqCMRcR3LsiS mKiAx0t/ybQkaGawAZryW/Aanwt390ElyMWdoa/DYEy94jZ+qBKIef3Met1QXy5L3EQ0 97fySqxRl5ETCyUkwDUdprqhNRj0m7xzavUmIxCMM1bTwvIjA8uNnqRR1U4ZQBANrDpe ND79gjiVUzEibOX0pLHvUUtNs7WhcdAQmVx3Dzht4cI6DjFZMP5wbSrXXfjAaDFOJ7Fx z1ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779353152; x=1779957952; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=kyb28OIUn481MfgnfdB9ZYLpYVSe13EUaz8KBNS58Y+PX6nLcS2zSAdmXc61WN0Irl d0QHryDwRNR+/UKOA6OfA4MqMlDkDeaERaOKC/1f/ebl1bcRutDjCZC4AU2fp5sNqsKT yjBelQZmqVyRoN0L0pJxF1Y2xd/kfNhWquLN++fOYD6c5IQ7EKGncMzhiAvlMkLThS9H BkBju5q+eBBgAN8HKWqFTCPWEdn/a6qwxDjjnbvDOkqQcCCLyUQoFV5AMoOAB9UxlMwh DM9hxfFnvu/l+H3lYOV8szXZ60CycrlsALUpeiLuMInQV0aHsNHA/T2MEP0i0/5KXSTV 7SKQ== X-Gm-Message-State: AOJu0Yy8MZEkaGBminakELbDUTOVtv541fafFnHhPfLbnqMhcgRkUU+d DEEz0rHGVASw4YeaBuJI77bZ1kpxkdMpnAUnW6HFIQmR37r40aAHJY+Ox5W9MMpfJWJTKyJTKqp kwZQ/N3WTulUXYhcoXIxCBmlxKl6TthTfhRWV1oIAPsAPLDfCDYKqctvPmWFarVyYr+N/ X-Gm-Gg: Acq92OExp7y1DjCayLIsc+GBPGy5BJKotAA4GrJBEJK8LU0ybs30/h4LjQkMM7tXtCF V57D6Zadblk17JMAFODGBtkh9pxcp0DWSyPV/PlmJ/lOvlpKAba96huhOc4NSYYUt9lrnocB5gf vVDUzBp/6zYOf5MqEJFhXlayAwmNkH/+jCEjlTBU/yDCGJwNo2yDQC/2cZcYqq0H3I64+nmD+sJ qOVTX7Eyt6hsmPcy7RcJdgDhGAJNqV/KpiNjP+Q9EyWFCXaGi7MMPt+Q3jmr7L4VO5AbA5/oU4x Z3nnGQRs0LxaxCowh27f7P9CvnlSHM6hYaGi6eR/CnaZzBa+3A94BG0f4eBjBgLsKbL7LjA+iuf 0ADZ4eiIspbJmXUaK/mPmolm2akLwtYWiI71kPeVO58uHgbn1fnfR X-Received: by 2002:a17:90b:2708:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-36a43887a55mr2172282a91.0.1779353152308; Thu, 21 May 2026 01:45:52 -0700 (PDT) X-Received: by 2002:a17:90b:2708:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-36a43887a55mr2172239a91.0.1779353151814; Thu, 21 May 2026 01:45:51 -0700 (PDT) Received: from [10.217.222.91] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a46d53ea1sm723782a91.4.2026.05.21.01.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 01:45:51 -0700 (PDT) Message-ID: <57c26520-42dd-4159-bd2a-69874945cbbe@oss.qualcomm.com> Date: Thu, 21 May 2026 14:15:45 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support To: Konrad Dybcio , Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Frank Li , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com> <20260515-shikra_qcrypto-v1-3-80f07b345c29@oss.qualcomm.com> <8dfa0670-7605-497b-9d53-db9b4a8a3d8d@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <8dfa0670-7605-497b-9d53-db9b4a8a3d8d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bfhbluPB c=1 sm=1 tr=0 ts=6a0ec640 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=FZn51bsQql4VyS6HqkQA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: vxpIRSEXz49-2pdbcmuni_ybysoU6RrA X-Proofpoint-ORIG-GUID: vxpIRSEXz49-2pdbcmuni_ybysoU6RrA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4NSBTYWx0ZWRfX7LEwHx+gFoCo uuDwUfD2vSlXLwkkGRkce222S1egu2Dmy13SE5nr/XtsFeZIefUkonH2m8hlNIA0kUSzFpxj2Mk LFpm3B9mQIK7fABXqjjZneFAa8JGrjA1oxigpj3e1XDHB7Vjc0Wvj5ChgnJwJK/6ZpJt+X5OCV3 xU3ay6OCs1pAyMR6q3KpcBT6Uhc0yoPrfS9+i9A3oLuIo8F53ASgKoF7zWV2pYY5d5JyK0Un0U9 MVk3PPTWUGl/DtprdMVDrfKAEtXrOJgIFZrUYJV475Rl4jkSNcvopEJxY2z8cbT6FzXIOQ6vpV2 /5UW0rNsPXxmUuBD2PtvXDu6QxXIb6hg9K4+wtAJbv+cPYvyYauzpMNqbtr7vsNwiIHYtD8YobR 5Dmd+Tf+85qxG532XVyvuFomVF2juMKmAScqkG9BqgvfOIjZITOLuiKhEQpboJUwqeT5AIH/slq +KB/u8/rYOXAVN5zlwQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210085 On 15-05-2026 15:58, Konrad Dybcio wrote: > On 5/14/26 9:23 PM, Kuldeep Singh wrote: >> Add qcrypto and cryptobam support for shikra target. >> >> Signed-off-by: Kuldeep Singh >> --- >> arch/arm64/boot/dts/qcom/shikra.dtsi | 35 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi >> index 262c488add1e..dbac0e901d6e 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi >> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi >> @@ -541,6 +541,41 @@ config_noc: interconnect@1900000 { >> #interconnect-cells = <2>; >> }; >> >> + cryptobam: dma-controller@1b04000 { >> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; >> + reg = <0x0 0x01b04000 0x0 0x24000>; >> + interrupts = ; >> + #dma-cells = <1>; >> + iommus = <&apps_smmu 0x84 0x0011>, >> + <&apps_smmu 0x86 0x0011>, >> + <&apps_smmu 0x92 0x0>, > >> + <&apps_smmu 0x94 0x0011>, >> + <&apps_smmu 0x96 0x0011>, > > These two entries are logically the same (SID & ~mask) as the first two, > does it still work if you remove them? Yes, resulting sid is same for 84/94 and 86/92. Basically, the resulting sid could be same, it's an optimization which smmu is doing which can result in same SMR(Stream matching register) routing 2 different sid to same context bank. So, 2 sid can be used even though resulting sid remains same. Also, DT usually dictates what hw capabilities are supported and hence, captured all apps entries here to match the hardware description. I hope this answers your query. > > >> + <&apps_smmu 0x98 0x0001>, >> + <&apps_smmu 0x9F 0x0>; > > Let's keep lowercase hex Sure, will update in next rev. Please note, I'll be clubbing patches together in one series as suggested by krzysztof and fix this too that time. -- Regards Kuldeep