From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v2 15/24] drm/msm: dpu: Stop using encoder->crtc pointer Date: Fri, 16 Nov 2018 12:05:09 -0800 Message-ID: <580ced340265a3c45b31836291bfbb4c@codeaurora.org> References: <20181116184238.170034-1-sean@poorly.run> <20181116184238.170034-16-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181116184238.170034-16-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: Sean Paul , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0xMS0xNiAxMDo0MiwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEl0J3MgZm9yIGxlZ2FjeSBkcml2ZXJzLCBmb3Ig YXRvbWljIGRyaXZlcnMgY3J0Yy0+c3RhdGUtPmVuY29kZXJfbWFzawo+IHNob3VsZCBiZSB1c2Vk IHRvIG1hcCBlbmNvZGVyIHRvIGNydGMuCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAtIE5vbmUKPiAK PiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMuYyB8IDQ2ICsrKysrKysr LS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21z LmMgIHwgMTkgKysrKysrKy0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyks IDM2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfY3J0Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf Y3J0Yy5jCj4gaW5kZXggMTU2ZjRjNzdjYTQ0Li5hMDA4YTg3YTgxMTMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMKPiBAQCAtMjg0LDkgKzI4NCw5IEBAIGVu dW0gZHB1X2ludGZfbW9kZSBkcHVfY3J0Y19nZXRfaW50Zl9tb2RlKHN0cnVjdAo+IGRybV9jcnRj ICpjcnRjKQo+ICAJCXJldHVybiBJTlRGX01PREVfTk9ORTsKPiAgCX0KPiAKPiAtCWRybV9mb3Jf ZWFjaF9lbmNvZGVyKGVuY29kZXIsIGNydGMtPmRldikKPiAtCQlpZiAoZW5jb2Rlci0+Y3J0YyA9 PSBjcnRjKQo+IC0JCQlyZXR1cm4gZHB1X2VuY29kZXJfZ2V0X2ludGZfbW9kZShlbmNvZGVyKTsK PiArCS8qIFRPRE86IFJldHVybnMgdGhlIGZpcnN0IElOVEZfTU9ERSwgY291bGQgdGhlcmUgYmUg bXVsdGlwbGUKPiB2YWx1ZXM/ICovCj4gKwlkcm1fZm9yX2VhY2hfZW5jb2Rlcl9tYXNrKGVuY29k ZXIsIGNydGMtPmRldiwKPiBjcnRjLT5zdGF0ZS0+ZW5jb2Rlcl9tYXNrKQo+ICsJCXJldHVybiBk cHVfZW5jb2Rlcl9nZXRfaW50Zl9tb2RlKGVuY29kZXIpOwo+IAo+ICAJcmV0dXJuIElOVEZfTU9E RV9OT05FOwo+ICB9Cj4gQEAgLTU1MSwxMyArNTUxLDkgQEAgc3RhdGljIHZvaWQgZHB1X2NydGNf YXRvbWljX2JlZ2luKHN0cnVjdCBkcm1fY3J0Ywo+ICpjcnRjLAo+ICAJCXNwaW5fdW5sb2NrX2ly cXJlc3RvcmUoJmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICAJfQo+IAo+IC0JbGlzdF9mb3Jf ZWFjaF9lbnRyeShlbmNvZGVyLCAmZGV2LT5tb2RlX2NvbmZpZy5lbmNvZGVyX2xpc3QsIGhlYWQp Cj4gewo+IC0JCWlmIChlbmNvZGVyLT5jcnRjICE9IGNydGMpCj4gLQkJCWNvbnRpbnVlOwo+IC0K PiAtCQkvKiBlbmNvZGVyIHdpbGwgdHJpZ2dlciBwZW5kaW5nIG1hc2sgbm93ICovCj4gKwkvKiBl bmNvZGVyIHdpbGwgdHJpZ2dlciBwZW5kaW5nIG1hc2sgbm93ICovCj4gKwlkcm1fZm9yX2VhY2hf ZW5jb2Rlcl9tYXNrKGVuY29kZXIsIGNydGMtPmRldiwKPiBjcnRjLT5zdGF0ZS0+ZW5jb2Rlcl9t YXNrKQo+ICAJCWRwdV9lbmNvZGVyX3RyaWdnZXJfa2lja29mZl9wZW5kaW5nKGVuY29kZXIpOwo+ IC0JfQo+IAo+ICAJLyoKPiAgCSAqIElmIG5vIG1peGVycyBoYXZlIGJlZW4gYWxsb2NhdGVkIGlu IGRwdV9jcnRjX2F0b21pY19jaGVjaygpLAo+IEBAIC03MDQsNyArNzAwLDYgQEAgc3RhdGljIGlu dCBfZHB1X2NydGNfd2FpdF9mb3JfZnJhbWVfZG9uZShzdHJ1Y3QKPiBkcm1fY3J0YyAqY3J0YykK PiAgdm9pZCBkcHVfY3J0Y19jb21taXRfa2lja29mZihzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g IHsKPiAgCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcjsKPiAtCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBjcnRjLT5kZXY7Cj4gIAlzdHJ1Y3QgZHB1X2NydGMgKmRwdV9jcnRjID0gdG9fZHB1 X2NydGMoY3J0Yyk7Cj4gIAlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IF9kcHVfY3J0Y19nZXRf a21zKGNydGMpOwo+ICAJc3RydWN0IGRwdV9jcnRjX3N0YXRlICpjc3RhdGUgPSB0b19kcHVfY3J0 Y19zdGF0ZShjcnRjLT5zdGF0ZSk7Cj4gQEAgLTcyMCwxNiArNzE1LDEzIEBAIHZvaWQgZHB1X2Ny dGNfY29tbWl0X2tpY2tvZmYoc3RydWN0IGRybV9jcnRjIAo+ICpjcnRjKQo+IAo+ICAJRFBVX0FU UkFDRV9CRUdJTigiY3J0Y19jb21taXQiKTsKPiAKPiAtCWxpc3RfZm9yX2VhY2hfZW50cnkoZW5j b2RlciwgJmRldi0+bW9kZV9jb25maWcuZW5jb2Rlcl9saXN0LCBoZWFkKQo+IHsKPiArCS8qCj4g KwkgKiBFbmNvZGVyIHdpbGwgZmx1c2gvc3RhcnQgbm93LCB1bmxlc3MgaXQgaGFzIGEgdHggcGVu ZGluZy4gSWYKPiBzbywgaXQKPiArCSAqIG1heSBkZWxheSBhbmQgZmx1c2ggYXQgYW4gaXJxIGV2 ZW50IChlLmcuIHBwZG9uZSkKPiArCSAqLwo+ICsJZHJtX2Zvcl9lYWNoX2VuY29kZXJfbWFzayhl bmNvZGVyLCBjcnRjLT5kZXYsCj4gKwkJCQkgIGNydGMtPnN0YXRlLT5lbmNvZGVyX21hc2spIHsK PiAgCQlzdHJ1Y3QgZHB1X2VuY29kZXJfa2lja29mZl9wYXJhbXMgcGFyYW1zID0geyAwIH07Cj4g LQo+IC0JCWlmIChlbmNvZGVyLT5jcnRjICE9IGNydGMpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAt CQkvKgo+IC0JCSAqIEVuY29kZXIgd2lsbCBmbHVzaC9zdGFydCBub3csIHVubGVzcyBpdCBoYXMg YSB0eAo+IHBlbmRpbmcuCj4gLQkJICogSWYgc28sIGl0IG1heSBkZWxheSBhbmQgZmx1c2ggYXQg YW4gaXJxIGV2ZW50IChlLmcuCj4gcHBkb25lKQo+IC0JCSAqLwo+ICAJCWRwdV9lbmNvZGVyX3By ZXBhcmVfZm9yX2tpY2tvZmYoZW5jb2RlciwgJnBhcmFtcyk7Cj4gIAl9Cj4gCj4gQEAgLTc1NCwx MiArNzQ2LDggQEAgdm9pZCBkcHVfY3J0Y19jb21taXRfa2lja29mZihzdHJ1Y3QgZHJtX2NydGMg Cj4gKmNydGMpCj4gCj4gIAlkcHVfdmJpZl9jbGVhcl9lcnJvcnMoZHB1X2ttcyk7Cj4gCj4gLQls aXN0X2Zvcl9lYWNoX2VudHJ5KGVuY29kZXIsICZkZXYtPm1vZGVfY29uZmlnLmVuY29kZXJfbGlz dCwgaGVhZCkKPiB7Cj4gLQkJaWYgKGVuY29kZXItPmNydGMgIT0gY3J0YykKPiAtCQkJY29udGlu dWU7Cj4gLQo+ICsJZHJtX2Zvcl9lYWNoX2VuY29kZXJfbWFzayhlbmNvZGVyLCBjcnRjLT5kZXYs Cj4gY3J0Yy0+c3RhdGUtPmVuY29kZXJfbWFzaykKPiAgCQlkcHVfZW5jb2Rlcl9raWNrb2ZmKGVu Y29kZXIpOwo+IC0JfQpXZSB3b250IGJlIGhvbGRpbmcgdGhlIG1vZGVzZXQgbG9ja3MgaGVyZSAo YW5kIGluIGNydGNfYXRvbWljX2JlZ2luKSBpbiAKdGhlIGRpc3BsYXkgdGhyZWFkLiBJcwppdCBz YWZlIHRvIGl0ZXJhdGUgb3ZlciBlbmNvZGVyX21hc2s/Cj4gCj4gIGVuZDoKPiAgCXJlaW5pdF9j b21wbGV0aW9uKCZkcHVfY3J0Yy0+ZnJhbWVfZG9uZV9jb21wKTsKPiBAQCAtODgzLDExICs4NzEs OCBAQCBzdGF0aWMgdm9pZCBkcHVfY3J0Y19kaXNhYmxlKHN0cnVjdCBkcm1fY3J0YyAKPiAqY3J0 YykKPiAKPiAgCWRwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGUoY3J0YywgMCwgdHJ1ZSk7Cj4gCj4g LQlkcm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBjcnRjLT5kZXYpIHsKPiAtCQlpZiAoZW5j b2Rlci0+Y3J0YyAhPSBjcnRjKQo+IC0JCQljb250aW51ZTsKPiArCWRybV9mb3JfZWFjaF9lbmNv ZGVyX21hc2soZW5jb2RlciwgY3J0Yy0+ZGV2LAo+IGNydGMtPnN0YXRlLT5lbmNvZGVyX21hc2sp Cj4gIAkJZHB1X2VuY29kZXJfcmVnaXN0ZXJfZnJhbWVfZXZlbnRfY2FsbGJhY2soZW5jb2Rlciwg TlVMTCwKPiBOVUxMKTsKPiAtCX0KPiAKPiAgCW1lbXNldChjc3RhdGUtPm1peGVycywgMCwgc2l6 ZW9mKGNzdGF0ZS0+bWl4ZXJzKSk7Cj4gIAljc3RhdGUtPm51bV9taXhlcnMgPSAwOwo+IEBAIC05 MjIsMTIgKzkwNyw5IEBAIHN0YXRpYyB2b2lkIGRwdV9jcnRjX2VuYWJsZShzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gIAlEUk1fREVCVUdfS01TKCJjcnRjJWRcbiIsIGNydGMtPmJhc2UuaWQpOwo+ ICAJZHB1X2NydGMgPSB0b19kcHVfY3J0YyhjcnRjKTsKPiAKPiAtCWRybV9mb3JfZWFjaF9lbmNv ZGVyKGVuY29kZXIsIGNydGMtPmRldikgewo+IC0JCWlmIChlbmNvZGVyLT5jcnRjICE9IGNydGMp Cj4gLQkJCWNvbnRpbnVlOwo+ICsJZHJtX2Zvcl9lYWNoX2VuY29kZXJfbWFzayhlbmNvZGVyLCBj cnRjLT5kZXYsCj4gY3J0Yy0+c3RhdGUtPmVuY29kZXJfbWFzaykKPiAgCQlkcHVfZW5jb2Rlcl9y ZWdpc3Rlcl9mcmFtZV9ldmVudF9jYWxsYmFjayhlbmNvZGVyLAo+ICAJCQkJZHB1X2NydGNfZnJh bWVfZXZlbnRfY2IsICh2b2lkICopY3J0Yyk7Cj4gLQl9Cj4gCj4gIAltdXRleF9sb2NrKCZkcHVf Y3J0Yy0+Y3J0Y19sb2NrKTsKPiAgCXRyYWNlX2RwdV9jcnRjX2VuYWJsZShEUk1JRChjcnRjKSwg dHJ1ZSwgZHB1X2NydGMpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfa21zLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMu Ywo+IGluZGV4IDFiZWM0NTQwZjNlMS4uNjQxMzRkNjE5NzQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC0zMjAsNyArMzIwLDEwIEBAIHN0YXRpYyB2 b2lkIGRwdV9rbXNfcHJlcGFyZV9jb21taXQoc3RydWN0IG1zbV9rbXMKPiAqa21zLAo+ICAJc3Ry dWN0IGRwdV9rbXMgKmRwdV9rbXM7Cj4gIAlzdHJ1Y3QgbXNtX2RybV9wcml2YXRlICpwcml2Owo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldjsKPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAr CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiAgCXN0cnVjdCBkcm1fZW5jb2Rl ciAqZW5jb2RlcjsKPiArCWludCBpOwo+IAo+ICAJaWYgKCFrbXMpCj4gIAkJcmV0dXJuOwo+IEBA IC0zMzIsOSArMzM1LDEzIEBAIHN0YXRpYyB2b2lkIGRwdV9rbXNfcHJlcGFyZV9jb21taXQoc3Ry dWN0IG1zbV9rbXMKPiAqa21zLAo+ICAJcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlwbV9y dW50aW1lX2dldF9zeW5jKCZkcHVfa21zLT5wZGV2LT5kZXYpOwo+IAo+IC0JbGlzdF9mb3JfZWFj aF9lbnRyeShlbmNvZGVyLCAmZGV2LT5tb2RlX2NvbmZpZy5lbmNvZGVyX2xpc3QsIGhlYWQpCj4g LQkJaWYgKGVuY29kZXItPmNydGMgIT0gTlVMTCkKPiArCS8qIENhbGwgcHJlcGFyZV9jb21taXQg Zm9yIGFsbCBhZmZlY3RlZCBlbmNvZGVycyAqLwo+ICsJZm9yX2VhY2hfbmV3X2NydGNfaW5fc3Rh dGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPiArCQlkcm1fZm9yX2VhY2hfZW5jb2Rl cl9tYXNrKGVuY29kZXIsIGNydGMtPmRldiwKPiArCQkJCQkgIGNydGNfc3RhdGUtPmVuY29kZXJf bWFzaykgewo+ICAJCQlkcHVfZW5jb2Rlcl9wcmVwYXJlX2NvbW1pdChlbmNvZGVyKTsKPiArCQl9 Cj4gKwl9Cj4gIH0KPiAKPiAgLyoKPiBAQCAtMzQ0LDEzICszNTEsMTcgQEAgc3RhdGljIHZvaWQg ZHB1X2ttc19wcmVwYXJlX2NvbW1pdChzdHJ1Y3QgbXNtX2ttcwo+ICprbXMsCj4gIHZvaWQgZHB1 X2ttc19lbmNvZGVyX2VuYWJsZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCj4gIHsKPiAg CWNvbnN0IHN0cnVjdCBkcm1fZW5jb2Rlcl9oZWxwZXJfZnVuY3MgKmZ1bmNzID0KPiBlbmNvZGVy LT5oZWxwZXJfcHJpdmF0ZTsKPiAtCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGVuY29kZXItPmNy dGM7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZW5jb2Rlci0+ZGV2Owo+ICsJc3RydWN0 IGRybV9jcnRjICpjcnRjOwo+IAo+ICAJLyogRm9yd2FyZCB0aGlzIGVuYWJsZSBjYWxsIHRvIHRo ZSBjb21taXQgaG9vayAqLwo+ICAJaWYgKGZ1bmNzICYmIGZ1bmNzLT5jb21taXQpCj4gIAkJZnVu Y3MtPmNvbW1pdChlbmNvZGVyKTsKPiAKPiAtCWlmIChjcnRjICYmIGNydGMtPnN0YXRlLT5hY3Rp dmUpIHsKPiArCWRybV9mb3JfZWFjaF9jcnRjKGNydGMsIGRldikgewo+ICsJCWlmICghKGNydGMt PnN0YXRlLT5lbmNvZGVyX21hc2sgJgo+IGRybV9lbmNvZGVyX21hc2soZW5jb2RlcikpKQo+ICsJ CQljb250aW51ZTsKPiArCj4gIAkJdHJhY2VfZHB1X2ttc19lbmNfZW5hYmxlKERSTUlEKGNydGMp KTsKPiAgCQlkcHVfY3J0Y19jb21taXRfa2lja29mZihjcnRjKTsKPiAgCX0KCi0tIApKZXlrdW1h ciBTCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVk cmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=