Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "André Draszik" <andre.draszik@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Avri Altman" <avri.altman@wdc.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Eric Biggers" <ebiggers@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	kernel-team@android.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: fix use-after free in init error and remove paths
Date: Tue, 14 Jan 2025 09:55:16 -0800	[thread overview]
Message-ID: <58f1b701-68da-49c0-b2b1-e079bad4cd08@acm.org> (raw)
In-Reply-To: <20250114-ufshcd-fix-v2-1-2dc627590a4a@linaro.org>

On 1/14/25 8:16 AM, André Draszik wrote:
> +/**
> + * ufshcd_scsi_host_put_callback - deallocate underlying Scsi_Host and
> + *				   thereby the Host Bus Adapter (HBA)
> + * @host: pointer to SCSI host
> + */
> +static void ufshcd_scsi_host_put_callback(void *host)
> +{
> +	scsi_host_put(host);
> +}

Please rename ufshcd_scsi_host_put_callback() such that the function 
name makes clear when this function is called instead of what the 
function does.

Thanks,

Bart.

  parent reply	other threads:[~2025-01-14 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14 16:16 [PATCH v2] scsi: ufs: fix use-after free in init error and remove paths André Draszik
2025-01-14 16:54 ` André Draszik
2025-01-14 17:55 ` Bart Van Assche [this message]
2025-01-14 19:56   ` André Draszik
2025-01-14 20:41     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58f1b701-68da-49c0-b2b1-e079bad4cd08@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=avri.altman@wdc.com \
    --cc=ebiggers@kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.griffin@linaro.org \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox