From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8264DC07E99 for ; Fri, 9 Jul 2021 22:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E6A9613BC for ; Fri, 9 Jul 2021 22:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbhGIWRX (ORCPT ); Fri, 9 Jul 2021 18:17:23 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:38943 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhGIWRX (ORCPT ); Fri, 9 Jul 2021 18:17:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625868879; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=ghUqnG/P49X6tRq7x8XPZKLYsowRvouIU1MAIujMU/Q=; b=IKsg8M1AD6jBlGpuyS10zEzW96/SpGsFakKE5YK6Og0/q2iVS7XEFx3RpnBCJ5Y1PG+CvVUO JJ3xHOhB8ZqzhxDbLRD//hy4ri8W2H7qgehMgnJqv7nNv5r834iuF3wFDF7CI/2e+qNUVc9w UfG//bHwsnxysLCxeLLxhj00dj0= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 60e8ca305e3e57240b74b011 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 09 Jul 2021 22:14:08 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9135AC43145; Fri, 9 Jul 2021 22:14:07 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3B6FEC4338A; Fri, 9 Jul 2021 22:14:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 09 Jul 2021 15:14:06 -0700 From: abhinavk@codeaurora.org To: Dmitry Baryshkov Cc: Bjorn Andersson , Rob Clark , Sean Paul , Jonathan Marek , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH v1 2/7] drm/msm/dsi: add two helper functions In-Reply-To: <20210708122833.363451-3-dmitry.baryshkov@linaro.org> References: <20210708122833.363451-1-dmitry.baryshkov@linaro.org> <20210708122833.363451-3-dmitry.baryshkov@linaro.org> Message-ID: <5924470a7b3e94c70ceab7ab49e4b1be@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-07-08 05:28, Dmitry Baryshkov wrote: > Add two helper functions to be used by display drivers for setting up > encoders. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dsi/dsi.c | 7 +++++++ > drivers/gpu/drm/msm/dsi/dsi_manager.c | 14 ++++++-------- > drivers/gpu/drm/msm/msm_drv.h | 12 ++++++++++-- > 3 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c > b/drivers/gpu/drm/msm/dsi/dsi.c > index 75afc12a7b25..5201d7eb0490 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -13,6 +13,13 @@ struct drm_encoder *msm_dsi_get_encoder(struct > msm_dsi *msm_dsi) > return msm_dsi->encoder; > } > > +bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi) > +{ > + unsigned long host_flags = > msm_dsi_host_get_mode_flags(msm_dsi->host); > + > + return !(host_flags & MIPI_DSI_MODE_VIDEO); > +} > + > static int dsi_get_phy(struct msm_dsi *msm_dsi) > { > struct platform_device *pdev = msm_dsi->pdev; > diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c > b/drivers/gpu/drm/msm/dsi/dsi_manager.c > index 1173663c6d5d..a81105633d3c 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c > @@ -216,12 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge > *bridge) > return dsi_bridge->id; > } > > -static bool dsi_mgr_is_cmd_mode(struct msm_dsi *msm_dsi) > -{ > - unsigned long host_flags = > msm_dsi_host_get_mode_flags(msm_dsi->host); > - return !(host_flags & MIPI_DSI_MODE_VIDEO); > -} > - > void msm_dsi_manager_setup_encoder(int id) > { > struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); > @@ -231,7 +225,7 @@ void msm_dsi_manager_setup_encoder(int id) > > if (encoder && kms->funcs->set_encoder_mode) > kms->funcs->set_encoder_mode(kms, encoder, > - dsi_mgr_is_cmd_mode(msm_dsi)); > + msm_dsi_is_cmd_mode(msm_dsi)); > } > > static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 > id) > @@ -276,7 +270,7 @@ static int msm_dsi_manager_panel_init(struct > drm_connector *conn, u8 id) > if (other_dsi && other_dsi->panel && kms->funcs->set_split_display) { > kms->funcs->set_split_display(kms, master_dsi->encoder, > slave_dsi->encoder, > - dsi_mgr_is_cmd_mode(msm_dsi)); > + msm_dsi_is_cmd_mode(msm_dsi)); > } > > out: > @@ -839,3 +833,7 @@ void msm_dsi_manager_unregister(struct msm_dsi > *msm_dsi) > msm_dsim->dsi[msm_dsi->id] = NULL; > } > > +bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi) > +{ > + return IS_BONDED_DSI(); > +} > diff --git a/drivers/gpu/drm/msm/msm_drv.h > b/drivers/gpu/drm/msm/msm_drv.h > index 1a48a709ffb3..e0528dfd965e 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -350,7 +350,8 @@ void __exit msm_dsi_unregister(void); > int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device > *dev, > struct drm_encoder *encoder); > void msm_dsi_snapshot(struct msm_disp_state *disp_state, struct > msm_dsi *msm_dsi); > - > +bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi); > +bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi); > #else > static inline void __init msm_dsi_register(void) > { > @@ -367,7 +368,14 @@ static inline int msm_dsi_modeset_init(struct > msm_dsi *msm_dsi, > static inline void msm_dsi_snapshot(struct msm_disp_state > *disp_state, struct msm_dsi *msm_dsi) > { > } > - > +static inline bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi) > +{ > + return false; > +} > +static bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi) > +{ > + return false; > +} > #endif > > #ifdef CONFIG_DRM_MSM_DP