From: "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: sboyd@codeaurora.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org, spjoshi@codeaurora.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [RFC 3/3] arm64: dts: msm8996: Add SMP2P node for Qualcomm SLPI rproc driver.
Date: Mon, 16 Jan 2017 11:33:39 +0530 [thread overview]
Message-ID: <592f1710-6efb-e712-33ae-04e0fdace575@codeaurora.org> (raw)
In-Reply-To: <20170112182416.GH10531@minitux>
On 1/12/2017 11:54 PM, Bjorn Andersson wrote:
> On Thu 12 Jan 05:53 PST 2017, Avaneesh Kumar Dwivedi wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 9d1d7ad..2457b20 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -541,5 +541,29 @@
>> #interrupt-cells = <2>;
>> };
>> };
>> +
>> + smp2p-slpi {
>> + compatible = "qcom,smp2p";
>> + qcom,smem = <481>, <430>;
>> +
>> + interrupts = <0 178 1>;
> Please use <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>;
OK,
>
>> +
>> + qcom,ipc = <&apcs 4 8>;
> Looking at qcom,smp2p-dsps downstream I get this to <&apcs 16 26>;
I think i missed it, during validation it was working with <&apcs 4 8>
and so did not realize to verify its validity.
will check and update.
>
>> +
>> + qcom,local-pid = <0>;
>> + qcom,remote-pid = <3>;
>> +
>> + slpi_smp2p_in: slave-kernel {
>> + qcom,entry-name = "slave-kernel";
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
> Please correct the indentation of this block.
OK.
>
>> +
>> + slpi_smp2p_out: master-kernel {
>> + qcom,entry-name = "master-kernel";
>> + #qcom,state-cells = <1>;
>> + };
>> + };
> Regards,
> Bjorn
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2017-01-16 6:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:53 [RFC 0/3] remoteproc: Introducing Qualcomm SLPI rproc driver Avaneesh Kumar Dwivedi
2017-01-12 13:53 ` [RFC 1/3] remoteproc: qcom: Introduce Qualcomm low pass sensor peripheral loader Avaneesh Kumar Dwivedi
2017-01-12 20:41 ` Sarangdhar Joshi
2017-01-16 5:15 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-17 19:30 ` Sarangdhar Joshi
2017-01-18 23:34 ` Bjorn Andersson
2017-01-19 5:00 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-12 13:53 ` [RFC 2/3] dt-binding: remoteproc: Introduce DT binding for Qualcomm slpi subsystem Avaneesh Kumar Dwivedi
2017-01-12 18:39 ` Bjorn Andersson
2017-01-16 6:01 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-12 13:53 ` [RFC 3/3] arm64: dts: msm8996: Add SMP2P node for Qualcomm SLPI rproc driver Avaneesh Kumar Dwivedi
2017-01-12 18:24 ` Bjorn Andersson
2017-01-16 6:03 ` Dwivedi, Avaneesh Kumar (avani) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592f1710-6efb-e712-33ae-04e0fdace575@codeaurora.org \
--to=akdwived@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox