From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 2/3 v2] iio: adc: break out common code from SPMI VADC Date: Tue, 10 Jan 2017 21:14:02 +0000 Message-ID: <5935eb9c-a1e8-adb9-8a56-bed2236028ee@kernel.org> References: <1481842105-14047-1-git-send-email-linus.walleij@linaro.org> <717ea1c4-33af-f0ca-e018-5d7ac87506e1@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57921 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdAJVOG (ORCPT ); Tue, 10 Jan 2017 16:14:06 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, "Ivan T . Ivanov" , Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , linux-iio-owner@vger.kernel.org On 10/01/17 14:21, jic23@kernel.org wrote: > On 10.01.2017 08:54, Linus Walleij wrote: >> On Fri, Dec 30, 2016 at 8:01 PM, Jonathan Cameron wrote: >>> On 15/12/16 22:48, Linus Walleij wrote: >>>> The SPMI VADC and the earlier XOADC share a subset of >>>> common code, so to be able to use the same code in both >>>> drivers, we break out a separate file with the common code, >>>> prefix exported functions that are no longer static with >>>> qcom_* and bake an object qcom-vadc.o that contains both >>>> files: qcom-vadc-common.o and qcom-spmi-vadc.o. >>>> >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-arm-msm@vger.kernel.org >>>> Cc: Ivan T. Ivanov >>>> Cc: Andy Gross >>>> Cc: Bjorn Andersson >>>> Cc: Stephen Boyd >>>> Cc: Srinivas Kandagatla >>>> Signed-off-by: Linus Walleij >>> >>> Looks superficially fine, but I'm guessing will need a respin >>> as we have a fair bit of new stuff (and a couple of fixes) going >>> through this driver at the moment. >>> >>> All but the two fixes I posted a few mins ago are in my testing >>> branch and should go to Greg once I have confirmed testing on >>> those two fixes. >> >> I looked at the git and "testing" >> contains a top commit named "guessing" fixing some 64bit >> artithmetic (which looks correct) in the driver, shall I simply >> rebase on top of that and hope for the best? :) > I'm an idiot and pushed out the wrong branch. Will fix up when > I get home and push one with a sensible patch title! > (It'll be the same content though - feel free to Ack that if > you like ;) > > Not my best half asleep patch writing ;) Fixed... It's called testing for a reason ;) Jonathan > > Jonathan >> >> Yours, >> Linus Walleij >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html