From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>
Cc: Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"open list:QUALCOMM VENUS VIDEO ACCELERATOR DRIVER"
<linux-media@vger.kernel.org>,
"open list:QUALCOMM VENUS VIDEO ACCELERATOR DRIVER"
<linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "media: hfi_parser: don't trick gcc with a wrong expected size"
Date: Thu, 6 Jun 2019 23:57:16 +0300 [thread overview]
Message-ID: <59d458b5-8c29-1c66-ea39-b678889e25cc@linaro.org> (raw)
In-Reply-To: <20190605201941.4150-1-jonathan@marek.ca>
Hi Jonathan,
I sent a fix for that here [1] and Mauro already taken it.
regards,
Stan
[1] https://patchwork.kernel.org/patch/10963369/
On 5.06.19 г. 23:19 ч., Jonathan Marek wrote:
> This reverts commit ded716267196862809e5926072adc962a611a1e3.
>
> This change doesn't make any sense and breaks the driver.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/media/platform/qcom/venus/hfi_helper.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
> index 34ea503a9842..15804ad7e65d 100644
> --- a/drivers/media/platform/qcom/venus/hfi_helper.h
> +++ b/drivers/media/platform/qcom/venus/hfi_helper.h
> @@ -569,7 +569,7 @@ struct hfi_capability {
>
> struct hfi_capabilities {
> u32 num_capabilities;
> - struct hfi_capability *data;
> + struct hfi_capability data[1];
> };
>
> #define HFI_DEBUG_MSG_LOW 0x01
> @@ -726,7 +726,7 @@ struct hfi_profile_level {
>
> struct hfi_profile_level_supported {
> u32 profile_count;
> - struct hfi_profile_level *profile_level;
> + struct hfi_profile_level profile_level[1];
> };
>
> struct hfi_quality_vs_speed {
>
prev parent reply other threads:[~2019-06-06 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 20:19 [PATCH] Revert "media: hfi_parser: don't trick gcc with a wrong expected size" Jonathan Marek
2019-06-05 20:41 ` Mauro Carvalho Chehab
2019-06-05 21:27 ` Jonathan Marek
2019-06-06 20:57 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59d458b5-8c29-1c66-ea39-b678889e25cc@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).