Re: [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi Redmi K20 Pro

[Piyush Raj Chouhan <pc1598@mainlining.org>]

Hi, konrad 


>> +
>> +&i2c19 {
>> +	/* goodix,gt9886 @5d  */
>
>I see there's driver support for the GT98*97* - is there a chance you can
>reuse some of it?
>

I am currently testing touch on gtx8 driver which currently is in lkml, once its merged we could add support for it.

https://lore.kernel.org/linux-input/20250918-gtx8-v1-0-cba879c84775@mainlining.org

[...]
>> +	connector {
>> +		compatible = "usb-c-connector";
>> +		power-role = "source";
>> +		data-role = "dual";
>> +		self-powered;
>> +
>> +		source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_DUAL_ROLE |
>> +					 PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>;
>
>Have you verified this is in line with your specific device's
>downstream kernel?

Yes i have verified it.

[...]
>> +&pm8150l_lpg {
>> +
>> +	status = "okay";
>
>ditto> +	led@1 {
>> +		reg = <1>;
>> +		color = <LED_COLOR_ID_WHITE>;
>> +		function = LED_FUNCTION_STATUS;
>> +
>> +		status = "disabled";
>
>?

Raphael doesn’t have a white LED. I missed cleaning that. I’ll remove it in the next revision.

>
>> +	};
>> +
>> +
>> +	led@2 {
>> +		reg = <2>;
>> +		color = <LED_COLOR_ID_RED>;
>> +		function = LED_FUNCTION_STATUS;
>> +		function-enumerator = <0>;
>> +	};
>> +
>> +	led@3 {
>> +		reg = <3>;
>> +		color = <LED_COLOR_ID_RED>;
>> +		function = LED_FUNCTION_STATUS;
>> +		function-enumerator = <1>;
>> +	};
>
>Are there really two separate red LEDs?

Yes, it has popup camera with an LED on both side, i have verified functionality of both LEDs. 


[...]
>
>> +&usb_1_dwc3 {
>> +	dr_mode = "otg";
>> +	maximum-speed = "high-speed";
>> +
>> +	/* Remove USB3 phy */
>> +	phys = <&usb_1_hsphy>;
>> +	phy-names = "usb2-phy";
>
>Is this a physical limitation, i.e. missing wires?

Yes it is a physical limitation and downstream configured it similarly,

[...]

Thanks for all the rest of improvement suggestions.

Best regards
Piyush Raj Chouhan