From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EAD4265CBD for ; Mon, 28 Jul 2025 13:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710292; cv=none; b=tHBMa5k/JdlKyFQwlmmm5B9JXy+PlLvB+n9yuMpBo7Uzt4OcF13WYrnXhiSoUgrAtAHI5SWVOHJTtht4BTmtryMXx38bPdNSEQySYYgOrqlkmu948ySHNLdnQ9S7gkL3CGX23xbcih/l9OOLxnWTZB+DWf2GiUaSbJ5fcogZnEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710292; c=relaxed/simple; bh=7kEmjD7J1ByYEPN6gK5wIGaNyoEK7cRCpksvz+MpqDM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g36xsG0uj2RhX+SP0xI1qaFNBJH9Y0JVa0hNpvbG/oqvhIU3B03gVvrNfyAEFv1+AV6yp5b/ncJ8NkoZCbBD05Q5TWB2Qxbj4lYHf+MyOW82pSoDW0mW8IeSJ0Jv/IYCHP8i1s6FdQZZrYiNm0h3a7mMZCRRYDKI1GvtFlgBBN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R+HQha42; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R+HQha42" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-af66f444488so67409066b.0 for ; Mon, 28 Jul 2025 06:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753710288; x=1754315088; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RC668nCt8mHHP3FnT6kcpHmAaYm5QP6my+V/404SJa4=; b=R+HQha42Vqw9TWuBjg8AV52UGW5XNhAOixTpOalAjMsZ1H8AOGXtBbdmGPfU2nVyMk vZIrgBXOlszX0g13BEBsZwMq57KW3lv5xfGpfyI/9gAi22y+Ndv3JAQTC69L9K4GhtCU dTDCm7xvNxxPYBPzM6rmdZbPb2QV0CYygmHyTgHF79dKVQt+k9+gyW2KO9ibTRpMbW20 F96ACUpEyOWqIekFz4PKrzDaA8POPUhzdmATL1LwlLwYuhpGUzac+o3VArx9KgZHubWu 5/stw37OaFfXjf4cmNU3BGAYETCwgZDJ4SYbSay2wzGZoLbd77p6rc+/J2ekmPpVEzAY VTMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753710288; x=1754315088; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RC668nCt8mHHP3FnT6kcpHmAaYm5QP6my+V/404SJa4=; b=v2km42Wpq+yLErnAMiJdFjtUbWiqXW3p75jmcSFwGsNSOs5L23XDsmDNa9wLdt+J0v U2jhpjr4pW8vDavQq6E5/dIOnBmoMKF3V2U0hfXz6Lj2hF1ner2f6VejbpxlEuQhiFUE T+jXWKb3YjNIT3YoscRbEraKcr+ue+nZbeS6aW2+dX98EOOJBAXKeunXyJuLqMRtscar FB+8AYbL3TRf6UQ657mXO+7QjX1mZaKXp0XAdvU6Y8CMSkSpjgSnlBBejmUjTb6E8aQ4 xJeBNpG4vnAxp/DxQv3DYCB5iS/xCyEuR+GtswS+Fc8c3hBH50ymeUlqvhQAOwv2nUTh elBw== X-Forwarded-Encrypted: i=1; AJvYcCUUpdoC9P4g+6Da2gd0a5dr7q3aNR/Ob+HuvUtAPoGN6AlnQN0pmgWqYg2XKEH4LfeBRy+zuZCAQewOcff3@vger.kernel.org X-Gm-Message-State: AOJu0YxDF4OZFd4EJm8ZPNAKg/KW6NJ7aEgvX25NgLK+loIRgAzsDm0Q MTSvTDIcGOpe3K1AkSnvGjBRf6pBDZZavB55b4FGDs1Sqd6CS3EyjMwwx1txVoLZICE= X-Gm-Gg: ASbGncsIVEY8lB0o7m5uz8ipNjFuJBwRYyQ2P/MqgGehkMJ2RqQ8RF+OAl7YPEAlD97 Eo9MkR3WgKGsLma0W1fJeoQMOK1Mg32i6Apq23BtBI+XNRkHN2PlZhx7FwAc8OxnI9atQqspg2P J7HZ2XRtBmCRmn/NzC3oxdMT93vdPaSrI7+L4F0HtiY2Wac2zdbtDm5BL3GfZ131IUpigiAKy/3 4vYfJk/NkdFKt3vDArcRJ4SHvSsSC4LBVGUAYIob5AKKhy2z4oJ240dBvvla4n4Ez0Na3w8vprq gSqJzxN5ZV+ybyJGwOi6MBSnUK54c7n3qJf6FWsdi+q9DMqtR4EuHcEL5m7sjab9o473KK5r+qY w8Ji2aXQirzR3I30NgcLdklbLnhsM0Ww5zXMofFidLA5+B9uo9Cusjh9F7TFeIy8= X-Google-Smtp-Source: AGHT+IELW+a3KhmjkLCdMZPX2WGb73CXN0xX5TnTiHq9x7ZvKzBuKTWC2hjTDdFNf3HgtVm9iVz32w== X-Received: by 2002:a17:907:da5:b0:ae3:4f99:a5a5 with SMTP id a640c23a62f3a-af61c2aededmr1250106966b.6.1753710287770; Mon, 28 Jul 2025 06:44:47 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af635a6314asm425521366b.91.2025.07.28.06.44.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jul 2025 06:44:46 -0700 (PDT) Message-ID: <5ac76f1e-21d1-4265-8afe-b4b7209cfc5a@linaro.org> Date: Mon, 28 Jul 2025 14:44:45 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] media: qcom: camss: Rename camss-csid-780.c to camss-csid-gen3.c To: Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250703171938.3606998-1-quic_vikramsa@quicinc.com> <20250703171938.3606998-2-quic_vikramsa@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250703171938.3606998-2-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/07/2025 18:19, Vikram Sharma wrote: > Rename the file camss-csid-780.c to camss-csid-gen3.c to enable > reuse of CSID logic across multiple SoCs. > > The SA8775P SoC includes CSID 690, which is functionally very > similar to CSID 780, with only minor differences in register > bitfields. This rename prepares the codebase for supporting > additional SoCs without duplicating CSID logic. > > Signed-off-by: Vikram Sharma > --- > drivers/media/platform/qcom/camss/Makefile | 2 +- > .../qcom/camss/{camss-csid-780.c => camss-csid-gen3.c} | 8 +++++--- > .../qcom/camss/{camss-csid-780.h => camss-csid-gen3.h} | 9 +++++---- > drivers/media/platform/qcom/camss/camss-csid.h | 2 +- > drivers/media/platform/qcom/camss/camss.c | 10 +++++----- > 5 files changed, 17 insertions(+), 14 deletions(-) > rename drivers/media/platform/qcom/camss/{camss-csid-780.c => camss-csid-gen3.c} (98%) > rename drivers/media/platform/qcom/camss/{camss-csid-780.h => camss-csid-gen3.h} (84%) > > diff --git a/drivers/media/platform/qcom/camss/Makefile b/drivers/media/platform/qcom/camss/Makefile > index d26a9c24a430..ee869e69521a 100644 > --- a/drivers/media/platform/qcom/camss/Makefile > +++ b/drivers/media/platform/qcom/camss/Makefile > @@ -8,7 +8,7 @@ qcom-camss-objs += \ > camss-csid-4-7.o \ > camss-csid-680.o \ > camss-csid-gen2.o \ > - camss-csid-780.o \ > + camss-csid-gen3.o \ > camss-csiphy-2ph-1-0.o \ > camss-csiphy-3ph-1-0.o \ > camss-csiphy.o \ > diff --git a/drivers/media/platform/qcom/camss/camss-csid-780.c b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > similarity index 98% > rename from drivers/media/platform/qcom/camss/camss-csid-780.c > rename to drivers/media/platform/qcom/camss/camss-csid-gen3.c > index 4c720d177731..0941152ec301 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-780.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > @@ -4,6 +4,8 @@ > * > * Copyright (c) 2024 Qualcomm Technologies, Inc. > */ > + > + Dead newlines. > #include > #include > #include > @@ -13,7 +15,7 @@ > > #include "camss.h" > #include "camss-csid.h" > -#include "camss-csid-780.h" > +#include "camss-csid-gen3.h" > > #define CSID_IO_PATH_CFG0(csid) (0x4 * (csid)) > #define OUTPUT_IFE_EN 0x100 > @@ -259,7 +261,7 @@ static irqreturn_t csid_isr(int irq, void *dev) > > if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i)) { > /* > - * For Titan 780, bus done and RUP IRQ have been moved to > + * For Titan Gen3, bus done and RUP IRQ have been moved to > * CSID from VFE. Once CSID received bus done, need notify > * VFE of this event. Trigger VFE to handle bus done process. > */ > @@ -325,7 +327,7 @@ static void csid_subdev_init(struct csid_device *csid) > csid->testgen.nmodes = CSID_PAYLOAD_MODE_DISABLED; > } > > -const struct csid_hw_ops csid_ops_780 = { > +const struct csid_hw_ops csid_ops_gen3 = { > .configure_stream = csid_configure_stream, > .configure_testgen_pattern = csid_configure_testgen_pattern, > .hw_version = csid_hw_version, > diff --git a/drivers/media/platform/qcom/camss/camss-csid-780.h b/drivers/media/platform/qcom/camss/camss-csid-gen3.h > similarity index 84% > rename from drivers/media/platform/qcom/camss/camss-csid-780.h > rename to drivers/media/platform/qcom/camss/camss-csid-gen3.h > index a990c66a60ff..e6298042ae74 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-780.h > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.h > @@ -1,13 +1,13 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * camss-csid-780.h > + * camss-csid-gen3.h > * > * Qualcomm MSM Camera Subsystem - CSID (CSI Decoder) Module Generation 3 > * > * Copyright (c) 2024 Qualcomm Technologies, Inc. > */ > -#ifndef __QC_MSM_CAMSS_CSID_780_H__ > -#define __QC_MSM_CAMSS_CSID_780_H__ > +#ifndef __QC_MSM_CAMSS_CSID_GEN3_H__ > +#define __QC_MSM_CAMSS_CSID_GEN3_H__ > > #define DECODE_FORMAT_UNCOMPRESSED_8_BIT 0x1 > #define DECODE_FORMAT_UNCOMPRESSED_10_BIT 0x2 > @@ -18,8 +18,9 @@ > #define DECODE_FORMAT_UNCOMPRESSED_24_BIT 0x7 > #define DECODE_FORMAT_PAYLOAD_ONLY 0xf > > + another dead newline > #define PLAIN_FORMAT_PLAIN8 0x0 /* supports DPCM, UNCOMPRESSED_6/8_BIT */ > #define PLAIN_FORMAT_PLAIN16 0x1 /* supports DPCM, UNCOMPRESSED_10/16_BIT */ > #define PLAIN_FORMAT_PLAIN32 0x2 /* supports UNCOMPRESSED_20_BIT */ > > -#endif /* __QC_MSM_CAMSS_CSID_780_H__ */ > +#endif /* __QC_MSM_CAMSS_CSID_GEN3_H__ */ > diff --git a/drivers/media/platform/qcom/camss/camss-csid.h b/drivers/media/platform/qcom/camss/camss-csid.h > index 9dc826d8c8f6..62273ca9f199 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.h > +++ b/drivers/media/platform/qcom/camss/camss-csid.h > @@ -215,7 +215,7 @@ extern const struct csid_hw_ops csid_ops_4_1; > extern const struct csid_hw_ops csid_ops_4_7; > extern const struct csid_hw_ops csid_ops_680; > extern const struct csid_hw_ops csid_ops_gen2; > -extern const struct csid_hw_ops csid_ops_780; > +extern const struct csid_hw_ops csid_ops_gen3; > > /* > * csid_is_lite - Check if CSID is CSID lite. > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 06f42875702f..1431e08dc04a 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -2285,7 +2285,7 @@ static const struct camss_subdev_resources csid_res_8550[] = { > .csid = { > .is_lite = false, > .parent_dev_ops = &vfe_parent_dev_ops, > - .hw_ops = &csid_ops_780, > + .hw_ops = &csid_ops_gen3, > .formats = &csid_formats_gen2 > } > }, > @@ -2300,7 +2300,7 @@ static const struct camss_subdev_resources csid_res_8550[] = { > .csid = { > .is_lite = false, > .parent_dev_ops = &vfe_parent_dev_ops, > - .hw_ops = &csid_ops_780, > + .hw_ops = &csid_ops_gen3, > .formats = &csid_formats_gen2 > } > }, > @@ -2315,7 +2315,7 @@ static const struct camss_subdev_resources csid_res_8550[] = { > .csid = { > .is_lite = false, > .parent_dev_ops = &vfe_parent_dev_ops, > - .hw_ops = &csid_ops_780, > + .hw_ops = &csid_ops_gen3, > .formats = &csid_formats_gen2 > } > }, > @@ -2330,7 +2330,7 @@ static const struct camss_subdev_resources csid_res_8550[] = { > .csid = { > .is_lite = true, > .parent_dev_ops = &vfe_parent_dev_ops, > - .hw_ops = &csid_ops_780, > + .hw_ops = &csid_ops_gen3, > .formats = &csid_formats_gen2 > } > }, > @@ -2345,7 +2345,7 @@ static const struct camss_subdev_resources csid_res_8550[] = { > .csid = { > .is_lite = true, > .parent_dev_ops = &vfe_parent_dev_ops, > - .hw_ops = &csid_ops_780, > + .hw_ops = &csid_ops_gen3, > .formats = &csid_formats_gen2 > } > } I can fix those newlines, no need for a v4. Reviewed-by: Bryan O'Donoghue