Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sebastian Reichel <sre@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Subbaraman Narayanamurthy <quic_subbaram@quicinc.com>,
	Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v3 4/4] power: supply: Introduce Qualcomm PMIC GLINK power supply
Date: Mon, 30 Jan 2023 15:30:11 +0100	[thread overview]
Message-ID: <5ace1821-1892-ace5-c230-34200119cc55@linaro.org> (raw)
In-Reply-To: <20230130042003.577063-5-quic_bjorande@quicinc.com>

On 30/01/2023 05:20, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> The PMIC GLINK service, running on a coprocessor of modern Qualcomm
> platforms, deals with battery charging and fuel gauging, as well as
> reporting status of AC and wireless power supplies.
> 
> As this is just one of the functionalities provided by the PMIC GLINK
> service, this power supply driver is implemented as an auxilirary bus
> driver, spawned by the main "pmic glink" driver when the PMIC GLINK
> service is detected.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8350 PDX215
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> 
> Changes since v2:
> - None
> 
>   drivers/power/supply/Kconfig        |    9 +
>   drivers/power/supply/Makefile       |    1 +
>   drivers/power/supply/qcom_battmgr.c | 1421 +++++++++++++++++++++++++++
>   3 files changed, 1431 insertions(+)
>   create mode 100644 drivers/power/supply/qcom_battmgr.c
> 

<snip>


Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Devices doesn't have a battery, but it behaved as expected and values were coherent:
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-MTP & SM8450-HDK

      reply	other threads:[~2023-01-30 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30  4:19 [PATCH v3 0/4] soc: qcom: Introduce PMIC GLINK Bjorn Andersson
2023-01-30  4:20 ` [PATCH v3 1/4] dt-bindings: soc: qcom: Introduce PMIC GLINK binding Bjorn Andersson
2023-01-30  4:20 ` [PATCH v3 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver Bjorn Andersson
2023-01-30 14:28   ` Neil Armstrong
2023-01-30  4:20 ` [PATCH v3 3/4] soc: qcom: pmic_glink: Introduce altmode support Bjorn Andersson
2023-01-30 14:28   ` Neil Armstrong
2023-01-30  4:20 ` [PATCH v3 4/4] power: supply: Introduce Qualcomm PMIC GLINK power supply Bjorn Andersson
2023-01-30 14:30   ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ace1821-1892-ace5-c230-34200119cc55@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox