From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767E219ADB0 for ; Tue, 28 Jan 2025 10:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738061160; cv=none; b=BlbELyPnHIi700fZZMAq2lcl0nKatUcsX0cF5p+xCPoe8suxo8WN/UDukBus10ciDk5OgZYO1x52Bv3W6eKqA9b0wsCgO4A5Jy4+m8BLjHofjliPRswyOFCVil7tY47zTSZsB1P8Z1hLgsCiCErCrSJ1Zt98KFWV+wZUkDFd6GQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738061160; c=relaxed/simple; bh=GJMM8b0YGs6hY400QPvNBX6AR5cfnc9XZ4UHVNpX/rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hRkC8n120JgYn5kaJD4kGz3MJPEA/xzyp9/mo938SkaL9Z4TAdjlCyd1HOvg/vd4lIjsU+5h0ax+bqekjMbiS28JZFXDmwCSJktO9oNZOi4fP727el7pwwAz3LTmygj97J7mGKvmGmF5CumggX/+vs6XKgxtTVRAorMqcWY6oKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TybtrqSL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TybtrqSL" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50SAaXSQ023867 for ; Tue, 28 Jan 2025 10:45:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OhsgF7rKwe5JIC/AdPCbzMZyNaFWY1m5uKPa21q85mM=; b=TybtrqSLfqTg9WlU WcFZgquIjsrOe4SZBTlQHaAD4RYXGzlnkO4/Jc/GJjzEOG8eCMyFos/tx9dmmfis dbIt3NwlJ5ez3ChTaN1xcX4bAH4oGDvlu/wKbQ06IYE7rDqlCJbO/M13EcpS3Jvj hznIo5RYCPSHBfdPwUzY/bByH1zvoeJ5ISLsWAa2VFoi46AAVTAH/GqizhTzSe2U c9x3kEBnbBUm8TyynpJtimUb0UGqoTuC3wAocJRnUtj/6rZ24xMU0NzFeUlONc7P 5kJhMGKBZQ4mV6DMWro/GxT8dZsAuO3a3QpzczSnSNQ9EN4QziQ1tdJsx03mxMTr zf800Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44esmw8msp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 28 Jan 2025 10:45:56 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b71321b993so79746985a.2 for ; Tue, 28 Jan 2025 02:45:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738061155; x=1738665955; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OhsgF7rKwe5JIC/AdPCbzMZyNaFWY1m5uKPa21q85mM=; b=CXwTNzjr1qAlYfcSdKw0h/bb9mprtp5nqv+2MJeSqVAqnNWriQxaSdVCaI++6zne9y sqdZYyyIK3+5v/WMPfnUifN+oAd/CiwcGzI3NtA8MIUapb9dYo8y+1RoyWwVFqZ4nuXg sNZXKnexdWKWmuFSKtf6JZw8wj6LVKB6lLdeOgQ5Vhk9ccox+t6EXumJCkGHIGwoV+Fz cPiJ2v9Ln0RpcvubN9LJBou41ohwS9LytFwU69PVyhJ7cElmnRG3u49koFNrv5qSGvso TLHdHFqn1PNOE8wYox3DiLfqL1ticbXMsRtQjij62cwCxgl8s91kqSllXd91fE14XVLK Sd8w== X-Gm-Message-State: AOJu0YxOH7t52XHAej3fJtp1PfD/QKqAgSyAPJbIOctsz0w2wPRFrl5F Op1+IRFgL7NhhGkkBZ0GwnhWb3ISTgzZyu0ILVevpLv+ggJUy74c7FNAOyzyP57uz8U4ESVjci9 UtL/htvvuQznnHnsxx5NnOgpZPdcv2eoasel10rTxo1iOvgt7Ts/eCDs74Jvs54NCnKw44d27 X-Gm-Gg: ASbGncvZiKdgfLNI3yMlM2VuBq8fLsKPB6aFRqvOwslsHtGPWpLIrhMtBdh/+ZRXRjD fpkc8eBWJGB16hbFIw8tTo3SdDuuy9tD9qIpu8ts+cgLaQR/U227qHeznENouqTxp8m2SRwdA8H fmWZ2YG3yMC1kSRbm8BOBXiTVNSEMgzpa/rX6M/Wj3uNVnIs2KzCEzlQYyDlvYiGz+ovd86MlWM PS2rxzRKryVnzWQ1MPapPYxd8PMwiUmM0OmKyGGDnNuEOE0IB6TVTNpqlAWo/qEeYnndaY7sA6S LSSQILe2k2tNznKrXruKvdhSqbBz4m5gxCEBViy8c/Tfq5cFdWjKoSOYEOc= X-Received: by 2002:a05:620a:254f:b0:7b6:d089:2749 with SMTP id af79cd13be357-7be63208909mr2263812685a.7.1738061155473; Tue, 28 Jan 2025 02:45:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+FDki7Hsh32PGe0Kwr8rrgkS9gmvZ9XJ3Lcqs2QPF8jw+4HDYwrPfciPwydWMrJyTCkQ6bA== X-Received: by 2002:a05:620a:254f:b0:7b6:d089:2749 with SMTP id af79cd13be357-7be63208909mr2263810985a.7.1738061155103; Tue, 28 Jan 2025 02:45:55 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760ab363sm760272266b.114.2025.01.28.02.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 02:45:53 -0800 (PST) Message-ID: <5b0f9cd4-df65-4963-8d6d-5bdf759ba0c5@oss.qualcomm.com> Date: Tue, 28 Jan 2025 11:45:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/13] remoteproc: qcom_q6v5_mss: Handle platforms with one power domain To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Konrad Dybcio , =?UTF-8?Q?Matti_Lehtim=C3=A4ki?= Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250127-msm8226-modem-v3-0-67e968787eef@lucaweiss.eu> <20250127-msm8226-modem-v3-4-67e968787eef@lucaweiss.eu> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250127-msm8226-modem-v3-4-67e968787eef@lucaweiss.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: XPqkPzTix6bUlAmRJ08H0Mk9-ONP2W0x X-Proofpoint-GUID: XPqkPzTix6bUlAmRJ08H0Mk9-ONP2W0x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-28_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=914 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501280083 On 27.01.2025 11:45 PM, Luca Weiss wrote: > For example MSM8974 has mx voltage rail exposed as regulator and only cx > voltage rail is exposed as power domain. This power domain (cx) is > attached internally in power domain and cannot be attached in this driver. > > Fixes: 8750cf392394 ("remoteproc: qcom_q6v5_mss: Allow replacing regulators with power domains") > Co-developed-by: Matti Lehtimäki > Signed-off-by: Matti Lehtimäki > Signed-off-by: Luca Weiss > --- > drivers/remoteproc/qcom_q6v5_mss.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > index e78bd986dc3f256effce4470222c0a5faeea86ec..0e1b0934ceedd13d5790b798afc95d68a8314c75 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > @@ -1831,6 +1831,13 @@ static int q6v5_pds_attach(struct device *dev, struct device **devs, > while (pd_names[num_pds]) > num_pds++; > > + /* Handle single power domain */ > + if (num_pds == 1 && dev->pm_domain) { > + devs[0] = dev; > + pm_runtime_enable(dev); This call can fail Konrad