From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fKbkDTKe" Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3595610CE for ; Fri, 17 Nov 2023 16:21:59 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9becde9ea7bso729028966b.0 for ; Fri, 17 Nov 2023 16:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700266917; x=1700871717; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RA8ky1PcdBHxs0AtI5Bw11j01B38AUPYJDp6Hyg1kFE=; b=fKbkDTKeyQayR0SZQtvkcciMQApzhjoeV3/cwgH2Hddqqz5y9xste1TmsBCp/9gr9M SHT1fX1hGilmNb6yWIvJMExN/zfOzTffwBlCr9bcsyjf3wf/9UYMLvxibV1Y4/524Rdo pPG/YzeMyscoC6eLf2L9tAPx9dnQTWipnS+uUGFhZypoyWPdxTRY9TlcUDlxf3M/dGTC GeRB5A7oW7S5CI7aFrsJ6T3526uhtccegco9NIBLkxrfAkha7NYiDDBReJhj3JDKd80S fzqHww1yejGuuENPc8XLd7ORlfzhEBgtQqX9I9ShIygwroetBr+ayvVigZv+RoW8HDoB TX4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700266917; x=1700871717; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RA8ky1PcdBHxs0AtI5Bw11j01B38AUPYJDp6Hyg1kFE=; b=q/doKX7TIk61bm5kIbu7iFv+e0QrO3284f+bUum4gv90eMO5ewmje+EYCV3G6h8Bp0 nsDt/1yTNOclgB8rgrmUozZNGASX1uCL5RBsLriHNqQbJ858JQu7HRd6KqBO+QEkmdqG adXsI+gt0fXOMBiAPa93wIkCdJu5FYDUcYjw0bqMOaDxH6Xv1jvCzY3PUiCpcF4nAFWB Ox2RydrNJf9g8Tc5p6UIX5Ib2IIPlO8GBSPN9jX+lSQczPrISZFDlcpAxfMepcQ9dzQN hoeWkaVCmyboU8a1GFPQQPCD0LjgPORaQxarfkjqBRXAWU+vaR6S1GvkWxU5UXWinJ1V oZVg== X-Gm-Message-State: AOJu0Yz7lBadzZk+/yNTxiaWOZaiKrmGoeYRWErcPqMBb21n9XoS4AOJ s37m7hAyCd3LivBsSMsSKyn2Ow== X-Google-Smtp-Source: AGHT+IExMQuDC0BLuseOoXaeQotQo76MyLnj82ezCiCWlRcorNLcWupNZoCQNZYtDbwP9xEnfevpqw== X-Received: by 2002:a17:906:b384:b0:9ae:5a56:be32 with SMTP id uh4-20020a170906b38400b009ae5a56be32mr6022764ejc.38.1700266917697; Fri, 17 Nov 2023 16:21:57 -0800 (PST) Received: from [192.168.201.100] (178235187040.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.40]) by smtp.gmail.com with ESMTPSA id g25-20020a1709064e5900b009e7e7c0d1a9sm1308513ejw.185.2023.11.17.16.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 16:21:57 -0800 (PST) Message-ID: <5b1d2eff-d328-4bb2-b255-b5913e1700f5@linaro.org> Date: Sat, 18 Nov 2023 01:21:55 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] arm64: dts: qcom: add initial SM8650 dtsi Content-Language: en-US To: Neil Armstrong , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231106-topic-sm8650-upstream-dt-v2-0-44d6f9710fa7@linaro.org> <20231106-topic-sm8650-upstream-dt-v2-2-44d6f9710fa7@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231106-topic-sm8650-upstream-dt-v2-2-44d6f9710fa7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6.11.2023 09:39, Neil Armstrong wrote: > Add initial DTSI for the Qualcomm SM8650 platform, > only contains nodes which doesn't depend on interconnect. > > Signed-off-by: Neil Armstrong > --- Just a couple nits [...] > + cpu2-bottom-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&tsens0 6>; > + > + trips { > + trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu-critical { indentation > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; [...] > + > + nsphmx-0-thermal { > + polling-delay-passive = <10>; > + polling-delay = <0>; > + thermal-sensors = <&tsens2 8>; > + > + trips { > + thermal-engine-config { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "passive"; > + }; > + > + thermal-hal-config { > + temperature = <125000>; > + hysteresis = <1000>; > + type = "passive"; > + }; The two above nodes (which are repeated under many tzones) sound made up just to be consumed by a bunch of android binaries Or at least the second one, maybe "thermal engine" is some hw/fw part? > + > + reset-mon-config { "reset mon" is not a very enticing name either.. > + temperature = <115000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + > + junction-config { ...which leads me to believe only this one is meaningful same goes for all tzones that have a similar mess :/ > + temperature = <95000>; > + hysteresis = <5000>; > + type = "passive"; > + }; Konrad