[PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[Luca Weiss]

Some SC7280-based boards crash when providing the "secure_non_pixel"
context bank, so allow only one iommu in the bindings also.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Reference:
https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
---
 Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
index 8f9b6433aeb8..10c334e6b3dc 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
@@ -43,6 +43,7 @@ properties:
       - const: vcodec_bus
 
   iommus:
+    minItems: 1
     maxItems: 2
 
   interconnects:

---
base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
change-id: 20240129-sc7280-venus-bindings-6e62a99620de

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote:
> Some SC7280-based boards crash when providing the "secure_non_pixel"
> context bank, so allow only one iommu in the bindings also.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Do we have any idea why this happens? How is someone supposed to know
whether or not their system requires you to only provide one iommu?
Yes, a crash might be the obvious answer, but is there a way of knowing
without the crashes?

Cheers,
Conor.

> ---
> Reference:
> https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
> ---
>  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> index 8f9b6433aeb8..10c334e6b3dc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> @@ -43,6 +43,7 @@ properties:
>        - const: vcodec_bus
>  
>    iommus:
> +    minItems: 1
>      maxItems: 2
>  
>    interconnects:
> 
> ---
> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
> change-id: 20240129-sc7280-venus-bindings-6e62a99620de
> 
> Best regards,
> -- 
> Luca Weiss <luca.weiss@fairphone.com>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[Luca Weiss]

On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote:
> On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote:
> > Some SC7280-based boards crash when providing the "secure_non_pixel"
> > context bank, so allow only one iommu in the bindings also.
> > 
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Do we have any idea why this happens? How is someone supposed to know
> whether or not their system requires you to only provide one iommu?
> Yes, a crash might be the obvious answer, but is there a way of knowing
> without the crashes?

+CC Vikash Garodia

Unfortunately I don't really have much more information than this
message here:
https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/

And see also the following replies for a bit more context, like this
one:
https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/

Maybe Vikash can add some more info regarding this.

Regards
Luca

>
> Cheers,
> Conor.
>
> > ---
> > Reference:
> > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
> > ---
> >  Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > index 8f9b6433aeb8..10c334e6b3dc 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > @@ -43,6 +43,7 @@ properties:
> >        - const: vcodec_bus
> >  
> >    iommus:
> > +    minItems: 1
> >      maxItems: 2
> >  
> >    interconnects:
> > 
> > ---
> > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
> > change-id: 20240129-sc7280-venus-bindings-6e62a99620de
> > 
> > Best regards,
> > -- 
> > Luca Weiss <luca.weiss@fairphone.com>
> > 

Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[Vikash Garodia]

Hello,

On 1/30/2024 1:17 PM, Luca Weiss wrote:
> On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote:
>> On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote:
>>> Some SC7280-based boards crash when providing the "secure_non_pixel"
>>> context bank, so allow only one iommu in the bindings also.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>
>> Do we have any idea why this happens? How is someone supposed to know
>> whether or not their system requires you to only provide one iommu?
>> Yes, a crash might be the obvious answer, but is there a way of knowing
>> without the crashes?
> 
> +CC Vikash Garodia
> 
> Unfortunately I don't really have much more information than this
> message here:
> https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/
> 
> And see also the following replies for a bit more context, like this
> one:
> https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/
> 
> Maybe Vikash can add some more info regarding this.

0x2184 is a secure SID i.e any transactions with that ID would be access
controlled by trustzone (TZ). SC7280 (chromebook) was designed without TZ, while
some other DT deriving from SC7280 (like qcm6490) might have TZ. Hence it is
good to move the iommu entry from SC7280 to chrome-common.

Regards,
Vikash

Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

[Krzysztof Kozlowski]

On 29/01/2024 08:48, Luca Weiss wrote:
> Some SC7280-based boards crash when providing the "secure_non_pixel"
> context bank, so allow only one iommu in the bindings also.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof