Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: quic_vnagar@quicinc.com, quic_dikshita@quicinc.com,
	konradybcio@kernel.org, linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [PATCH v5 3/3] media: dt-bindings: qcom-venus: Deprecate video-decoder and video-encoder where applicable
Date: Thu, 19 Dec 2024 09:16:38 +0100	[thread overview]
Message-ID: <5d0b06b7-1fed-43cc-93e2-9a5f7cd14ffb@linaro.org> (raw)
In-Reply-To: <61c27010-c49f-48df-b6d3-029b15c71bd3@quicinc.com>

On 19/12/2024 03:45, Renjiang Han wrote:
> 
> On 12/18/2024 8:38 PM, Krzysztof Kozlowski wrote:
>>>> @@ -132,12 +132,4 @@ examples:
>>>>            resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>,
>>>>                     <&videocc VIDEO_CC_MVS0C_CLK_ARES>;
>>>>            reset-names = "bus", "core";
>>>> -
>>>> -        video-decoder {
>>>> -            compatible = "venus-decoder";
>>>> -        };
>>>> -
>>>> -        video-encoder {
>>>> -            compatible = "venus-encoder";
>>>> -        };
>>>>        };
>>> It is working fine on QCS615.
>>> Tested-by: Renjiang Han<quic_renjiang@quicinc.com>
>> How? How is it possible to test a binding on real hardware? To my
>> knowledge it is impossible, so I really would like to see explanation of
>> this tag.
>   I used this binding and modified the driver to verify the video
>   function, and the result was fine. Also, I used this binding to
>   verify the dtb, and there was no related error, so I added
>   Tested-by.

This is not a testing of binding. You tested driver. Don't add fake tags.

Best regards,
Krzysztof

  reply	other threads:[~2024-12-19  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 11:52 [PATCH v5 0/3] media: venus: Provide support for selecting encoder/decoder from in-driver Bryan O'Donoghue
2024-12-09 11:52 ` [PATCH v5 1/3] media: venus: Add support for static video encoder/decoder declarations Bryan O'Donoghue
2024-12-18 10:44   ` Renjiang Han
2024-12-28 13:33   ` Stanimir Varbanov
2024-12-30 11:32     ` Bryan O'Donoghue
2024-12-09 11:52 ` [PATCH v5 2/3] media: venus: Populate video encoder/decoder nodename entries Bryan O'Donoghue
2024-12-13 20:00   ` Nicolas Dufresne
2024-12-13 22:46     ` Bryan O'Donoghue
2024-12-18 10:45   ` Renjiang Han
2024-12-09 11:52 ` [PATCH v5 3/3] media: dt-bindings: qcom-venus: Deprecate video-decoder and video-encoder where applicable Bryan O'Donoghue
2024-12-18 10:46   ` Renjiang Han
2024-12-18 12:38     ` Krzysztof Kozlowski
2024-12-19  2:45       ` Renjiang Han
2024-12-19  8:16         ` Krzysztof Kozlowski [this message]
2024-12-19  7:37 ` [PATCH v5 0/3] media: venus: Provide support for selecting encoder/decoder from in-driver Vikash Garodia
2024-12-19 12:07   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d0b06b7-1fed-43cc-93e2-9a5f7cd14ffb@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_renjiang@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=quic_vnagar@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox