From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: <agross@kernel.org>, <bjorn.andersson@linaro.org>,
<robh+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_rohkumar@quicinc.com>, <srinivas.kandagatla@linaro.org>,
<dianders@chromium.org>, <swboyd@chromium.org>,
<judyhsiao@chromium.org>,
Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [PATCH v11 2/4] arm64: dts: qcom: sc7280: Add MI2S pinmux specifications for CRD 3.0/3.1
Date: Wed, 27 Apr 2022 22:33:41 +0530 [thread overview]
Message-ID: <5d0ebb2d-c672-8037-b1dd-bb8a61d4d027@quicinc.com> (raw)
In-Reply-To: <YmhrDvBGhqtdQVQ1@google.com>
On 4/27/2022 3:28 AM, Matthias Kaehlcke wrote:
Thanks for your time Matthias!!!
> On Tue, Apr 26, 2022 at 12:51:04PM +0530, Srinivasa Rao Mandadapu wrote:
>
>> Subject: arm64: dts: qcom: sc7280: Add MI2S pinmux specifications for CRD 3.0/3.1
>>
>> Add drive strength property for primary and secondary MI2S on
>> sc7280 based platforms of rev5+ (aka CRD 3.0/3.1) boards.
> The subject and the commit message are misleading. What this
> change does is to configure these setting for all herobrine
> based boards, not only the CRD rev5+.
>
> That doesn't seem correct. The setting may be similar across
> boards, but they aren't necessarily the same, especially for
> the drive strength. One could argue that mi2s0 and the wcd9385
> are on the qcard and hence the config should be in
> sc7280-qcard.dtsi, however not all qcard based boards use the
> wcd9385, so the config shouldn't be shared across all of them.
> Please move it to sc7280-herobrine-crd.dts
Okay. Will do accordingly.
next prev parent reply other threads:[~2022-04-27 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 7:21 [PATCH v11 0/4] Add lpass pin control support for audio on sc7280 based targets Srinivasa Rao Mandadapu
2022-04-26 7:21 ` [PATCH v11 1/4] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu
2022-04-26 7:21 ` [PATCH v11 2/4] arm64: dts: qcom: sc7280: Add MI2S pinmux specifications for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-04-26 21:58 ` Matthias Kaehlcke
2022-04-27 17:03 ` Srinivasa Rao Mandadapu [this message]
2022-04-26 7:21 ` [PATCH v11 3/4] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu
2022-04-26 21:42 ` Matthias Kaehlcke
2022-04-26 7:21 ` [PATCH v11 4/4] arm64: dts: qcom: sc7280-herobrine: Add lpi pinmux properties for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-04-26 22:03 ` Matthias Kaehlcke
2022-04-27 17:04 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0ebb2d-c672-8037-b1dd-bb8a61d4d027@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_potturu@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox