From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Doug Anderson <dianders@chromium.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
<linux-phy@lists.infradead.org>,
Matthias Kaehlcke <mka@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sandeep Maheswaram <quic_c_sanm@quicinc.com>,
<quic_ppratap@quicinc.com>, <linux-usb@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_vpulyala@quicinc.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<quic_pkondeti@quicinc.com>,
Wesley Cheng <quic_wcheng@quicinc.com>
Subject: Re: [PATCH v8 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings
Date: Wed, 1 Jun 2022 23:06:49 +0530 [thread overview]
Message-ID: <5d3797bd-915f-2746-b593-1b8a3f792c5d@quicinc.com> (raw)
In-Reply-To: <20220601173326.GA3993065-robh@kernel.org>
Thanks Rob !
On 6/1/2022 11:03 PM, Rob Herring wrote:
> On Wed, Jun 01, 2022 at 07:28:53AM -0500, Rob Herring wrote:
>> On Wed, 01 Jun 2022 12:26:02 +0530, Krishna Kurapati wrote:
>>> From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>>>
>>> Add device tree bindings for SNPS phy tuning parameters.
>>>
>>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 96 ++++++++++++++++++++++
>>> 1 file changed, 96 insertions(+)
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,hs-rise-fall-time-bp
>> Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dtb:0:0: /example-0/phy@88e2000: failed to match any schema with compatible: ['qcom,sm8150-usb-hs-phy']
> Ignore these. A tool issue which is now fixed.
>
> Rob
next prev parent reply other threads:[~2022-06-01 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 6:56 [PATCH v8 0/3] Add QCOM SNPS PHY overriding params support Krishna Kurapati
2022-06-01 6:56 ` [PATCH v8 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Krishna Kurapati
2022-06-01 12:28 ` Rob Herring
2022-06-01 17:33 ` Rob Herring
2022-06-01 17:36 ` Krishna Kurapati PSSNV [this message]
2022-06-08 9:30 ` Krishna Kurapati PSSNV
2022-06-08 9:38 ` Krzysztof Kozlowski
2022-06-08 9:36 ` Krzysztof Kozlowski
2022-06-08 11:03 ` Krishna Kurapati PSSNV
2022-06-08 12:07 ` Krishna Kurapati PSSNV
2022-06-08 15:53 ` Vinod Koul
2022-06-08 16:14 ` Krishna Kurapati PSSNV
2022-06-01 6:56 ` [PATCH v8 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters Krishna Kurapati
2022-06-08 9:46 ` Krzysztof Kozlowski
2022-06-08 16:04 ` Vinod Koul
[not found] ` <295d0748-d817-2afa-19d2-5e802ad7fec0@quicinc.com>
2022-06-17 0:29 ` Vinod Koul
2022-06-01 6:56 ` [PATCH v8 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device Krishna Kurapati
2022-06-08 9:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3797bd-915f-2746-b593-1b8a3f792c5d@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox