From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D04331B823 for ; Mon, 6 Apr 2026 09:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467246; cv=none; b=cOoSzkH/PqL+RejaQrlDvj5QkWz526Kski3k+jk4HEHsNToC1/kicDTZO1XkaAdD8DUwq6DUatr7TGSP4jqPn8ZDr+IdBK/yf4jv7njbDhO+k/wrcMj29ogbou4VxQPXN4p4FtNlUCJk4GCRjY4gBwPbBxGGQAFAK7mOJhaaHZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775467246; c=relaxed/simple; bh=DCHRPKSmvuFc4FHBCvz3E0fZTDZUHBdIvM7B0LvU9Xc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fx+P+y7KDRlHGM0M4czAuUWASv3CB3Xo/vNwJ8/ra8vrGyXC7dZX2gczNaJpfoIQzWM1DQ23HV7CAlbcxpsSbpf524EtL0VldmQIfbYZFrnsJWyk7hPVo3k7OLdCg6dsCku20Nb6MYsw1JIKwiaqtKY3tW+vrl6yVPZXeH5bvts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TkG//0wV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f39qrQUA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TkG//0wV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f39qrQUA" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6363WnSH2973403 for ; Mon, 6 Apr 2026 09:20:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oi9ZzHP39tOQKwyOOyXPrvxRWV8ztbCB4HAl7sf3U+4=; b=TkG//0wVfKAvuxSP 9ZjVZ16elwDk7XBW8uUIcQeyuPPUleVHNVYC9eXT/FsFopwNq6RhniaUGinE8dEm hFLmdoTc+I/S6esSJbpJ9YKhNAwl1JBWGmpMP3qGHwuxv35PfG8O70mZ9GNVXVkI xbGgseONmMNzTwuJEzRB1+9ifzpKQkUzGgxuTKp4EMb3k1t8OTLm0DJbDBr36C++ DR5HTl7EKtLtwDy/ASEZhjuZgzGlMdxvyFR4kco8N8KV88OBNcTYhuJeD0tsMfJF +77wml87pBDaKeFl4u0xEFHGya3upWL/0dhfMVa5GiZoa1YWUCyUYV7zf5dznAkh 4fuFKA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dauthcj2g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Apr 2026 09:20:44 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b2523e0299so98169795ad.3 for ; Mon, 06 Apr 2026 02:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775467244; x=1776072044; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oi9ZzHP39tOQKwyOOyXPrvxRWV8ztbCB4HAl7sf3U+4=; b=f39qrQUArySmPNY0EDXsWDIplRezLrecoVHevgiOzvGG5WdojjNUXEncRzQgGue8VM HOW7GL+MdZrth26zgkOyCWzjcxZLDvCHN3NA+6swrgr29AscPX93ZxmOHCeUjTAxCxbW ipDLzejT1yHU5JvgeSs/Yf/ZFjiKVAAQKOKoF6NvWOizLMINonGKhLIE8n7J9hCpJJIb 0Xem54WtIB70rTNsy3AQX7tt+U7p0mjYPpsOAy5mOMmXvkk0GjRsiE+OCAA/1K8mtO8E bOcR82WmRBUlYIKoi7yfTX8A3HXM5IwiTSBIUfGKUhixc+wwxTPfTOct4pqLzZqJ20XG te9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775467244; x=1776072044; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oi9ZzHP39tOQKwyOOyXPrvxRWV8ztbCB4HAl7sf3U+4=; b=Gm7jCXrqCLLyLhtxl3HMTAtRGmT4eyKPASUA5kbRnnxJ9HRIKQr2mPHhoqeIIC+Vs2 J/Vw3lL5wAUFmQUSlV6I4hiRt7yuiq2jGdebbB0Lf/EIwXCK5wCA1tZ3iOZkV3x5v8av Ga6eJ+J6Lf4FQMUAe/TyB5DEXsXuVREWGTe5gz3wcEbcsED4KgV40fTUMv4JsLM58RWl CUbfwlSx/H+snSakBMiOGcfZWAiYX671DUpPHsnpQXsd/s0ShdiC49xUdoJKJ7wi7HaR NToKsJN3oCTmvwnpVUiw25KO6Hwg874v0HBKDlyEn7/oaOWEwmrNCZmQVrcC5KVcGzfr txpQ== X-Forwarded-Encrypted: i=1; AJvYcCXQICzu4wpHMkh7Ts0RwiFG7MWRozGa2Ul3l8JvEWVjKsrxpssI64I/NtHBczsjc0YnWL95rkb60yhGWZnk@vger.kernel.org X-Gm-Message-State: AOJu0Yy/R1r2PoqPZJlaD2nnI4dKCGXTei3d+o4vFpq0ewm1KLT0W6W0 TPSqkHUOTre7xQQ3fCIU7jbQg7Fz24lZPqSyg+ShMCHj51cIox8tEsIwA65cQ+Un6aMMSNY3HHR EBRJJF8FB9DqPD1pOeGBPS265bru42cMRMSbkhUoQMDjPJPPvzyryXQdUbvpemealLw8/ X-Gm-Gg: AeBDietygWsCUjy/P1DxGWdqxu9ZISLqP7/TLtsNJF9ffZ1OQ5sJlq/lIYaSNIOKcQV VAjTgqOiBQSh3U8CxqWgLJYmVX+kJ9I0mToYOBv/eDVhOMPZnPTKlQ+MjCqia4RrZ7DjgQVfRNu Wbo6vjFiDyRbzlEWLcKRpw0NheLXaqwQgYsVU5OyVNREAdG8NtWjbwZi9guTNq68KhE6fPrzOFq 59OIgGodgYsCeQ+hNHK5tG8XKwmA7JyZtPsBUUT3XR5WEPGcFM0+m5LogJunwbVvDCWPPFyqZlJ V9Ul0QN5aJ8rAf7fYzOd1/pSYWaNWsbjOQxe/tRgWTOymJ9uxvOGJPP4RrUol277V68YAo7DqGm ct7bP4CNFWoebN8dyUUMElKsfUaIvo6wPQHwol5sv1+8rIiF76KY= X-Received: by 2002:a17:903:2a86:b0:2ae:ce35:2686 with SMTP id d9443c01a7336-2b281706f07mr140727985ad.5.1775467243717; Mon, 06 Apr 2026 02:20:43 -0700 (PDT) X-Received: by 2002:a17:903:2a86:b0:2ae:ce35:2686 with SMTP id d9443c01a7336-2b281706f07mr140727445ad.5.1775467243190; Mon, 06 Apr 2026 02:20:43 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749a3af9sm126837105ad.63.2026.04.06.02.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 02:20:42 -0700 (PDT) Message-ID: <5d4e0b57-e5f6-4c2f-918b-7a23e50ea6ad@oss.qualcomm.com> Date: Mon, 6 Apr 2026 14:50:32 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk To: Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-1-e36044bbdfe9@oss.qualcomm.com> <30327e35-6d32-4aac-a55d-134ed5271603@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <30327e35-6d32-4aac-a55d-134ed5271603@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA2MDA5MSBTYWx0ZWRfX5+vxcTeWVxpa 3UTB9XeJ3apQWr+pL4n8VTfjc3PYeWDc1qkyqQKiGmXtnlGY66XMZlt+AVfPBylrOZT+O9IW2dG 1Z9iRjRa1Xhvp0pFNvoEPeiD5jxCEl4t3gXXzU+KWwqtzT3CjHtwjBOJENuSuBf3jDiwPDT7QTP OKxZtc0bFdZ8uPlyd7vh5YDK+nLawjQ0dtUiVnHwApNhVXNnv2wuXIEdjhMDYDelH0uQwjFz9Qk aKQey0cZjSGGgdqjoSq4Lg+XbMAtJU3Okf6gcnjxl1iaTE+e3WxWfKI4s3xwCjncDGihpwB9tFD EQf9sH8pmC9jNUJ3U/1pFhBdZEeU+7c8/ZpgiiJFdjL34+cbbaNi77h2TLyjGK4kKf2cEGgiC09 ZyO01+ihNaxWZMqD5NZo07va5/5x1P5hTJ4HxcXmPKOF/3cjXl9XfUbOvX6SWboSzjKNjVxj/uy oUnLLC8hzg8CJDlwTjQ== X-Proofpoint-GUID: L3rhRlWV_Jn3k6hO0QHK1x7VIMCQHiAj X-Authority-Analysis: v=2.4 cv=MIptWcZl c=1 sm=1 tr=0 ts=69d37aec cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=CMx50Ybjb1gtcuyIV48A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: L3rhRlWV_Jn3k6hO0QHK1x7VIMCQHiAj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-06_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604060091 On 4/6/2026 2:07 PM, Krzysztof Kozlowski wrote: > On 23/03/2026 10:17, Harshal Dev wrote: >> The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC >> power-domain and iface clock. Without enabling the iface clock and the >> associated power-domain the ICE hardware cannot function correctly and >> leads to unclocked hardware accesses being observed during probe. >> >> Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC >> power-domain and iface clock for new devices (Eliza and Milos) introduced >> in the current release (7.0) with yet-to-stabilize ABI, while preserving >> backward compatibility for older devices. >> >> Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE") >> Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE") >> Signed-off-by: Harshal Dev >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++- >> 1 file changed, 34 insertions(+), 1 deletion(-) > > Reviewed-by: Krzysztof Kozlowski > Thank you for the review Krzysztof. I believe since we are targeting current RC fix, I need to send a patch for adding the clock and power-domain for Milos and Eliza DT as well to conform to the binding since both changes defining the ICE node for them are already picked up by Bjorn: https://lore.kernel.org/all/177432155637.28714.2511351512032518031.b4-ty@kernel.org/ https://lore.kernel.org/all/whoikp5tdu34gujfjqpopbhywzj6dvcxebywtwufip6jxdwp2s@oepb2y36a2hw/ Is it fine if I spin a v5 of this patch adding the DT changes for Eliza and Milos? I don't think sending a separate patch series for updating these two DT makes sense given the RC will close shortly. I'll send a v5 today itself, hopefully Abel and Luca can review. Regards, Harshal > Best regards, > Krzysztof