From: Stephen Boyd <swboyd@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
edubezval@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, masneyb@onstation.org
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature
Date: Fri, 20 Sep 2019 15:03:46 -0700 [thread overview]
Message-ID: <5d854cc3.1c69fb81.4264c.bab8@mx.google.com> (raw)
In-Reply-To: <aa318f9ba4aa3fd13b05201743acc1ab2c1a0db1.1569015835.git.amit.kucheria@linaro.org>
Quoting Amit Kucheria (2019-09-20 14:52:29)
> Hide the details of how to convert values read from TSENS HW to mCelsius
> behind a function. All versions of the IP can be supported as a result.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Just one nit below.
> drivers/thermal/qcom/tsens-common.c | 50 +++++++++++++++++++++--------
> 1 file changed, 36 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index ea2c46cc6a66..6b6b3841c2d0 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -310,6 +331,7 @@ int __init init_common(struct tsens_priv *priv)
> goto err_put_device;
> }
> }
> +
> for (i = 0, j = VALID_0; i < priv->feat->max_sensors; i++, j++) {
> priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map,
> priv->fields[j]);
Drop this hunk?
next prev parent reply other threads:[~2019-09-20 22:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 21:52 [PATCH v4 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema Amit Kucheria
2019-09-27 16:29 ` Rob Herring
2019-09-20 21:52 ` [PATCH v4 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-09-20 22:02 ` Stephen Boyd
2019-09-20 22:07 ` Amit Kucheria
2019-09-20 22:09 ` Stephen Boyd
2019-09-20 22:14 ` Amit Kucheria
2019-09-20 23:19 ` Stephen Boyd
2019-09-20 22:09 ` Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 12/15] arm: dts: msm8974: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 13/15] arm64: dts: msm8916: " Amit Kucheria
2019-09-20 21:52 ` [PATCH v4 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-09-20 22:03 ` Stephen Boyd [this message]
2019-09-20 21:52 ` [PATCH v4 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
2019-09-20 22:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d854cc3.1c69fb81.4264c.bab8@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).