Re: [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX

Stephen Boyd
2019-10-10T14:25:21Z

Quoting Akash Asthana (2019-10-10 02:46:43)
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 5180cd8..ff63728 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1306,6 +1317,29 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
> return ret;
> }
>
> + if (!console) {
> + port->wakeup_irq = platform_get_irq(pdev, 1);

Should use platform_get_irq_optional() it seems.

> + if (port->wakeup_irq < 0) {
> + dev_err(&pdev->dev, "Failed to get wakeup IRQ %d\n",
> + port->wakeup_irq);
> + } else {
> + irq_set_status_flags(port->wakeup_irq, IRQ_NOAUTOEN);
> + ret = devm_request_irq(uport->dev, port->wakeup_irq,
> + qcom_geni_serial_wakeup_isr,
> + IRQF_TRIGGER_FALLING, "uart_wakeup", uport);
> + if (ret) {
> + dev_err(uport->dev, "Failed to register wakeup IRQ ret %d\n",
> + ret);
> + return ret;
> + }
> +
> + device_init_wakeup(&pdev->dev, true);
> + ret = dev_pm_set_wake_irq(&pdev->dev, port->wakeup_irq);

Why can't we use dev_pm_set_dedicated_wake_irq() here?

> + if (unlikely(ret))
> + dev_err(uport->dev, "%s:Failed to set IRQ wake:%d\n",
> + __func__, ret);
> + }
> + }
> uport->private_data = drv;
> platform_set_drvdata(pdev, port);
> port->handle_rx = console ? handle_rx_console : handle_rx_uart;
> @@ -1328,7 +1362,12 @@ static int __maybe_unused qcom_geni_serial_sys_suspend(struct device *dev)
> struct qcom_geni_serial_port *port = dev_get_drvdata(dev);
> struct uart_port *uport = &port->uport;
>
> - return uart_suspend_port(uport->private_data, uport);
> + uart_suspend_port(uport->private_data, uport);
> +
> + if (port->wakeup_irq > 0)
> + enable_irq(port->wakeup_irq);
> +

Then this is hopefully done automatically?

> + return 0;
> }
>
> static int __maybe_unused qcom_geni_serial_sys_resume(struct device *dev)