From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH V2 1/2] tty: serial: qcom_geni_serial: IRQ cleanup
Date: Tue, 15 Oct 2019 13:11:03 -0700 [thread overview]
Message-ID: <5da627d8.1c69fb81.82267.2a50@mx.google.com> (raw)
In-Reply-To: <010dd569-d172-fdcf-0bfa-8caaf41a4d46@codeaurora.org>
Quoting Akash Asthana (2019-10-11 00:39:06)
>
> On 10/10/2019 7:49 PM, Stephen Boyd wrote:
> > Quoting Akash Asthana (2019-10-10 02:46:03)
> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> >> index 14c6306..5180cd8 100644
> >> --- a/drivers/tty/serial/qcom_geni_serial.c
> >> +++ b/drivers/tty/serial/qcom_geni_serial.c
> >> @@ -1297,11 +1291,21 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
> >> port->rx_fifo_depth = DEF_FIFO_DEPTH_WORDS;
> >> port->tx_fifo_width = DEF_FIFO_WIDTH_BITS;
> >>
> >> + scnprintf(port->name, sizeof(port->name), "qcom_geni_serial_%s%d",
> >> + (uart_console(uport) ? "console" : "uart"), uport->line);
> > Drop useless parenthesis. Also, it might make more sense to make this a
> > devm_kasprintf() call now.
>
> OK
>
> >> irq = platform_get_irq(pdev, 0);
> >> if (irq < 0)
> >> return irq;
> >> uport->irq = irq;
> >>
> >> + irq_set_status_flags(uport->irq, IRQ_NOAUTOEN);
> > Is there a reason why we can't always leave the irq enabled and request
> > it later once the uart structure has been fully initialized?
>
> According to current design we are requesting IRQ handler in probe, and
> we enable and disable it from the startup(port open) and shutdown(port
> close) function respectively.
>
> We need to call for disable_irq in shutdown function because client has
> closed the port and we don't expect any transfer requests after it.
>
> >>request it later once the uart structure has been fully initialized?
>
> Is the ask is to move request irq later in probe after the uport is
> fully initialized?
Yes I'm wondering if we can get rid of the IRQ_NOAUTOEN and
irq_enable/disable bits in here and leave the interrupt enabled all the
time.
next prev parent reply other threads:[~2019-10-15 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 9:46 [PATCH V2 1/2] tty: serial: qcom_geni_serial: IRQ cleanup Akash Asthana
2019-10-10 14:19 ` Stephen Boyd
2019-10-11 7:39 ` Akash Asthana
2019-10-15 20:11 ` Stephen Boyd [this message]
2019-10-17 11:10 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5da627d8.1c69fb81.82267.2a50@mx.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox