From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDDD735EDBE for ; Tue, 27 Jan 2026 16:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530342; cv=none; b=SQKFH3FX+EeFBsfekHPIFCdRG5uaP3Q7aOSEpWvqWyXDYcjwD83r4SKB32d8Hooc7JG14cBjAv60Xzi+wBaW5/rtCcX6WItq9m1coC/EdjPFy/9OI0MftbaDSFHvsU1HtOHexFiW0Ej/mxL20woDjFhd5fOeRWLbcJmD89MsxUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530342; c=relaxed/simple; bh=oqoBow5D3lG837WMPctNSJeeKyxHDiuyOmPTM74O8P4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gvk4n5pQ7kgnJLlNjiV7ZQyoxYHBA65TGy+JyxZth5+/KSpisv8414wyXz7bI05MqvQ5O6FS+tWApJ4kHjy5bUnqMEmiiQAKBgnXH3gCsTr1ftWFpfyWHbL/k9T/pzvpmg2P8TbKBmM9Vk62v2tARMmBIXQxTRj9Dk//cl3GWSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GJAIbMUH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SZwki0o2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GJAIbMUH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SZwki0o2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RFwx9G1714606 for ; Tue, 27 Jan 2026 16:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=GJAIbMUHFANji3ap dyADZWwk/CEa7ZGm9UCid41ymVZz4hGg4hfqBNB42fBmRdDjCIh5VNBUIb4ve0qs p3dTlTyDsZuys78RnhGekkxdY+8c6f6hoshS1MnaLtEUIZADDXbhvwluz6+8KCvO NmbA+mCHSWFpL6OThICAew5btI2UHhJxDTHWMre9fSdy6G2enoZGK7Q1/8OzIIV3 HniesAz+JYlBTXi+Cvb5aFkzatkrlbOtNNPR9V9NDJU2tivTdy6XaeIgUYgZcvjo AZFUJXTvGVtX62C9uhnwqvbeFavPe+p9jA+f2gnH5ulAYXOaAwY2mXXPC+KqPhm+ V/1vVw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by0g082m4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 16:12:19 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0bae9acd4so39288695ad.3 for ; Tue, 27 Jan 2026 08:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769530339; x=1770135139; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=SZwki0o2k3S9QmV9aWaRqwEZCBN0fsqK9b+v8sf4ohPKco55D28lAZygQMbcMdvnkX uyjj8AmZH7J9S8Ek2uyl5NYjWJKt8WjhQp2mxvRE5BuuPrF556aZ8S5VLe3RGrabCCHi JRBJl2ZkZ5AT3qE8MsQWYaXKCr/66rVOFca2gI0eLj18si/xEsTm+vY/cBuDVn3jmG6C kXkDWNSazcffxhvpgeAxj91sSDggNcf+e2SoT37XAF3RgLF++gJRayx2B9U3NlnIdIR4 8rJNVvqy+KSLVUvFrmiEDfhTntxdCjuMdeZXahMbQC8QyGMF8DNfc+k1VUjbIFzhEkdu /b4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769530339; x=1770135139; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=BKe8DNZZ2dJTWXBbNtq+roR5rkHQP7TXB1VWm4l8GU+LycrrMcN6toxiaQztkz9+qk QxXFg+s+yCMeLJli9eODzk0f0inZV3sPKtS8Z6IoApyUVliM8Io4K348daAHgMKld+xw rRbwct3UdKJfsnN6nF62jmnhVSaPBjNuE7jqQopK7iAsae4tjfZqq88vY1UoaZWIGSaC JYir+o6gGdB+0ioQEY69YPWic0wlZzOEqw3yl+HJwXtNJAjvmNjWSgntCmZHj7SdfpaA ZD+cEGAmkBZCapynWboXUVS41udXp2zcdenY132IP13/ScI0IhWwEhzYUW4wilCe5W9t W0TA== X-Forwarded-Encrypted: i=1; AJvYcCVh7D4UuhDq89Gr5kqDVxhyAnuVRsiPw1c7ebxcTw1Z80BYbE8Wa6UBKLpRFF4E3IQuayF0drtjQYBIkFgr@vger.kernel.org X-Gm-Message-State: AOJu0Yzm/vkBYqbH5Q94gflv1LmuBSi1XB5oDXVWHusDXvU/COewEUT1 QzR2hOk+ac59V1k0D9AXjyVW4P1bqhtk5pBgs3nENU/T/wNlGMNivd5LgyE/m6CxOvquA4cn7in DAwGb51auLxNselhvSeQgKm3zKiPIDiyIYJ8nhBVWL6Pqd6M8jq0e61dDv3kWv94VR8EQ X-Gm-Gg: AZuq6aIE1K6kSYDFTwx41PTH8ES5TlPk4FxRwkLC8b4PvYeLPvy+8Bj4FDgLsHvnEP8 aXKCKc+9FAIjkhgqaaK5BNDJZiEbfW4/VOhcBvMOXvhiHzpQEKnn2/TRxiP1kWgWLAQLioxDaEt pew73xSLdJh++cllLBzPXbsG0JLtyhkdA9EFaCZ+aflvkjgrib6+ia+u8rqukAVyXNZanWHHwmG Z4JnGpl+K9c47DgxtWvhTq0tjpE+rDd6NOxpy3YG9VTjLc1qr0JJ4nf+6lOpY+vnYOZfef+MVyl VywJIKAZW5n3FFCE+y2WKLJLY2yipRp+Q+2PdgTE9GmJMCRoAqwLlZSWqsw/nkaaGp1vhl4KC8+ 2KjPJcYgckHgI9gYZI/AvYJ/3MdhXdnO1HrK4Prk= X-Received: by 2002:a17:902:dac4:b0:2a0:c5b8:24b0 with SMTP id d9443c01a7336-2a870dd56edmr28281775ad.46.1769530338439; Tue, 27 Jan 2026 08:12:18 -0800 (PST) X-Received: by 2002:a17:902:dac4:b0:2a0:c5b8:24b0 with SMTP id d9443c01a7336-2a870dd56edmr28281295ad.46.1769530337793; Tue, 27 Jan 2026 08:12:17 -0800 (PST) Received: from [192.168.1.6] ([106.222.229.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802f97f3asm123086095ad.59.2026.01.27.08.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 08:12:17 -0800 (PST) Message-ID: <5db5dafd-3c1f-4844-b822-bbfe86b3eb4d@oss.qualcomm.com> Date: Tue, 27 Jan 2026 21:42:10 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] remoteproc: qcom: probe all child devices To: Dmitry Baryshkov Cc: Bjorn Andersson , mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org, mani@kernel.org, casey.connolly@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20251223123227.1317244-1-gaurav.kohli@oss.qualcomm.com> <20251223123227.1317244-3-gaurav.kohli@oss.qualcomm.com> <57493aef-fb35-4377-8cf3-1df7f53470c9@oss.qualcomm.com> <74h7r3vsig3csejax3eu3uk53mdiimg2hjx7ntmmfrwdai6s3j@eiztghclfcvt> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <74h7r3vsig3csejax3eu3uk53mdiimg2hjx7ntmmfrwdai6s3j@eiztghclfcvt> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: d44X-9O2A7RdWAHN9AjAOg39aPFY9CLo X-Proofpoint-GUID: d44X-9O2A7RdWAHN9AjAOg39aPFY9CLo X-Authority-Analysis: v=2.4 cv=UPXQ3Sfy c=1 sm=1 tr=0 ts=6978e3e3 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=EBd7WcfsMYPMwvoCMWz0vA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=2-K1YE3ZJe1EJHp8LXMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEzMiBTYWx0ZWRfX1AWx+6G/Wi2r hqVy6/6m3FxGseye2kGD1JNeRcGR9hClbeq1/V4S5M+DvvWUL/ZTDTyKKH0Lk9eN+acNM7XFkqu MzcmGQqZT0mIwxHiP2DsggBmwfR/VzOzaBJJ0T33yvJ54L0b1JF5s1QF8oRavfXf5Hg+qbxsUZk XBP6MIEk3veNVCAsz1J3aqoj9RYnKEg8PjLkGR2ViyoST5Kn/bLKvcTrIHbDLLc/FeuqqSJ/Eph 30stoHQJQkHEhaMNpofES0sTsb8ODpOqssQbjBKUMpdRHjJJFA+/IbPaFCaQiof6rfI9328cfgY DsVFAjNUdnPptgMlQRiDCQ0ycL5PugRXzMm81fquUQ8T8DmwoKuIRGZQ8HloWhmt6hYZggNFhBR KF3+Kq4col14DT8ytZEJY5KNS1CZhs7QzYfO2QUGownkMxTjODmeXrG/pWSLGj/znuNBnsHjA1+ wKDy0UAKl7Co9BO6Ggg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270132 On 1/24/2026 12:33 AM, Dmitry Baryshkov wrote: > On Fri, Jan 23, 2026 at 07:23:39PM +0530, Gaurav Kohli wrote: >> On 1/8/2026 12:37 PM, Gaurav Kohli wrote: >>> On 1/3/2026 8:26 PM, Bjorn Andersson wrote: >>>> On Tue, Dec 23, 2025 at 06:02:21PM +0530, Gaurav Kohli wrote: >>>>> From: Casey Connolly >>>>> >>>>> Generalise the qcom,bam-dmux child node support by probing all >>>>> remoteproc children with of_platform_populate(). This will be used to >>>>> enable support for devices which are best represented as >>>>> subnodes of the >>>>> remoteproc, such as those representing QMI clients. >>>> Please flip this around, start with the description of the problem >>>> you're trying to solve. >>>> >>>>> Signed-off-by: Casey Connolly >>>> This must have your signed-off-by, where you certifies the origin of >>>> this patch. >>>> >>>>> --- >>>>>   drivers/remoteproc/qcom_q6v5.c     | 4 ++++ >>>>>   drivers/remoteproc/qcom_q6v5_mss.c | 8 -------- >>>>>   2 files changed, 4 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/drivers/remoteproc/qcom_q6v5.c >>>>> b/drivers/remoteproc/qcom_q6v5.c >>>>> index 58d5b85e58cd..a02839c7ed8c 100644 >>>>> --- a/drivers/remoteproc/qcom_q6v5.c >>>>> +++ b/drivers/remoteproc/qcom_q6v5.c >>>>> @@ -6,6 +6,7 @@ >>>>>    * Copyright (C) 2014 Sony Mobile Communications AB >>>>>    * Copyright (c) 2012-2013, The Linux Foundation. All rights >>>>> reserved. >>>>>    */ >>>>> +#include >>>>>   #include >>>>>   #include >>>>>   #include >>>>> @@ -351,6 +352,8 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, >>>>> struct platform_device *pdev, >>>>>           return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path), >>>>>                        "failed to acquire interconnect path\n"); >>>>>   +    of_platform_populate(q6v5->dev->of_node, NULL, NULL, q6v5->dev); >>>> There are other child nodes here, in particular the GLINK and SMD edges. >>>> Do we really want platform_devices registered for them? >>>> >>>> Regards, >>>> Bjorn >>> >>> thanks for pointing this, can you please suggest the right approach. >>> >>> This should not impact glink, as that is registering as rproc sub node, >>> And we need rproc cooling as child node >>> >>> of remote proc subsytem to create probe dependency only. >>> >>> >>> Can we do platform populate for specific child, would that be right >>> approach. or we should create rproc cooling as independent of parent ? >>> >> HI Bjorn, >> >> I’d like to highlight the impact and details of placement of remoteproc >> cooling dt node: >> >> >> ->As a child of the remote proc subsystem node: >>     In this configuration, the cooling device will only be probed once the >> corresponding remote proc subsystem itself is probed. >> >> ->Outside the remote proc subsystem, may be part of soc node: >>     In this setup, the cooling device will be probed independently. It will >> wait until the remoteproc subsystem is brought up >>     before completing cooling registration. >>     The drawback here is that if the parent remoteproc subsystem is >> disabled, the cooling device will still undergo an >>     unnecessary probe, even though it cannot be registered. > Bjorns question was different. It wasn't about pushing cooling device > outside of the remoteproc node. It is about not registering the devices. > > Can we follow the approach outlined by qcom_add_smd_subdev() / > qcom_add_glink_subdev()? Hi Dmitry, Thanks for the review. Since the remoteproc cooling is a QMI-based driver, it will receive the subsystem up notification directly. Therefore, there’s no need to make it a subdev node or tie it into the init/reset sequence of remoteproc subsytem. >