From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, msavaliy@codeaurora.org
Subject: Re: [PATCH v5 2/3] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Fri, 22 Nov 2019 10:24:17 -0800 [thread overview]
Message-ID: <5dd827d2.1c69fb81.51ab0.220e@mx.google.com> (raw)
In-Reply-To: <0101016e91dcbb45-f54cf6e5-8ace-457a-96cc-edec41305719-000000@us-west-2.amazonses.com>
Quoting Akash Asthana (2019-11-21 22:46:32)
>
> On 11/16/2019 1:11 AM, Stephen Boyd wrote:
> > Quoting Akash Asthana (2019-11-15 02:00:44)
> >> On 11/14/2019 11:10 PM, Stephen Boyd wrote:
> >>> Quoting Akash Asthana (2019-11-13 02:48:56)
> >>>> Add system wakeup capability over UART RX line for wakeup capable UART.
> >>>> When system is suspended, RX line act as an interrupt to wakeup system
> >>>> for any communication requests from peer.
> >>> How does the RX line get remuxed as a GPIO interrupt here? Is that
> >>> through some pinctrl magic in DT or just via enabling/disabling the
> >>> interrupt?
> >> Yes, For wakeup capable UART node, we have registered UART RX line with
> >> TLMM interrupt controller in DT file . Example: if GPIO48 is UART RX line
> >>
> >> interrupts-extended = <&intc GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>, <&tlmm
> >> 48 IRQ_TYPE_EDGE_FALLING>;
> > Right. So is gpio48 muxed as 'uart' function forever and the interrupt
> > logic in tlmm is connected to that pad regardless of the function
> > selected? I thought that gpios through TLMM had to be muxed as function
> > 0, i.e. gpio function, so that interrupts worked. But maybe that's wrong
> > and it can work without that.
>
> Yes, gpio48 is muxed as "uart' function function forever. There is no
> need to mux gpio48 to
>
> gpio function, interrupts can work without that.
>
Ok thanks for confirming.
prev parent reply other threads:[~2019-11-22 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:48 [PATCH v5 2/3] tty: serial: qcom_geni_serial: Wakeup over UART RX Akash Asthana
2019-11-14 17:40 ` Stephen Boyd
2019-11-15 10:00 ` Akash Asthana
2019-11-15 19:41 ` Stephen Boyd
2019-11-22 6:46 ` Akash Asthana
[not found] ` <0101016e91dcbb45-f54cf6e5-8ace-457a-96cc-edec41305719-000000@us-west-2.amazonses.com>
2019-11-22 18:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd827d2.1c69fb81.51ab0.220e@mx.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=msavaliy@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox