From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD5E7354716 for ; Thu, 30 Oct 2025 11:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761822273; cv=none; b=adYs4mNG7jWx6o0foHv+dzeUZD4K3vgmySKOtD6gN/NwWoZddDznqpptY3/0yQZ0DZpJ+zAc4rUBkAzKjeBBeDxsPEJEaA/a3FtnWLTBWrj7jVOHPKQb5Rhr/lhMLU3RblwyDWFQWJUZ5vwutDUIg4pUqeY79sfQKFUwzfHhd/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761822273; c=relaxed/simple; bh=UNww3ygyeX71eQOpY9Y3q226oPQNNYee0k0JvCUw9MY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iKjIblA87SYHUE2aQkJb2yboVCUJhKtUP7HdQ3eUKyEygheuA8O3N8ReNnFALaqWTN6fz2D6sifD9Hh1X6Y+mR9jSMx/NXo07HIqCMvNMaeAk+4SRxPwzr0dRjXjtDE7zU17ZaLQ+C/PBU6qgIBB/pXicm986QHPc8NhtRfiitY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OObCSrmA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RD05/k4N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OObCSrmA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RD05/k4N" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59U7Eka01501940 for ; Thu, 30 Oct 2025 11:04:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VzFg8UbB6EUgeft2R47u8fMbiAli+RP+Tb+HZKyVwRA=; b=OObCSrmA4jJmqJyV hFOBygQYTAhXJVBcXd4BwgIPJX8NthFA8DdxTipC6G1ysw9MRqiqWM8Nms8Z0HAB 2vSLRf5rK0APCfhx+zKV/AzmetQGhuy42KobethA9DqnDl+/x1jC78LkPSaTlwl/ OdMC882WitswjuUcdn2sFAqovtZ2s2xd6+nNuK7PeE+PBy5v4RZVMvUqsYVNxPje YYETjjIYFE3/hnvB5rE52QaBt6XUFg51rghAopXLbRjGdcTB32tW87a+0B1sJyvb HLORF/7lSqhxsuyWpJYb47G0Ma5cNr/8ckz0APuRHD4j+XzBY22xU9Ltxx7eomcH gfxFYg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a3t1jt7me-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Oct 2025 11:04:31 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-7f5798303b3so2653006d6.3 for ; Thu, 30 Oct 2025 04:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761822270; x=1762427070; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VzFg8UbB6EUgeft2R47u8fMbiAli+RP+Tb+HZKyVwRA=; b=RD05/k4NZPhDll2JM8gOkkKc4GHIVGEouQe9LjCYTCrSJHFuI0eUGRqYKAqZBCya4j gWK+qiiXUSfP9FMfianCpYYPk9AsiCHJFxs/QJMAMWhj1qCMuAr5iFhLQ5N+Pp0h7dl0 8DxMx8F2I477tbZe15/l64gRsLHfJz17R49bXo8J1pOGaCAowrF/n2ZNYdNkqJsL3s29 TKwKYbwL5Sv1pD8XR9wJJPIDlrvEc+PS6SiJF0tKjMwZJkmsHNMnhielON9EuU+K2uT3 9RD3c2JKTED0YxTg8YXOt/pOaAX5qrZ/cCTnWJORiNR3p4a3Kklwc3O71SlolgZRwcsQ QWXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761822270; x=1762427070; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VzFg8UbB6EUgeft2R47u8fMbiAli+RP+Tb+HZKyVwRA=; b=T7eZNPFmZcUgV6aNR5qbzVygeIRFgsmY3V9Ldr6uUTSFT0tMGahbSETXDkqk/bEKiK EozQO4Al1a4E4U0nCdMSFyMjJeokxixaaHssXdqdDTH9Njr0S8hAvIUfee+pBDBuTzqf idqT1xZwLSkDJrTNG2MCsX3N3I0PUPbkLxDbZc7XszcKTpzOzBM6FfjbYWjSEYPv82wp d0dMiFCnGbU26c0vY49XRG4VWUrHAvQRv0pyF/b5ph5f2+sUFxXBS1NMsdB6ZBHtqUET 0fSP+feG7IecxsqgM3Y07is9CUHDP+7VX2MS01h91mncC/fKfoJ4THMJjbD9ohjY9Kqn nzQQ== X-Forwarded-Encrypted: i=1; AJvYcCWe1uskc701QA5qmeneimb5jTJ6+Airps1VY7AalgkR9HueiotwvqAIVmjTjR5L9OGf6s05bRlkmgNwmVZO@vger.kernel.org X-Gm-Message-State: AOJu0YxNgEiWh9w0IUYXpUqsIGSMd8pmjxPfMqu6NHk5lgZ9oVmjYE3B 9PLdwwK5jXhJVkRpNL66Msa5AEWL1g2/vJTM4FGXR6VzIYh22gmzJWFpiYfljKjJELLZlXHNND7 1VpMYcg7OKZVO+YILkHXyhmmzCZ5JHneUdxVJ6yg0hvTbzw1ok/5xZunO0T5+d6Rtq7lJ X-Gm-Gg: ASbGncv7fUvevFIsF4ZXyMwactIolYBJryZ58FC9iEYs8RsK8cmrGOwpB/NFVBDWhEx gRNvgx4zJYPxC/5Mc6wwue6v96WexyKi2Wax8hMr3nNo7o0giFJJ942bX9ZbuorxWLkQzCmIcf2 w3nMJg0vzP7ZVxtKIZNpbCK8SOTwbw6l5FoEHtFe/n7L1WRlmmuei0bup6wocx57oFPuwbRRMA+ MVkKsp/mGRh4+KhT3UUWR4c4eMlEnnx9u+xLQMmUFIr4/9yro2ogfOK09U0sKGPcLTGIQqagDJV NwJQwMl3Br8pvQugZB/WsREvcCNtDYzWIXBdy7TSYDqtxQQpzLctToCjZxrS9qdtejaLH+Ncpd4 0H7XUdyP8SsRAVVUdJ9+GkBAaN+jxeTOtBa2u55j2nT0VTS2vwCWtH0ze X-Received: by 2002:ad4:4eeb:0:b0:81f:3abf:dc1f with SMTP id 6a1803df08f44-88009c1dcc8mr51973586d6.8.1761822269979; Thu, 30 Oct 2025 04:04:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEj05MubBtygtqeTR6KibEHOmmH0Vqi1S90+C2VimB73/rb0UVkgKNAaSdUTuerVM8yOCSXMw== X-Received: by 2002:ad4:4eeb:0:b0:81f:3abf:dc1f with SMTP id 6a1803df08f44-88009c1dcc8mr51973356d6.8.1761822269232; Thu, 30 Oct 2025 04:04:29 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63e7ef6e777sm14245241a12.6.2025.10.30.04.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Oct 2025 04:04:28 -0700 (PDT) Message-ID: <5df2f0ad-1514-4a8e-9203-fe2b72141102@oss.qualcomm.com> Date: Thu, 30 Oct 2025 12:04:26 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] arm64: dts: qcom: cleanup GPU's zap-shader node To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251028-dt-zap-shader-v1-0-7eccb823b986@oss.qualcomm.com> <51f10d4e-3962-4c20-9d5f-afd0ac3f598e@oss.qualcomm.com> <289d000a-b142-46cf-ad15-07ab8ed377c9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: N2Z7CroZqVr9IYz5HmWxDrUJ9zmIOmhj X-Proofpoint-ORIG-GUID: N2Z7CroZqVr9IYz5HmWxDrUJ9zmIOmhj X-Authority-Analysis: v=2.4 cv=M/lA6iws c=1 sm=1 tr=0 ts=6903463f cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=beMPh-m-NBtQyn-zy7EA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDMwMDA5MCBTYWx0ZWRfXxW2OIlDrSOq7 c+WOQeXIm2+irUDfV3SAGUbWwomLjO0T5EC78v63AGfwaqqtp7PvjaH14bgpGL7Y2Gnv515e03F 7wIarvs0PzwaXeIVuCKrqaVu1Wx3nsPAyjHVqva8+fDJ/7dUdawwTNia/iFjNmIgjDbJDDbySI+ vOtqBiHjNuodqmUcfncFJUls/0B/Q6HnPiwPyfearTfIeZ56CBoRNlCx546sXHNKyexNBK/MDar /IiCgopxKiP3dwwg6fn/+IJ+mgYmJSC2lFwjaZPZPe53AKAtz7lq1GSsov/074fClp7suSZ4ZwO droSuweLm6t8dj88UKBJox4iCZuCQf/Mkh7tww7cZ4WJC8wyo8V9JHxuAaXGWFRhrKThOiyrRbB AMx2MxvSwC7AIMGTZ4vMP2WX7hQk4w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-10-30_03,2025-10-29_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510300090 On 10/29/25 1:35 PM, Dmitry Baryshkov wrote: > On Wed, Oct 29, 2025 at 10:36:45AM +0100, Konrad Dybcio wrote: >> On 10/29/25 10:35 AM, Dmitry Baryshkov wrote: >>> On 29/10/2025 11:33, Konrad Dybcio wrote: >>>> On 10/28/25 9:59 PM, Dmitry Baryshkov wrote: >>>>> Historically all devices manually defined GPU zap-shader node in their >>>>> board DT files. This practice is frowned upon. Add the zap-shader node >>>>> on all platforms, define a label for it and use the label in order to >>>>> patch the node with the firmware name. >>>> >>>> I'm not sure this is much of an improvement, since at the end of the >>>> series, boards still have a &gpu { zap-shader {} } section, with the >>>> inner one not being referred to through a label, which reduces >>>> duplication in the single LoC used to assign memory-region, but >>>> doesn't e.g. prevent typos in the zap-shader node name >>> >>> By the end of the series the boards don't have zap-shader{}. They use &gpu_zap_shader { firmware-name = "something" ; }; >> >> /me wipes glasses >> >> You're right, I skipped over the last patch > > R-B ? rb! Konrad