* [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
@ 2018-02-22 17:37 Sean Paul
[not found] ` <20180222173758.6125-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Sean Paul @ 2018-02-22 17:37 UTC (permalink / raw)
To: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA
Cc: jsanka-sgV2jX0FEOL9JmXXK+q4OQ, abhinavk-jfJNa2p1gH1BDgjK7y7TUQ,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, Sean Paul,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw
msm/dsi already formats the packet header correctly, so this breaks
every driver except for the downstream dsi-staging driver (which I've
submitted a patch for).
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 688c8a82ba37..4b47226b90d4 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
return -EINVAL;
memset(packet, 0, sizeof(*packet));
- packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
+ packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
/* TODO: compute ECC if hardware support is not available */
@@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
* and 2.
*/
if (mipi_dsi_packet_format_is_long(msg->type)) {
- packet->header[0] = (msg->tx_len >> 0) & 0xff;
- packet->header[1] = (msg->tx_len >> 8) & 0xff;
+ packet->header[1] = (msg->tx_len >> 0) & 0xff;
+ packet->header[2] = (msg->tx_len >> 8) & 0xff;
packet->payload_length = msg->tx_len;
packet->payload = msg->tx_buf;
} else {
const u8 *tx = msg->tx_buf;
- packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
- packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
+ packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
+ packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
}
packet->size = sizeof(packet->header) + packet->payload_length;
--
2.16.1.291.g4437f3f132-goog
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
[not found] ` <20180222173758.6125-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2018-02-22 19:48 ` Rob Clark
[not found] ` <CAF6AEGuQPgq4SwwTqdnt=KLNcRRevkUB9PRpD0nsQKFoOox3FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Rob Clark @ 2018-02-22 19:48 UTC (permalink / raw)
To: Sean Paul
Cc: linux-arm-msm, Kristian H. Kristensen, freedreno,
Jeykumar Sankaran, Abhinav Kumar
On Thu, Feb 22, 2018 at 12:37 PM, Sean Paul <seanpaul@chromium.org> wrote:
> msm/dsi already formats the packet header correctly, so this breaks
> every driver except for the downstream dsi-staging driver (which I've
> submitted a patch for).
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index 688c8a82ba37..4b47226b90d4 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
> return -EINVAL;
>
> memset(packet, 0, sizeof(*packet));
> - packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
> + packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
>
> /* TODO: compute ECC if hardware support is not available */
>
> @@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
> * and 2.
> */
> if (mipi_dsi_packet_format_is_long(msg->type)) {
> - packet->header[0] = (msg->tx_len >> 0) & 0xff;
> - packet->header[1] = (msg->tx_len >> 8) & 0xff;
> + packet->header[1] = (msg->tx_len >> 0) & 0xff;
> + packet->header[2] = (msg->tx_len >> 8) & 0xff;
>
> packet->payload_length = msg->tx_len;
> packet->payload = msg->tx_buf;
> } else {
> const u8 *tx = msg->tx_buf;
>
> - packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
> - packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
> + packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
> + packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
> }
>
> packet->size = sizeof(packet->header) + packet->payload_length;
> --
> 2.16.1.291.g4437f3f132-goog
>
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
[not found] ` <CAF6AEGuQPgq4SwwTqdnt=KLNcRRevkUB9PRpD0nsQKFoOox3FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-02-23 2:28 ` Abhinav Kumar
[not found] ` <3907cdfb10d5445f889e464720226c74-U89/IHrbReUlMFxvxe/2TaRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Abhinav Kumar @ 2018-02-23 2:28 UTC (permalink / raw)
To: Rob Clark, Sean Paul
Cc: linux-arm-msm, Nagamalleswararao Ganji, Chandan Uddaraju,
Kristian H. Kristensen, freedreno, Jeykumar Sankaran
Looks good. Can you point us to the fix done in the dsi-staging driver.
Thanks
Abhinav
-----Original Message-----
From: Rob Clark [mailto:robdclark@gmail.com]
Sent: Thursday, February 22, 2018 11:49 AM
To: Sean Paul <seanpaul@chromium.org>
Cc: freedreno <freedreno@lists.freedesktop.org>; linux-arm-msm <linux-arm-msm@vger.kernel.org>; Kristian H. Kristensen <hoegsberg@chromium.org>; Jeykumar Sankaran <jsanka@codeaurora.org>; Abhinav Kumar <abhinavk@quicinc.com>
Subject: Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
On Thu, Feb 22, 2018 at 12:37 PM, Sean Paul <seanpaul@chromium.org> wrote:
> msm/dsi already formats the packet header correctly, so this breaks
> every driver except for the downstream dsi-staging driver (which I've
> submitted a patch for).
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> b/drivers/gpu/drm/drm_mipi_dsi.c index 688c8a82ba37..4b47226b90d4
> 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
> return -EINVAL;
>
> memset(packet, 0, sizeof(*packet));
> - packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
> + packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type &
> + 0x3f);
>
> /* TODO: compute ECC if hardware support is not available */
>
> @@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
> * and 2.
> */
> if (mipi_dsi_packet_format_is_long(msg->type)) {
> - packet->header[0] = (msg->tx_len >> 0) & 0xff;
> - packet->header[1] = (msg->tx_len >> 8) & 0xff;
> + packet->header[1] = (msg->tx_len >> 0) & 0xff;
> + packet->header[2] = (msg->tx_len >> 8) & 0xff;
>
> packet->payload_length = msg->tx_len;
> packet->payload = msg->tx_buf;
> } else {
> const u8 *tx = msg->tx_buf;
>
> - packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
> - packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
> + packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
> + packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
> }
>
> packet->size = sizeof(packet->header) +
> packet->payload_length;
> --
> 2.16.1.291.g4437f3f132-goog
>
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
[not found] ` <3907cdfb10d5445f889e464720226c74-U89/IHrbReUlMFxvxe/2TaRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org>
@ 2018-02-23 15:06 ` Sean Paul
[not found] ` <CAOw6vb+2z0LBcZSiTf+k=J=26h8uWqyBhoQrEd1=4+-oA7fnWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Sean Paul @ 2018-02-23 15:06 UTC (permalink / raw)
To: Abhinav Kumar
Cc: linux-arm-msm, Rob Clark, Nagamalleswararao Ganji,
Chandan Uddaraju, Jeykumar Sankaran, freedreno,
Kristian H. Kristensen
On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar <abhinavk@quicinc.com> wrote:
> Looks good. Can you point us to the fix done in the dsi-staging driver.
>
All of the downstream changes are in the mtp-testing branch of the
dpu-staging tree. The on-list patches are in the for-next-staging, and
the patches which have been reviewed on list will go to the for-next
branch.
Sean
> Thanks
>
> Abhinav
>
> -----Original Message-----
> From: Rob Clark [mailto:robdclark@gmail.com]
> Sent: Thursday, February 22, 2018 11:49 AM
> To: Sean Paul <seanpaul@chromium.org>
> Cc: freedreno <freedreno@lists.freedesktop.org>; linux-arm-msm <linux-arm-msm@vger.kernel.org>; Kristian H. Kristensen <hoegsberg@chromium.org>; Jeykumar Sankaran <jsanka@codeaurora.org>; Abhinav Kumar <abhinavk@quicinc.com>
> Subject: Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
>
> On Thu, Feb 22, 2018 at 12:37 PM, Sean Paul <seanpaul@chromium.org> wrote:
>> msm/dsi already formats the packet header correctly, so this breaks
>> every driver except for the downstream dsi-staging driver (which I've
>> submitted a patch for).
>>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>
> Reviewed-by: Rob Clark <robdclark@gmail.com>
>
>> ---
>> drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
>> b/drivers/gpu/drm/drm_mipi_dsi.c index 688c8a82ba37..4b47226b90d4
>> 100644
>> --- a/drivers/gpu/drm/drm_mipi_dsi.c
>> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
>> @@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
>> return -EINVAL;
>>
>> memset(packet, 0, sizeof(*packet));
>> - packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type & 0x3f);
>> + packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type &
>> + 0x3f);
>>
>> /* TODO: compute ECC if hardware support is not available */
>>
>> @@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
>> * and 2.
>> */
>> if (mipi_dsi_packet_format_is_long(msg->type)) {
>> - packet->header[0] = (msg->tx_len >> 0) & 0xff;
>> - packet->header[1] = (msg->tx_len >> 8) & 0xff;
>> + packet->header[1] = (msg->tx_len >> 0) & 0xff;
>> + packet->header[2] = (msg->tx_len >> 8) & 0xff;
>>
>> packet->payload_length = msg->tx_len;
>> packet->payload = msg->tx_buf;
>> } else {
>> const u8 *tx = msg->tx_buf;
>>
>> - packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
>> - packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
>> + packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
>> + packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
>> }
>>
>> packet->size = sizeof(packet->header) +
>> packet->payload_length;
>> --
>> 2.16.1.291.g4437f3f132-goog
>>
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
[not found] ` <CAOw6vb+2z0LBcZSiTf+k=J=26h8uWqyBhoQrEd1=4+-oA7fnWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-02-23 21:34 ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <5e7d083e7e5d49717f20c928057856eb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-02-23 21:34 UTC (permalink / raw)
To: Sean Paul
Cc: linux-arm-msm, linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA,
Rob Clark, Nagamalleswararao Ganji, Chandan Uddaraju,
Jeykumar Sankaran, freedreno, Kristian H. Kristensen
Alright, found it
https://cgit.freedesktop.org/~seanpaul/dpu-staging/commit/?h=mtp-testing&id=34906195473f9e04601c49a45e3fedce0132eb7e
Thanks
Abhinav
On 2018-02-23 07:06, Sean Paul wrote:
> On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar <abhinavk@quicinc.com>
> wrote:
>> Looks good. Can you point us to the fix done in the dsi-staging
>> driver.
>>
>
> All of the downstream changes are in the mtp-testing branch of the
> dpu-staging tree. The on-list patches are in the for-next-staging, and
> the patches which have been reviewed on list will go to the for-next
> branch.
>
> Sean
>
>
>> Thanks
>>
>> Abhinav
>>
>> -----Original Message-----
>> From: Rob Clark [mailto:robdclark@gmail.com]
>> Sent: Thursday, February 22, 2018 11:49 AM
>> To: Sean Paul <seanpaul@chromium.org>
>> Cc: freedreno <freedreno@lists.freedesktop.org>; linux-arm-msm
>> <linux-arm-msm@vger.kernel.org>; Kristian H. Kristensen
>> <hoegsberg@chromium.org>; Jeykumar Sankaran <jsanka@codeaurora.org>;
>> Abhinav Kumar <abhinavk@quicinc.com>
>> Subject: Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet
>> header format
>>
>> On Thu, Feb 22, 2018 at 12:37 PM, Sean Paul <seanpaul@chromium.org>
>> wrote:
>>> msm/dsi already formats the packet header correctly, so this breaks
>>> every driver except for the downstream dsi-staging driver (which I've
>>> submitted a patch for).
>>>
>>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>>
>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>>
>>> ---
>>> drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
>>> b/drivers/gpu/drm/drm_mipi_dsi.c index 688c8a82ba37..4b47226b90d4
>>> 100644
>>> --- a/drivers/gpu/drm/drm_mipi_dsi.c
>>> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
>>> @@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet
>>> *packet,
>>> return -EINVAL;
>>>
>>> memset(packet, 0, sizeof(*packet));
>>> - packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type
>>> & 0x3f);
>>> + packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type
>>> &
>>> + 0x3f);
>>>
>>> /* TODO: compute ECC if hardware support is not available */
>>>
>>> @@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct
>>> mipi_dsi_packet *packet,
>>> * and 2.
>>> */
>>> if (mipi_dsi_packet_format_is_long(msg->type)) {
>>> - packet->header[0] = (msg->tx_len >> 0) & 0xff;
>>> - packet->header[1] = (msg->tx_len >> 8) & 0xff;
>>> + packet->header[1] = (msg->tx_len >> 0) & 0xff;
>>> + packet->header[2] = (msg->tx_len >> 8) & 0xff;
>>>
>>> packet->payload_length = msg->tx_len;
>>> packet->payload = msg->tx_buf;
>>> } else {
>>> const u8 *tx = msg->tx_buf;
>>>
>>> - packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
>>> - packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
>>> + packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
>>> + packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
>>> }
>>>
>>> packet->size = sizeof(packet->header) +
>>> packet->payload_length;
>>> --
>>> 2.16.1.291.g4437f3f132-goog
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format
[not found] ` <5e7d083e7e5d49717f20c928057856eb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2018-03-02 20:48 ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 6+ messages in thread
From: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-03-02 20:48 UTC (permalink / raw)
To: Sean Paul
Cc: linux-arm-msm, linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA,
Rob Clark, Jeykumar Sankaran, freedreno, Kristian H. Kristensen
On 2018-02-23 13:34, abhinavk@codeaurora.org wrote:
> Alright, found it
>
> https://cgit.freedesktop.org/~seanpaul/dpu-staging/commit/?h=mtp-testing&id=34906195473f9e04601c49a45e3fedce0132eb7e
>
> Thanks
>
> Abhinav
>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> On 2018-02-23 07:06, Sean Paul wrote:
>> On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar <abhinavk@quicinc.com>
>> wrote:
>>> Looks good. Can you point us to the fix done in the dsi-staging
>>> driver.
>>>
>>
>> All of the downstream changes are in the mtp-testing branch of the
>> dpu-staging tree. The on-list patches are in the for-next-staging, and
>> the patches which have been reviewed on list will go to the for-next
>> branch.
>>
>> Sean
>>
>>
>>> Thanks
>>>
>>> Abhinav
>>>
>>> -----Original Message-----
>>> From: Rob Clark [mailto:robdclark@gmail.com]
>>> Sent: Thursday, February 22, 2018 11:49 AM
>>> To: Sean Paul <seanpaul@chromium.org>
>>> Cc: freedreno <freedreno@lists.freedesktop.org>; linux-arm-msm
>>> <linux-arm-msm@vger.kernel.org>; Kristian H. Kristensen
>>> <hoegsberg@chromium.org>; Jeykumar Sankaran <jsanka@codeaurora.org>;
>>> Abhinav Kumar <abhinavk@quicinc.com>
>>> Subject: Re: [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi
>>> packet header format
>>>
>>> On Thu, Feb 22, 2018 at 12:37 PM, Sean Paul <seanpaul@chromium.org>
>>> wrote:
>>>> msm/dsi already formats the packet header correctly, so this breaks
>>>> every driver except for the downstream dsi-staging driver (which
>>>> I've
>>>> submitted a patch for).
>>>>
>>>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>>>
>>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>>>
>>>> ---
>>>> drivers/gpu/drm/drm_mipi_dsi.c | 10 +++++-----
>>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
>>>> b/drivers/gpu/drm/drm_mipi_dsi.c index 688c8a82ba37..4b47226b90d4
>>>> 100644
>>>> --- a/drivers/gpu/drm/drm_mipi_dsi.c
>>>> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
>>>> @@ -454,7 +454,7 @@ int mipi_dsi_create_packet(struct
>>>> mipi_dsi_packet *packet,
>>>> return -EINVAL;
>>>>
>>>> memset(packet, 0, sizeof(*packet));
>>>> - packet->header[2] = ((msg->channel & 0x3) << 6) | (msg->type
>>>> & 0x3f);
>>>> + packet->header[0] = ((msg->channel & 0x3) << 6) | (msg->type
>>>> &
>>>> + 0x3f);
>>>>
>>>> /* TODO: compute ECC if hardware support is not available */
>>>>
>>>> @@ -466,16 +466,16 @@ int mipi_dsi_create_packet(struct
>>>> mipi_dsi_packet *packet,
>>>> * and 2.
>>>> */
>>>> if (mipi_dsi_packet_format_is_long(msg->type)) {
>>>> - packet->header[0] = (msg->tx_len >> 0) & 0xff;
>>>> - packet->header[1] = (msg->tx_len >> 8) & 0xff;
>>>> + packet->header[1] = (msg->tx_len >> 0) & 0xff;
>>>> + packet->header[2] = (msg->tx_len >> 8) & 0xff;
>>>>
>>>> packet->payload_length = msg->tx_len;
>>>> packet->payload = msg->tx_buf;
>>>> } else {
>>>> const u8 *tx = msg->tx_buf;
>>>>
>>>> - packet->header[0] = (msg->tx_len > 0) ? tx[0] : 0;
>>>> - packet->header[1] = (msg->tx_len > 1) ? tx[1] : 0;
>>>> + packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
>>>> + packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
>>>> }
>>>>
>>>> packet->size = sizeof(packet->header) +
>>>> packet->payload_length;
>>>> --
>>>> 2.16.1.291.g4437f3f132-goog
>>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-02 20:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-22 17:37 [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format Sean Paul
[not found] ` <20180222173758.6125-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-02-22 19:48 ` Rob Clark
[not found] ` <CAF6AEGuQPgq4SwwTqdnt=KLNcRRevkUB9PRpD0nsQKFoOox3FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-23 2:28 ` Abhinav Kumar
[not found] ` <3907cdfb10d5445f889e464720226c74-U89/IHrbReUlMFxvxe/2TaRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org>
2018-02-23 15:06 ` Sean Paul
[not found] ` <CAOw6vb+2z0LBcZSiTf+k=J=26h8uWqyBhoQrEd1=4+-oA7fnWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-23 21:34 ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <5e7d083e7e5d49717f20c928057856eb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-02 20:48 ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).