From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Vinod Koul <vkoul@kernel.org>, Rob Clark <robdclark@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>
Subject: Re: [PATCH 3/4] arm64: dts: qcom: msm8996: Improve GPU OPP table
Date: Wed, 9 Aug 2023 01:47:08 +0200 [thread overview]
Message-ID: <60cbc599-e95b-4723-9cc0-525bfe5cfcbb@linaro.org> (raw)
In-Reply-To: <0e703d3c-7ad9-6265-fa71-b62650b96e79@linaro.org>
On 26.05.2023 15:30, Konrad Dybcio wrote:
>
>
> On 30.03.2023 12:57, Konrad Dybcio wrote:
>>
>>
>> On 29.03.2023 23:32, Dmitry Baryshkov wrote:
>>> On Wed, 29 Mar 2023 at 22:17, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>>
>>>> Remove the self-explanatory comment about opp-supported-hw contents,
>>>> add required-opps to ensure reasonable power domain levels are voted
>>>> for (currently we've been piggybacking off of miracles and MDP votes)
>>>> and add newlines between each subnode.
>>>
>>> I'm not sure this is 100% correct. The values that you add are correct
>>> for the voltage scaling case. However, based on the vendor kernel
>>> sources I think that MX should only be scaled if the voltage is scaled
>>> too. I might be wrong here.
>> MX must be >= CX (and GX), so this should bring no harm.
>>
>> (citation needed, but that seems to hold true..)
> With that in mind, would you ack these patches Dmitry?
Bump?
Konrad
next prev parent reply other threads:[~2023-08-08 23:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 19:17 [PATCH 0/4] Improve some Adreno Device Tree nodes Konrad Dybcio
2023-03-29 19:17 ` [PATCH 1/4] arm64: dts: qcom: msm8998: Improve GPU OPP table Konrad Dybcio
2023-03-29 19:17 ` [PATCH 2/4] arm64: dts: qcom: msm8996: Pass VDDMX to gpu in power-domains Konrad Dybcio
2023-03-29 21:29 ` Dmitry Baryshkov
2023-03-29 19:17 ` [PATCH 3/4] arm64: dts: qcom: msm8996: Improve GPU OPP table Konrad Dybcio
2023-03-29 21:32 ` Dmitry Baryshkov
2023-03-30 10:57 ` Konrad Dybcio
2023-05-26 13:30 ` Konrad Dybcio
2023-05-26 13:51 ` Dmitry Baryshkov
2023-08-08 23:47 ` Konrad Dybcio [this message]
2023-03-29 19:17 ` [PATCH 4/4] arm64: dts: qcom: msm8916: " Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60cbc599-e95b-4723-9cc0-525bfe5cfcbb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andy.gross@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jordan@cosmicpenguin.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox