From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
srini@kernel.org, linux-arm-msm@vger.kernel.org
Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com,
linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
dri-devel@lists.freedesktop.org, arnd@arndb.de,
dmitry.baryshkov@oss.qualcomm.com
Subject: Re: [PATCH v4 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support
Date: Fri, 28 Nov 2025 12:51:14 +0100 [thread overview]
Message-ID: <60fe241d-276f-489e-9c74-677dd154b454@oss.qualcomm.com> (raw)
In-Reply-To: <20251128050534.437755-4-ekansh.gupta@oss.qualcomm.com>
On 11/28/25 6:05 AM, Ekansh Gupta wrote:
> Current FastRPC message context uses a 12-bit mask where the upper
> 8 bits represent the context ID from idr_alloc_cyclic and the lower
> 4 bits represent the PD type.
<newline>
> This layout works for normal FastRPC
> calls but fails for polling mode because DSP expects a 16-bit context
> with an additional async mode bit.
<newline>
> To enable polling mode support
> from DSP(DSP writes to poll memory), DSP expects a 16-bit context
> where the upper 8 bits are context ID, the lower 4 bits are PD type
> and the 5th bit from the end denotes async mode(not yet upstreamed).
<newline>
so we get
1
5 0
CCCCCCCCxxxAPPPP
where C is context ID, A is is_async, and P is PD type
are the x bits reserved, or do they serve some purpose?
> If this bit is set, DSP disables polling. With the current design,
> odd context IDs set this bit, causing DSP to skip poll memory updates.
<newline>
> Update the context mask to ensure a hole which won't get populated,
"to avoid erroneously setting that bit"
> ensuring polling mode works as expected. This is not a bug and the
> change is added to support polling mode.
I think the main question that remains unanswered here is that you alter
the non-polling mode mask to become compliant with what polling-mode
expects.
Is that intended? Will this still work fine without patch 4 and the
new FASTRPC_IOCTL_SET_OPTION?
Konrad
next prev parent reply other threads:[~2025-11-28 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 5:05 [PATCH v4 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2025-11-28 5:05 ` [PATCH v4 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2025-11-28 5:05 ` [PATCH v4 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2025-11-28 5:05 ` [PATCH v4 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2025-11-28 11:51 ` Konrad Dybcio [this message]
2025-12-02 5:24 ` Ekansh Gupta
2025-11-28 5:05 ` [PATCH v4 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60fe241d-276f-489e-9c74-677dd154b454@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=arnd@arndb.de \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox