From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: andersson@kernel.org, konrad.dybcio@somainline.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
johan+linaro@kernel.org, quic_jprakash@quicinc.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} VADC channels
Date: Wed, 2 Nov 2022 12:21:44 -0400 [thread overview]
Message-ID: <6130bdbc-163a-c950-e2e1-07ef77124833@linaro.org> (raw)
In-Reply-To: <20221030071659.GE5362@thinkpad>
On 30/10/2022 03:16, Manivannan Sadhasivam wrote:
>>>
>>>> + reg = <PM8350_ADC7_DIE_TEMP(1)>;
>>>> + label = "pm8280_1_die_temp";
>>>> + qcom,pre-scaling = <1 1>;
>>>> + };
>>>> +
>>>> + sys-therm1@144 {
>>>
>>> I would say sys-therm@... why do we need the "1" suffix in node name?
>>>
>>
>> Suffix represents the index of the thermistor as per the schematics but I guess
>> it can be dropped.
>>
>
> I was wrong. Suffix is necessary since IIO core registers the channel based on
> the node name, so it has to be unique.
>
Makes sense then.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-02 16:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 6:29 [PATCH 00/11] Updates to sc8280xp-pmic Manivannan Sadhasivam
2022-10-27 6:29 ` [PATCH 01/11] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Manivannan Sadhasivam
2022-10-27 13:46 ` Krzysztof Kozlowski
2022-10-27 6:29 ` [PATCH 02/11] arm64: dts: qcom: sc8280xp-pmics: Add temp alarm for PM8280_{1/2} PMICs Manivannan Sadhasivam
2022-10-27 13:47 ` Krzysztof Kozlowski
2022-10-27 6:29 ` [PATCH 03/11] arm64: dts: qcom: sc8280xp-pmics: Add thermal zones " Manivannan Sadhasivam
2022-10-27 13:50 ` Krzysztof Kozlowski
2022-10-27 6:29 ` [PATCH 04/11] arm64: dts: qcom: sc8280xp-pmics: Add support for PMK8280 RESIN input Manivannan Sadhasivam
2022-10-27 13:50 ` Krzysztof Kozlowski
2022-10-27 6:30 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280 ADC7 block Manivannan Sadhasivam
2022-10-27 13:54 ` Krzysztof Kozlowski
2022-10-27 6:30 ` [PATCH 06/11] arm64: dts: qcom: sc8280xp-pmics: Add support for TM5 block in PMK8280 Manivannan Sadhasivam
2022-10-27 14:01 ` Krzysztof Kozlowski
2022-10-27 6:30 ` [PATCH 07/11] arm64: dts: qcom: sc8280xp-x13s: Enable PMK8280 RESIN input Manivannan Sadhasivam
2022-10-27 14:01 ` Krzysztof Kozlowski
2022-10-27 6:30 ` [PATCH 08/11] arm64: dts: qcom: sc8280xp-x13s: Add PMK8280 VADC channels Manivannan Sadhasivam
2022-10-27 14:03 ` Krzysztof Kozlowski
2022-10-27 14:04 ` Krzysztof Kozlowski
2022-10-29 4:45 ` Manivannan Sadhasivam
2022-10-27 6:30 ` [PATCH 09/11] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} " Manivannan Sadhasivam
2022-10-27 14:09 ` Krzysztof Kozlowski
2022-10-29 4:48 ` Manivannan Sadhasivam
2022-10-30 7:16 ` Manivannan Sadhasivam
2022-11-02 16:21 ` Krzysztof Kozlowski [this message]
2022-10-27 6:30 ` [PATCH 10/11] arm64: dts: qcom: sc8280xp-x13s: Add PMR735A VADC channel Manivannan Sadhasivam
2022-10-27 6:30 ` [PATCH 11/11] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} ADC_TM5 channels Manivannan Sadhasivam
2022-10-27 14:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6130bdbc-163a-c950-e2e1-07ef77124833@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_jprakash@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox