Re: [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002

Timur Tabi
2017-12-20T17:46:38Z

On 12/20/2017 02:15 AM, Stephen Boyd wrote:
> Here's the patch. I get a hang when dumping debugfs, but at least
> sysfs expose fails when trying to request blocked gpios. I need
> to check if we need to say "yes" to pins that are above the gpio
> max for pinctrl. I'll do that tomorrow.

Sorry, I just don't see how this is better than my patches. I don't
understand the need for involving the IRQ valid mask. I also don't see
the value in adding code to look for a property that exists only in one
ACPI HID (QCOM8002) as if it were generic. The "num-gpios" and "gpios"
DSDs are not supposed to exist in any other HID, so there should be no
code that reads it in pinctrl-msm.

I'm going on vacation soon. I will post a v11 that eliminates support
for QCOM8001. Maybe that version is "good enough" for now and you can
add DT and/or IRQ support on top of it.