From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE5EC636CB for ; Mon, 30 Jan 2023 14:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237846AbjA3Oaj (ORCPT ); Mon, 30 Jan 2023 09:30:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237794AbjA3OaZ (ORCPT ); Mon, 30 Jan 2023 09:30:25 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04EB341B42 for ; Mon, 30 Jan 2023 06:28:54 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so8703932wmq.1 for ; Mon, 30 Jan 2023 06:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3McM8N2nTNHlQJb+34FnCzXtbwo9fjKoxA+DQBRkosk=; b=W+4S0TS5rGn11tvXQnBUz4wkUQ6e6spHYiWdjrHK+MrbxNyoj92UoUEx93cmEwXl0a A25bJY74OMfuP9Yo4JDKC+u9zJt4J6aFd+OdgcHPN5xo0nQFjKkuOvNPZAiTv9iNqL5w BrUd1V6BPIKRa9aVyR9vvikKJAthwPQCW0KqxiIJBasgaLSGUcLDjBQ23Np6Pw2U+rn4 TNlEUSLzvo1NMP1aj6VPEvpBleY3kjj2zcQwQZgZ6nag6MlVL/2XM2j5VlPg8aIXJ7AM LbHtN5cTU0bFaoOOwLfQvIpPKcAZ/gMK5tuDVEr6ld5vVxi0bENYztBWilGB4Nn1UY3X VeVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3McM8N2nTNHlQJb+34FnCzXtbwo9fjKoxA+DQBRkosk=; b=kqIm1bOgOUJ6aZGAFhDa59Q/UPYp/e8X+4jpFGZrJ+nRyaJ5CP8XNiGHtv6O4QFPN+ fKgeFafgbJOw7p28s1MDUrftbLu+BX+vKdQwtaXb/k9H1g7vJEimNI+mB7ZMXHMjCDxe PxqWtVO+2fmA1qm4T5oqrfWDJXO6snxNZADcwStRKp+hXrLMasX5jt1dpmi01s7t4mfC kiZFM4PACItkRSYwZOJwi/4I79JLPNWaSwvzXwynlFfJ3/WRvVqNifxmkg6t8VG9Mkzl ekImsJifw73OLH52pkrMCMDCXxXltqdYp2t39tGEYd4CisIlzweBERSE67b8jmdoxzq5 PnDA== X-Gm-Message-State: AO0yUKXM+hG+1DKgXRU3iXDuglLew6ejR57/DNO3Bgte+JVnDLB3Ghad qZepznp44zcI0TKBRDz6eEKFzg== X-Google-Smtp-Source: AK7set+s835IjnjqvQA+6fK2qQWO3YZKjyof+ji04X1Em1crGP9Vi/S4SYGCAvDntgVbNdkPzFpE0g== X-Received: by 2002:a05:600c:2283:b0:3da:b40f:7a55 with SMTP id 3-20020a05600c228300b003dab40f7a55mr4473493wmf.6.1675088933535; Mon, 30 Jan 2023 06:28:53 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5f17:219:cb05:7cd? ([2a01:e0a:982:cbb0:5f17:219:cb05:7cd]) by smtp.gmail.com with ESMTPSA id r38-20020a05600c322600b003dd19baf45asm813738wmp.40.2023.01.30.06.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 06:28:53 -0800 (PST) Message-ID: <624f2924-ec30-e0c0-1022-610d1aee761f@linaro.org> Date: Mon, 30 Jan 2023 15:28:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 3/4] soc: qcom: pmic_glink: Introduce altmode support Content-Language: en-US To: Bjorn Andersson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Subbaraman Narayanamurthy , Johan Hovold References: <20230130042003.577063-1-quic_bjorande@quicinc.com> <20230130042003.577063-4-quic_bjorande@quicinc.com> Organization: Linaro Developer Services In-Reply-To: <20230130042003.577063-4-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 30/01/2023 05:20, Bjorn Andersson wrote: > From: Bjorn Andersson > > With the PMIC GLINK service, the host OS subscribes to USB-C altmode > messages, which are sent by the firmware to notify the host OS about > state updates and HPD interrupts. > > The pmic_glink_altmode driver registers for these notifications and > propagates the notifications as typec_mux, typec_switch and DRM OOB > notifications as necessary to implement DisplayPort altmode support. > > Signed-off-by: Bjorn Andersson > Acked-by: Neil Armstrong > Tested-by: Konrad Dybcio # SM8350 PDX215 > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - Include bitfield.h > > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/pmic_glink_altmode.c | 478 ++++++++++++++++++++++++++ > 2 files changed, 479 insertions(+) > create mode 100644 drivers/soc/qcom/pmic_glink_altmode.c > Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550-MTP & SM8450-HDK