From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF9AEE4996 for ; Mon, 21 Aug 2023 18:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbjHUSx1 (ORCPT ); Mon, 21 Aug 2023 14:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjHUSx0 (ORCPT ); Mon, 21 Aug 2023 14:53:26 -0400 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4EF56C344 for ; Mon, 21 Aug 2023 11:53:22 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-31aec0a1a8bso1421830f8f.0 for ; Mon, 21 Aug 2023 11:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692643921; x=1693248721; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zCtenRCjXXMg5T6uzuSAM+POnJmMfnMhSwDV8nofr7M=; b=iVERGBgjqfA46CdXTSzrqZEX8b3lJrt02ilp+nvqeCCzs9suPzxQrFDFE+JTYqzoZl 4JKR4Ud877MnlFzqLNsFeyWZftJIazb5XCvSXmMhxt5GK1BZs2vf8g7DttbDRCPvBs0Y VkbxcIPnQorhIuSzlkoT8IkbSSF1M4pGqI2MW6LlQb9WrUWfebzYilzgvPsyOGKCh7i/ NvT2SrktOPoQhtqGCccKXMXndXTNzGVoYO3NfOlLvoSKHTBgdAiwKvPJ31gGQgZxPo+h xbjSG6NM6EpaqZjlkHIZad2rprdGkYyGmdiMr/u19FhV/ULmo1ChIsJdNS5DXMhhkWuQ 6zcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692643921; x=1693248721; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zCtenRCjXXMg5T6uzuSAM+POnJmMfnMhSwDV8nofr7M=; b=O6S4bi5viOYpOwjpLYoiV/4NowJ7kUMpiV64BPtiIQ7Bho0Q8XO6Y0EYQbYc/R05eu C6yCnbvJ9nReJ1qTIBjtQDBqUc1a66M4rtDlIRivZoNlFVDTJcSb6CypwjZlzcdF3Jkg zySQmA1cJkPh0pdxz6IVpYh4oPYpGYUF7nFxgjNTuPIGSMZQjFdc79r0HxoDx6z6lKHT yIK/s6dmwPD1kJTgAZy8dwO4VRaVCMa9E4vbjsj3xDVWE/teJCjfyGgPaOqumL8aFITX NpSdyvuKtEsvp9CZj9QUNLBkdOzHJMxEfyKjIBeN+yESVVv3Bay5OFWtGh03mo0ZcfaS cjdg== X-Gm-Message-State: AOJu0YzZuQEg9UPRigDJaQldAUuALwUwExmnPtVZMchCvpiJCLgsDzCX er0oXGjSvtjYYzNugVAJaAXJOcKP2ufLtW9rtsI= X-Google-Smtp-Source: AGHT+IEIBL5BILI0Pd6OWt114UByKQoedPY/3p8aG6w/uJFzgAGbmiKQooOd5z2oKWcFGRNX4goGEQ== X-Received: by 2002:adf:f74b:0:b0:319:7c17:4c65 with SMTP id z11-20020adff74b000000b003197c174c65mr7259307wrp.12.1692643921096; Mon, 21 Aug 2023 11:52:01 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id p6-20020a5d68c6000000b00317c742ca9asm13494807wrw.43.2023.08.21.11.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 11:52:00 -0700 (PDT) Message-ID: <62859b0e-cfee-f094-2ae9-bf0e243e2929@linaro.org> Date: Mon, 21 Aug 2023 19:51:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 Content-Language: en-US To: Hans Verkuil , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230814141007.3721197-1-bryan.odonoghue@linaro.org> <20230814141007.3721197-9-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/08/2023 10:53, Hans Verkuil wrote: > + u8 dt_id = vc * 4; You're right. dt_id = vc is wrong but so is dt_id = vc * 4. I'll post a fix for the dt_id as a separate patch. --- bod