From: Christian Marangi <ansuelsmth@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml
Date: Wed, 29 Jun 2022 14:00:27 +0200 [thread overview]
Message-ID: <62bc3ed2.1c69fb81.c8439.4982@mx.google.com> (raw)
In-Reply-To: <3ad4876b-1efa-c4c4-2139-3823cf80ff68@linaro.org>
On Wed, Jun 29, 2022 at 01:12:37PM +0200, Krzysztof Kozlowski wrote:
> On 29/06/2022 12:40, Christian Marangi wrote:
> > On Wed, Jun 29, 2022 at 08:14:12AM +0200, Krzysztof Kozlowski wrote:
> >> On 28/06/2022 20:41, Christian Marangi wrote:
> >>> Convert kpss-acc driver Documentation to yaml.
> >>> The original Documentation was wrong all along. Fix it while we are
> >>> converting it.
> >>> The example was wrong as kpss-acc-v2 should only expose the regs but we
> >>> don't have any driver that expose additional clocks. The kpss-acc driver
> >>> is only specific to v1. For this exact reason, limit all the additional
> >>> bindings (clocks, clock-names, clock-output-names and #clock-cells) to
> >>> v1 and also flag that these bindings should NOT be used for v2.
> >>>
> >>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> >>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>
> >> This is still not fixed and not tested. Since 4 versions of this
> >> patchset (previously was part of other set).
> >>
> >> I retract my review. Please test the bindings.
> >>
> >> Best regards,
> >> Krzysztof
> >
> > Thing is that I tested them and on my side I don't have such errors.
>
> Then maybe update your dtschema because I can easily see them.
>
You are totally right. I didn't had the problem as I was updating the
dtschema with sudo pip3... and it wasn't updating the dtschema local to
the linux repo. Didn't know that and I could't understand why I didn't
had the error.
> >
> > I'm using the linux-next branch. Should I use something else that have
> > newer schema files?
> >
> > Also on other patch there are some error reported that are unrelated to
> > my change and that looks strange.
>
> The other might be not be relevant, but this one is real and reproducible.
>
> Best regards,
> Krzysztof
--
Ansuel
next prev parent reply other threads:[~2022-06-29 12:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 18:41 [PATCH v3 0/4] Krait Documentation conversion Christian Marangi
2022-06-28 18:41 ` [PATCH v3 1/4] dt-bindings: clock: Convert qcom,krait-cc to yaml Christian Marangi
2022-06-29 2:09 ` Rob Herring
2022-06-28 18:41 ` [PATCH v3 2/4] dt-bindings: arm: msm: Convert kpss-acc driver Documentation " Christian Marangi
2022-06-29 2:09 ` Rob Herring
2022-06-29 6:14 ` Krzysztof Kozlowski
2022-06-29 10:40 ` Christian Marangi
2022-06-29 11:12 ` Krzysztof Kozlowski
2022-06-29 12:00 ` Christian Marangi [this message]
2022-06-28 18:41 ` [PATCH v3 3/4] dt-bindings: arm: msm: Rework kpss-gcc " Christian Marangi
2022-06-29 2:09 ` Rob Herring
2022-06-28 18:41 ` [PATCH v3 4/4] ARM: dts: qcom: fix various wrong definition for kpss-gcc node Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62bc3ed2.1c69fb81.c8439.4982@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).