Re: [PATCH] bus: mhi: host: Allocate entire MHI control config once

[Jeff Hugo <jeff.hugo@oss.qualcomm.com>]

On 4/24/2025 11:40 PM, Manivannan Sadhasivam wrote:
> On Fri, Mar 28, 2025 at 10:59:13AM -0600, Jeff Hugo wrote:
>> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
>>
>> MHI control configurations such as channel context, event context, command
>> context and rings, are currently allocated individually. During MHI
>> initialization MHI bus driver needs to configure the address space in
>> which this control configuration resides. Since different component of the
>> config is being allocated separately, only logical solution is to give the
>> entire RAM address space, as they could be anywhere.
>>
>> As per MHI specification the MHI control configuration address space should
>> not be more them 4GB.
> 
> Could you please add the spec limitation here as you described in your reply?

Will do.

> 
>>
>> Since the current implementation is in violation of MHI specification.
> 
> Here too.
> 
>> Allocate a single giant DMA buffer for MHI control configurations and
>> limit the configuration address space to that buffer.
>>
>> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
>> Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
> 
> Other than that, patch looks good to me.
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> - Mani