From: Javier Martinez Canillas <javierm@redhat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] drm/msm: Make .remove and .shutdown HW shutdown consistent
Date: Sun, 24 Jul 2022 21:50:56 +0200 [thread overview]
Message-ID: <630a6654-0305-f3a8-e062-f13a0074d35a@redhat.com> (raw)
In-Reply-To: <6b3f98db-83bf-41cd-b23d-79b455a06ebd@redhat.com>
On 7/24/22 20:47, Javier Martinez Canillas wrote:
> Hello Dmitry,
[...]
>> Now there is no point in having this as a separate function. Could you
>
> The only reason why I kept this was to avoid duplicating the same comment
> in two places. I thought that an inline function would be better than that.
>
>> please inline it?
>>
Or do you mean inline it as dropping the wrapper helper and just call to
drm_atomic_helper_shutdown() in both callbacks ? I'm OK with that but as
mentioned then we should probably have to duplicate the comment.
Since is marked as inline anyways, the resulting code should be the same.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-07-24 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 11:13 [PATCH v2] drm/msm: Make .remove and .shutdown HW shutdown consistent Javier Martinez Canillas
2022-07-24 18:36 ` Dmitry Baryshkov
2022-07-24 18:47 ` Javier Martinez Canillas
2022-07-24 19:50 ` Javier Martinez Canillas [this message]
2022-07-24 20:10 ` Dmitry Baryshkov
2022-07-24 20:15 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630a6654-0305-f3a8-e062-f13a0074d35a@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).