From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3BD5C433EF for ; Sun, 24 Jul 2022 19:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbiGXTvE (ORCPT ); Sun, 24 Jul 2022 15:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbiGXTvD (ORCPT ); Sun, 24 Jul 2022 15:51:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0FFF4D114 for ; Sun, 24 Jul 2022 12:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658692261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r9inbt98jsYkVMrgoCWp1i9QvqhbBgRlizGTcBJDaPI=; b=F2QmdkMHRJ9XKtEZ3ZwE3LjTtbwD287c+DKw/q3Lgmb/hPQ/GN5HECXt3CTxuqOQOY700h vjBQCHzelbVxHaoZuPUOECE5lX57qUuJK+1rk9hwFXsvdHoMEmlhnjRc83nke8RzrzI0yB yJgElZCtzDIO33jygAAjYv+iiXrnuKs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-i0epM9F0MwSDE_IFGKSsqA-1; Sun, 24 Jul 2022 15:50:59 -0400 X-MC-Unique: i0epM9F0MwSDE_IFGKSsqA-1 Received: by mail-wm1-f71.google.com with SMTP id 2-20020a1c0202000000b003a3497306a8so17851wmc.9 for ; Sun, 24 Jul 2022 12:50:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=r9inbt98jsYkVMrgoCWp1i9QvqhbBgRlizGTcBJDaPI=; b=q9SuQUVQvtsUo3hulVGmLocLQALynluNcODIqyk6KbbBPiEdF7Bjh977H0w7k4ZgWW zPYAXnaOH9iPl+4km61Z7gq7+aRRRupcJYXj3AoXQFMKU8CGieUcUbY2/YLjC+iXFw4e ZlsrrOiAHLpP9E+GE1wd+oB8dY6BAgFmvCZ7G8Y+84LybmHTusVI3LuiWE6xT/8iKdwr 6eNCRTX47BGEtci47cx7A+24gP6kSZE35UKV+JfPzGxdmK1RuIYVQ2hYPRE20S9wrDbx my6c35znmsGcivxVOZ2tEgT6yrO6ffjIMrTfvp2/aN5LxS4r41M8L+jVPOqRoWhwC0L9 wkTg== X-Gm-Message-State: AJIora/CrJnKNclu1DRyKGS3aoq0rNzl8XaC7vqWo4Av2iuEly/HcRvT ZrPJfTqoxrG1GSCjUnE5Sx0jVPaZpMFL2XatsELMD5Z4jmQ/rEVaNFCRkA4ls0Nxzhta2K37R7y a+Cxk3AJOWIrCidMSwueoXb0Dhg== X-Received: by 2002:a05:600c:4fd5:b0:3a3:4664:6d55 with SMTP id o21-20020a05600c4fd500b003a346646d55mr6458338wmq.73.1658692258576; Sun, 24 Jul 2022 12:50:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uoDoNu1JLD2TNJP7ydWkOxddGEuigmdMNKn4c8VjBMMj5w1Ik7ZxaOU03qLsLDrorqkPvlCw== X-Received: by 2002:a05:600c:4fd5:b0:3a3:4664:6d55 with SMTP id o21-20020a05600c4fd500b003a346646d55mr6458323wmq.73.1658692258383; Sun, 24 Jul 2022 12:50:58 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id o15-20020a05600c510f00b003a30fbde91dsm17433209wms.20.2022.07.24.12.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jul 2022 12:50:57 -0700 (PDT) Message-ID: <630a6654-0305-f3a8-e062-f13a0074d35a@redhat.com> Date: Sun, 24 Jul 2022 21:50:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] drm/msm: Make .remove and .shutdown HW shutdown consistent Content-Language: en-US From: Javier Martinez Canillas To: Dmitry Baryshkov Cc: linux-kernel@vger.kernel.org, Abhinav Kumar , Daniel Vetter , David Airlie , Fabio Estevam , Rob Clark , Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <20220724111327.1195693-1-javierm@redhat.com> <6b3f98db-83bf-41cd-b23d-79b455a06ebd@redhat.com> In-Reply-To: <6b3f98db-83bf-41cd-b23d-79b455a06ebd@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7/24/22 20:47, Javier Martinez Canillas wrote: > Hello Dmitry, [...] >> Now there is no point in having this as a separate function. Could you > > The only reason why I kept this was to avoid duplicating the same comment > in two places. I thought that an inline function would be better than that. > >> please inline it? >> Or do you mean inline it as dropping the wrapper helper and just call to drm_atomic_helper_shutdown() in both callbacks ? I'm OK with that but as mentioned then we should probably have to duplicate the comment. Since is marked as inline anyways, the resulting code should be the same. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat