From mboxrd@z Thu Jan 1 00:00:00 1970 From: pheragu@codeaurora.org Subject: Re: [PATCH 2/2] Embedded USB Debugger (EUD) driver Date: Tue, 31 Jul 2018 12:32:05 -0700 Message-ID: <631fd296787321ce3fa27f9c9b8b3841@codeaurora.org> References: <1533061333-7680-1-git-send-email-pheragu@codeaurora.org> <1533061333-7680-3-git-send-email-pheragu@codeaurora.org> <1a34e079-929c-5ac1-c4e9-85ce707c42e0@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1a34e079-929c-5ac1-c4e9-85ce707c42e0@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Trilok Soni Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, Satya Durga Srinivasu Prabhala List-Id: linux-arm-msm@vger.kernel.org On 2018-07-31 12:29, Trilok Soni wrote: > Hi Prakruthi, > > On 7/31/2018 11:22 AM, Prakruthi Deepak Heragu wrote: >> Add support for control peripheral of EUD (Embedded USB Debugger) to >> listen to events such as USB attach/detach, charger enable/disable, >> pet >> EUD to indicate software is functional. > > We should CC linux-usb mailing list too? > Sure. Will get the id and do it. >> + >> +config QCOM_EUD >> + tristate "QTI Embedded USB Debugger (EUD)" >> + depends on ARCH_QCOM >> + select SERIAL_CORE > > We don't need to select SERIAL_CORE since there is nothing related to > serial console in this driver. Yes, I will take it off. Shall I send a version 1?