From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C59C18B483 for ; Fri, 15 Nov 2024 09:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731662486; cv=none; b=Vj7F4Ub9lM80MVYRNEsctBxWnbJ5vMrjkhtgTjA2D86U+bOVL36Pw6oj1a84i/xDQxSIe0FYHZebaa8j/vOjveZmiiAZuryEUcTsu4Lbw8MjM+vhaAzg9qFUPNnlWBZ0bIL28GvEzFeOFlAZsSilFegyWOetDiMvSf3p0vBSLKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731662486; c=relaxed/simple; bh=SHNJ1Lf+Gj+8wNaOBgkKevAIOjTR/4rdQkoaqwDqlcw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=EhbAQHcfabTNbKls+wuKHel1pffCD933RJPUHVXgz/qfqfTQTxMZb6XYgb0wdnYaiImBtnfBWY7iyt8I/bkZXAdteievf3BtBBtJYy/8Q3ZDL2m5nirMDC3GP9+7quehYN/Haq14Szy1YKZxArNKBV7RAHulJU0ISUMh8qAcXe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QqvrRV0o; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QqvrRV0o" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4315eac969aso8898415e9.1 for ; Fri, 15 Nov 2024 01:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731662483; x=1732267283; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=3Ubsq0FTtX7FXFxz4kQgMfN9vdpcOBE9XRs+CSKkAVU=; b=QqvrRV0of9xQCeby/23G3J/Q76c53po0ySWUvr2koBhPmL6gtCe09uTdBc3EDNbe35 cam52Tjog6kecUO/9MMrc0aVs8r93pRt4hv1tl/t+/oO6ztGUgRRPouk3q6b51F2oHCK T3lX/rzby9Q8PSA7gjmU/AIniQkrb0UEOKl9xBXXaUFVAJcnm9N7pVMSJrM/daqzlcZj k1Ie/5FgXafifZ7ciDyJOulRazTBSg4Eg2JDihXjhllBpPtPZ4M7/uMHEk+3LDLHnBQz JgTpCgekwG4ha/8EHBiwP3s9JY0gJE5EX3psUVAWtxxxbGxNZd0ywQA87dBVFeEmhTGv jqLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731662483; x=1732267283; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3Ubsq0FTtX7FXFxz4kQgMfN9vdpcOBE9XRs+CSKkAVU=; b=XLG9PhDOVpdneiCuAzNFzvPm53ISGAOL4a7w3DM3MueCOqqGGAPpB3kDsW2l5pcZmD etVM0OnuL+/XwVijJDSdJpdpo0Cf8vDs9y7zxqKVC+1yVbK7/Q2SX3BmVH24V0CKexXQ OpBlMHKRlCIPlUzcx/U6VHjkpgFxcmBaNC5nFTl+fYxTs7hYDE2vlmEKtPPAzw1R1YIn HWrFvzsgDiUbruZsUfkwfdxbWH+lH5qowTxoXtRWziZ1fWj8P7x+DUxnpEU/X4rutIkc dpMHudp+VYnvb25I+p/wzie/dKfrMER8guT2Ffy5slp0hzjZSbk0j2rIZ+A6crJpq1lG Q79g== X-Forwarded-Encrypted: i=1; AJvYcCXZSMV3pr3VNqMdbNnL/GHR8mEIMTP/OreammHgbbEsASwoI3+ZZMi10scR4zIlxvqk9KMsbgFWDL/w0D7Q@vger.kernel.org X-Gm-Message-State: AOJu0Yx4+8D1XgohCaQ3yj2LJF7BYMkqL/7gAjRxe4FppyVFUvGm9Qi1 fS+MjTML0YyiBViJ3Mggadyf1ZYVYBtwjoI8Wv33LKquw3owCqMqw+UU2LKZKds= X-Google-Smtp-Source: AGHT+IFhhzfXYJliCvhgMAnEBeivjS0/dTVTRYhH3Xvh8F0wAGfi8xwl9PwfcqxAfM7+X3hn+j6avA== X-Received: by 2002:a05:600c:1c29:b0:431:4e33:98b6 with SMTP id 5b1f17b1804b1-432defd2398mr17475545e9.5.1731662482814; Fri, 15 Nov 2024 01:21:22 -0800 (PST) Received: from [192.168.7.189] ([212.114.21.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da2445d4sm51991485e9.5.2024.11.15.01.21.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 01:21:22 -0800 (PST) Message-ID: <63a2b391-8b71-41cb-bed2-3bc7fd2154ab@linaro.org> Date: Fri, 15 Nov 2024 10:21:21 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH RFC 2/8] drm/msm: adreno: add GMU_BW_VOTE quirk To: Dmitry Baryshkov Cc: Akhil P Oommen , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Connor Abbott , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20241113-topic-sm8x50-gpu-bw-vote-v1-0-3b8d39737a9b@linaro.org> <20241113-topic-sm8x50-gpu-bw-vote-v1-2-3b8d39737a9b@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/11/2024 08:07, Dmitry Baryshkov wrote: > On Wed, Nov 13, 2024 at 04:48:28PM +0100, Neil Armstrong wrote: >> The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth >> along the Frequency and Power Domain level, but by default we leave the >> OPP core vote for the interconnect ddr path. >> >> While scaling via the interconnect path was sufficient, newer GPUs >> like the A750 requires specific vote paremeters and bandwidth to >> achieve full functionality. >> >> Add a new Quirk enabling DDR Bandwidth vote via GMU. > > Please describe, why this is defined as a quirk rather than a proper > platform-level property. From my experience with 6xx and 7xx, all the > platforms need to send some kind of BW data to the GMU. Well APRIV, CACHED_COHERENT & PREEMPTION are HW features, why this can't be part of this ? Perhaps the "quirks" bitfield should be features instead ? > >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> index e71f420f8b3a8e6cfc52dd1c4d5a63ef3704a07f..20b6b7f49473d42751cd4fb4fc82849be42cb807 100644 >> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> @@ -57,6 +57,7 @@ enum adreno_family { >> #define ADRENO_QUIRK_HAS_HW_APRIV BIT(3) >> #define ADRENO_QUIRK_HAS_CACHED_COHERENT BIT(4) >> #define ADRENO_QUIRK_PREEMPTION BIT(5) >> +#define ADRENO_QUIRK_GMU_BW_VOTE BIT(6) >> >> /* Helper for formating the chip_id in the way that userspace tools like >> * crashdec expect. >> >> -- >> 2.34.1 >> >