From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0023C7EE24 for ; Tue, 2 May 2023 10:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbjEBKv3 (ORCPT ); Tue, 2 May 2023 06:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233664AbjEBKv2 (ORCPT ); Tue, 2 May 2023 06:51:28 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C44CA40C2 for ; Tue, 2 May 2023 03:51:26 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-959a3e2dd27so715972566b.3 for ; Tue, 02 May 2023 03:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683024685; x=1685616685; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KgcuRRydbdET9VazZUrn8rnTi0mHnWbUpTiGGHtkqs4=; b=F1GeeqSgxIMG1JnyBwBfeC5kLvTD2+UWMlN0dmc9ccWv9Z+2ajFaNmkz41+F0HZ9HB pTom68e5Ofp8r/rtmngq7mOZCuiuf2YPhC1Ap198l+CkolRngr1dI2V6Ko4fqPXVelxl AJK849ZAqSxCvsDy99Zc35bRpVl6llS3BxYwW3Cti7GCcL7d5oHwTxTopSubDsw6MJ4s xzzde96nCfz8Nd0+yym819yKB60JKuBysRNf8wVGWx48oNpmHsCbEYVcgPL9fsPg+96l TScUPJ/UBD4FimaLeCnVjTxU5k6d4NZB4oR3G8pfWvzqqDZIsF3yessQzSMcuPZddQSC 8tJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683024685; x=1685616685; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgcuRRydbdET9VazZUrn8rnTi0mHnWbUpTiGGHtkqs4=; b=L4hera1GfqG5Ryp9o9+fWSK/JIfI7z2Q7j0xtTwUMKItkkRGCEyhWCwxPCNRCopsNK cyaufb2rY51p6xYTuDE6bjCcsDR7kvcLO5/lvMTyS2QmXoHpfxksoiwsabjkDX/oMbGD YyYlglb7bfHlgALCEfQ74NkPe8gqGOTZ5RoFxk6K3P5hCOAePRdecijP6kPc3F+nnUKl ET/WZbscISszPfbNYOz82tjoN7OaM+rs7P3ZwiWsbf62AmI/YwnK8Myce+XLw1zhVbiZ HqJBYybPptBEKlAJQ/H97WXyRFByyp7Tz4cwO/NxyMuuer5z47DsJV9bG0v82xVohFPt nLJA== X-Gm-Message-State: AC+VfDxDcBmSzBfY+WrZpZTgxkpqzya+mSzAhJK45nEM7eM+rKlkE/NH jPhao4IU9+OtyEe6E0dTbdCU9g== X-Google-Smtp-Source: ACHHUZ74oo4k7L6mZ8lMIb+zTaeciGvqQPCS6NYSihTJbZogYZHdLHnOPnhW1rB9aiqxnVvGYMhcDQ== X-Received: by 2002:a17:907:94ca:b0:92f:924b:e8f4 with SMTP id dn10-20020a17090794ca00b0092f924be8f4mr15742498ejc.4.1683024684709; Tue, 02 May 2023 03:51:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bafd:1283:b136:5f6a? ([2a02:810d:15c0:828:bafd:1283:b136:5f6a]) by smtp.gmail.com with ESMTPSA id l20-20020a056402125400b0050bc863d32asm1633931edw.27.2023.05.02.03.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 03:51:23 -0700 (PDT) Message-ID: <63f646d7-a952-ca8c-58b3-b7db05f0b3a7@linaro.org> Date: Tue, 2 May 2023 12:51:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 04/13] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add input and output ports Content-Language: en-US From: Krzysztof Kozlowski To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, konrad.dybcio@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-5-bryan.odonoghue@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 02/05/2023 12:45, Krzysztof Kozlowski wrote: > On 01/05/2023 14:11, Bryan O'Donoghue wrote: >> Add a ports declaration which is optional containing two port@ >> declarations. >> >> port@0 to receive an orientation-switch message from the Type-C port or >> redriver >> >> port@1 to subsequently transmit the orientation-switch on once the PHY has >> finished doing its orientation turn-around. >> >> If ports is declared the input port port@0 is mandatory but the output >> port@1 is optional. >> >> Signed-off-by: Bryan O'Donoghue >> --- >> .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >> index d307343388888..c370b9cd58c2e 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >> @@ -65,6 +65,25 @@ properties: >> description: Flag the port as possible handler of orientation switching >> type: boolean >> >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports > > on this level: additionalProperties: false > (because otherwise it will allow port@2 etc) Although none (or almost none) of other bindings do it, so I guess it is fine. Fine till I figure out how it should be :) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof