Re: [PATCH] arm64: dts: qcom: x1e80100-tuxedo-14: add sound support

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 20/03/2025 07:13, Maud Spierings wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> This patch adds sound support for this platform,
>> support includes
>>     - 2x Speakers.
>>     - 2x dmic
>>     - Headset
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>
>> This patch depends on
>> "arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1" patch
>>  https://lkml.org/lkml/2025/3/6/867
>>
>> ucm changes:
>> https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/x1e80100-tuxedo
>>
>> tplg changes:
>> https://github.com/Srinivas-Kandagatla/audioreach-topology/tree/tuxedo-elite-14
>>
>>  .../qcom/x1e80100-tuxedo-elite-14-gen1.dts    | 190 ++++++++++++++++++
>>  1 file changed, 190 insertions(+)
> 
> <snip>
> 
>> +&smb2360_1_eusb2_repeater {
>> +    vdd18-supply = <&vreg_l3d_1p8>;
>> +    vdd3-supply = <&vreg_l14b_3p0>;
>> +};
> 
> This seems like it should be part of a different patch? Or should be 
> mentioned in the commit message.
> 
True, i thought I got rid of this before sending.
Thanks for spotting, will fix in next version.

--srini
>> +&swr0 {
>> +    status = "okay";
>> +
>> +    pinctrl-0 = <&wsa_swr_active>, <&spkr_01_sd_n_active>;
>> +    pinctrl-names = "default";
>> +
>> +    /* WSA8845, Left Speaker */
>> +    left_spkr: speaker@0,0 {
>> +        compatible = "sdw20217020400";
>> +        reg = <0 0>;
>> +        reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
>> +        #sound-dai-cells = <0>;
>> +        sound-name-prefix = "SpkrLeft";
>> +        vdd-1p8-supply = <&vreg_l15b_1p8>;
>> +        vdd-io-supply = <&vreg_l12b_1p2>;
>> +        qcom,port-mapping = <1 2 3 7 10 13>;
>> +    };
>> +
>> +    /* WSA8845, Right Speaker */
>> +    right_spkr: speaker@0,1 {
>> +        compatible = "sdw20217020400";
>> +        reg = <0 1>;
>> +        reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
>> +        #sound-dai-cells = <0>;
>> +        sound-name-prefix = "SpkrRight";
>> +        vdd-1p8-supply = <&vreg_l15b_1p8>;
>> +        vdd-io-supply = <&vreg_l12b_1p2>;
>> +        qcom,port-mapping = <4 5 6 7 11 13>;
>> +    };
>> +};
>> +
>> +&swr1 {
>> +    status = "okay";
>> +
>> +    /* WCD9385 RX */
>> +    wcd_rx: codec@0,4 {
>> +        compatible = "sdw20217010d00";
>> +        reg = <0 4>;
>> +        qcom,rx-port-mapping = <1 2 3 4 5>;
>> +    };
>> +};
>> +
>> +&swr2 {
>> +    status = "okay";
>> +
>> +    /* WCD9385 TX */
>> +    wcd_tx: codec@0,3 {
>> +        compatible = "sdw20217010d00";
>> +        reg = <0 3>;
>> +        qcom,tx-port-mapping = <2 2 3 4>;
>> +    };
>> +};
>> +
>>  &tlmm {
>>      gpio-reserved-ranges = <28 4>, /* Unused */
>>                     <44 4>, /* SPI (TPM) */
>> -- 
>> 2.39.5
> 
> Kind regards,
> Maud Spierings