From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1720D23C4FF for ; Sun, 3 May 2026 02:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777773999; cv=none; b=nFxs32ZLFhasWjRB9AJUdRS9n+DEwXoi5KXwPBf3WOXAm+Bas03QNo20PZ398eGH5KhbTM7DhqtZkde4bhiX+2s9Y0E3vltq3HmGXjfxTSp/lziKPe2w4tIgYd91lu/flTML0112PUq3IXrxfAJ2lw3h/aLtRTmLUjVx/kGV5yA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777773999; c=relaxed/simple; bh=qSG0sZNcjOSchIbQqXWGt3+PH22qMGXJjEvLkAzwfr0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ojpU99stiw5Icjd4FKQ8BCNZt/gEFvgL1H7OctKr3F6JlTQuOVK2JtVCeRx1zlZmmzKO2wfUgbXsbP7BMJxUMHp9pbpj6jLC0VPhFQy5vvJ7g4n7oZ0qZRTE1HftGQwXtXb2Z0ss4mCCXtFbmtX4DiUGubf18ETqiJzwC2QmwqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=btbRK1G5; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="btbRK1G5" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8b1f2b7f1bcso44032366d6.1 for ; Sat, 02 May 2026 19:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1777773997; x=1778378797; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PnVCaxNshzzHjwMMq5W7gN5QUApxgL+R58MdQlfO6d0=; b=btbRK1G5RFZ+SyUUfNLzRaZPSzJ9/mretRVTMuZqtyEjAHFRiP+elmVpqzKdwFaqZS K1JQ7VMuUx2eE/ACxjiOd+YQB4fYAaK9PnDYGMlwiGUrDK6iKy16aM7glSDXlcsYCWOZ pdbtAygj+OTRinuD4hOOpFFclJKItdPC3RSTp00eokz7QCw22sM+tDNGcxoBaZLAOhtK eqj3Xts+60lWyE4slvV5QZpOBupe5XgNG+mc8HgCjbk6Yr2dQSKb2kIxW1cJXnOmA5Ju KhhQFLAWheKe2R6mmsZjG0MV4EgsW40uo6+MK7clHHb50WVAqb6OEut8vo3Se8+IXAUi 540w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777773997; x=1778378797; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PnVCaxNshzzHjwMMq5W7gN5QUApxgL+R58MdQlfO6d0=; b=ESiSlmcN1h33QCnumhiF5uMH79Zl/AmccAB5okrtAkEtkO5kIFeoei++iERWoiGot3 2TuVlhoOoKxjzfc550FnOUc1w2Erq4Qqf28NHw4+1fqnFnSXgYpJpVxywgAfiM3m/NAp SV3hv5UEYFYB7pWopt0sgPZmThhSAut5fnzXqB2uskV6Ck702DgcRhSrw1VIbav9/68U 5Cu/3P6crEGobGiR1NX7Mjvkmiph8o1bM7uXsF+gxwjDYFXIYtMEmqTMMoftjdgSOo42 JKmI33Z2dRYwuU0AWm1/8yoYERSpe3F0ShpniejKWW9dX3aByJP8p8wTi8+EAirZPUf1 GPLQ== X-Forwarded-Encrypted: i=1; AFNElJ8Mhi6I3baactEvTXHg8/djhcRrLRWGWh/TQM5zFhWjpYhRViGqVXWV5OUFCUWwKxhj34fuBOdfpIvU7jil@vger.kernel.org X-Gm-Message-State: AOJu0YwVTdPsUW4w1zlDUNJ+kgmisvSjGdktlNTiDCLfEPAUJmba5D8v ccjVmZ+dP0rUWsVboR+uynTHlVT3+7RVJS9oqTP6X7FpM/W7wuQ+mbDim/DQsMx1Qho= X-Gm-Gg: AeBDievPFi4i2aAJ5eT2N1YJclJErw8gOy3vb7/eTdrCYNVjD8J0sX+OabGAUtOjIAT pTEPH7QH1O8orC6NClxxzUrLhbjeCCY3lfpq/pViPZ9yHL7jg7vj5f2EnrBWlIxpFes3G7WoYIc gUcATN6ys4PQXUaGI2QKX5Apl+0EeCSfADncz5Wr+k9zORfvrfQ7hwyiP01oh6Pq4vNicf5XULB b+zpmpKYI8DSBekT9e5upbI8AiS1opKrRvr16nXt8IM0vdJpSlt+cH5dzE/lyVS8PhvZ/ouycUH VYP/4d0APfJcEEgKCPosJNXBmrt1VzWj6brQWZBbGL6ugfFpIDkQ4DB5A56I45iaDPKRU4sIbLX NVAtxrMhCwocLcBjWdPuG2OOpPCylN5zPwfmRUsRUdLwx0HgenQl0Uc+O1vdH5gZx73AidiKsVo NUvpm18BMM1bgKzkhb0qZ9Tif7e0ae920H7/Xa96ecgKKHGwWdtv68tV4EL+mN4fn50CNJ1dUuO g== X-Received: by 2002:a05:6214:610d:b0:89c:8a3c:e34f with SMTP id 6a1803df08f44-8b667b79753mr56665696d6.12.1777773997147; Sat, 02 May 2026 19:06:37 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53d831ac7sm72634806d6.49.2026.05.02.19.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 May 2026 19:06:36 -0700 (PDT) Message-ID: <649428a4-9505-4a1a-bbbe-bd90be9b8155@riscstar.com> Date: Sat, 2 May 2026 21:06:33 -0500 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615 support To: Jakub Kicinski Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-12-elder@riscstar.com> <20260502094559.15c3f479@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20260502094559.15c3f479@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/2/26 11:45 AM, Jakub Kicinski wrote: > On Fri, 1 May 2026 10:54:19 -0500 Alex Elder wrote: >> The Toshiba TC956x is an Ethernet AVB/TSN bridge, and is >> essentially a small and highly-specialized SoC. It implements >> a number of internal functions, including a GPIO controller, >> control registers managing internal reset and clock control >> signals, a PCIe switch and internal endpoint, and mapping >> hardware that translates between PCIe and internal addressing. > > drivers/misc/tc956x_pci.c:541:17: error: call to undeclared function 'u32_get_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 541 | chip->rev_id = u32_get_bits(val, NCID_REV_ID_MASK); > | ^ Yeah I think I noticed an error like that shows up with 32-bit builds? In any case we didn't see it during development, and we'll make sure gets included. Thanks. -Alex