From mboxrd@z Thu Jan 1 00:00:00 1970 From: ygardi@codeaurora.org Subject: Re: [PATCH v1 06/17] scsi :ufs: verify hba controller hce reg value Date: Mon, 26 Oct 2015 13:11:05 -0000 Message-ID: <64a376c625da10a5dc948535d25950b5.squirrel@www.codeaurora.org> References: <1442155977-7686-1-git-send-email-ygardi@codeaurora.org> <1442155977-7686-7-git-send-email-ygardi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33860 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753394AbbJZNLK (ORCPT ); Mon, 26 Oct 2015 09:11:10 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Akinobu Mita Cc: Yaniv Gardi , Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Raviv Shvili , Vinayak Holikatti , "James E.J. Bottomley" > 2015-09-13 23:52 GMT+09:00 Yaniv Gardi : >> Sometimes due to hw issues it takes some time to the >> host controller register to update. In order to verify the register >> has updated, a polling is done until its value is set. >> >> In addition the functions ufshcd_hba_stop() and >> ufshcd_wait_for_register() was updated with an additional input >> parameter, indicating the timeout between reads will >> be done by sleeping or spinning the cpu. >> >> Signed-off-by: Raviv Shvili >> Signed-off-by: Yaniv Gardi >> >> --- >> drivers/scsi/ufs/ufshcd.c | 54 >> ++++++++++++++++++++++++++++------------------- >> drivers/scsi/ufs/ufshcd.h | 12 +++-------- >> 2 files changed, 35 insertions(+), 31 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index 6171da8..e5a876c 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -267,11 +267,12 @@ static inline void ufshcd_disable_irq(struct >> ufs_hba *hba) >> * @val - wait condition >> * @interval_us - polling interval in microsecs >> * @timeout_ms - timeout in millisecs >> - * >> + * @can_sleep - perform sleep or just spin >> * Returns -ETIMEDOUT on error, zero on success >> */ > > We usually put a blank line between @argument description and > return value description. > will be fixed in v2. thanks