From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1363DBD47 for ; Mon, 16 Mar 2026 18:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773685883; cv=none; b=HidlZKtSYyaaM1OMB25e8Xljwf2WzUhm33Tq1slQv3IYPMWsOJMrQ+NTdhVvcOFilyhWLOCErQ6S3S3pTJKEfck/F1VUSCYReUfU+ptORZppo37SonrLbGyZDINHz9yxr1OeEFpUjU8F8jWeuGRa/kXQwdLOGgF8QasxQTmlYqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773685883; c=relaxed/simple; bh=0ZYtisBfFCEDlffU86ZXcFsWQWlCFQ0yAs36eyfQuEk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gKYPKz8tJGrBONbE9EuD2GsVzu6Gk3Vaehy1xLBbRpDse1gG7iKqPnUIZS3oUV4/GMIK/67Cq3r+dEFe1CUapMo5CGW0/XyBeYnUKiEZtcWVVHzPLoq1aeBxbMdEnfYxA7gAY2uAEchpjtSo33Ki+fqFNw8ra8/mdu6EezVnTzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GCF00AJC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SXK1MoJQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GCF00AJC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SXK1MoJQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773685876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BNBEVCAdHGNat6EhquVBIDr5xmo+EfnKaRHucm6TIJk=; b=GCF00AJCWBZj0OUPqiPEMdeL890VLT/mPqSGORudiJBEWiaXmCBogpjb0wPc64OjiAwluP pESnVfD8TrRfO1eyRnVBbk02ol7/aUJMHiE9t1EKwbf6QtufW39nI9qHonUkX+CwzPFcti xfa0EQrtfde6c29fny7fZfgI1NwaLiw= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-LIs4cb7JMFiiFrawX-GcPg-1; Mon, 16 Mar 2026 14:31:14 -0400 X-MC-Unique: LIs4cb7JMFiiFrawX-GcPg-1 X-Mimecast-MFC-AGG-ID: LIs4cb7JMFiiFrawX-GcPg_1773685874 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-509181cc6ebso64584241cf.2 for ; Mon, 16 Mar 2026 11:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773685874; x=1774290674; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BNBEVCAdHGNat6EhquVBIDr5xmo+EfnKaRHucm6TIJk=; b=SXK1MoJQP7oC2fJZQd3cMTxZzqAET9o8TPMM6SLDPzqtghfLlH1tzTXbypTo99+OGV kYzQMap8DoxQhya9nvb0GM00f0tl8RrwPfK2/IpKvXpDlFP5czOwQJ9aWWCkZ3JnhQAk HgSBYdeVLHKFZV3dvSe9zgckmrXYQu4+uHTTC1AyUMOA7Ng0+FpnMp7u96GaPoLcoWF9 1d6p77qcm6uilXR9L/fLDRrZI6iz2z2F+ntb2FWo33fzBW4fp1r6RjVILTnogweRjpPw jV+6NBBO/LoAb7i9ON2rTr/MF/L4Fma3zOa4lO8i2nbDHGIdesCY9qnF16jpr9ezLBGy Ixdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773685874; x=1774290674; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BNBEVCAdHGNat6EhquVBIDr5xmo+EfnKaRHucm6TIJk=; b=doUPb0a4MxqWAVYJpeGQ2hDmg/Pt+E0ZUMJM13Nx32Tisj5o0Zk5Dbg4AooBJDrXN4 Rnnc1HQRXGtud50K2JixXJ2Ui/dMqA0+RNTHTCZTgqNNbmtZ7pUQi9LBC1Q1HqVJ34cb hLJxHBFI665AxwqhhUHgUXSXFowdTTuWUR7+veoEv6O1lzBnU/oYVsB12KK/RCRmIHQs qKKUqcZ1lXPpnWe6D4BO5u3WNuoPpoq48ua1UXBV3oIkmfQWvYrjR+dihabe9QGh87D5 Pg9OT/pzXeG0ROAcPmJx4vFs3o7IYvxg21e2kx2ml1FFjRq58vOuuKTNdyDW/mW4N8Z2 fRcg== X-Gm-Message-State: AOJu0YyAQrNcCMLwVztKm264iRMQWeF5hF9rmeF+KODKGYkvxYeLZg1O eMK2lexvS+FDnhYV8DmWSwgoGetTzq2TrDt0y4QQRT8RO2aqkp9VH2SXL/OMlRfib2zRUyk5D4i fsTDMf0MSo66JukXLdph/iOBP62EpeUjcd6LrfEh3hplqRS4TTTWu3jr63nbA/jWaNuw= X-Gm-Gg: ATEYQzyont6O8/1kPaHsAp3mVIqs6vIY8+L/8g8ARtcO13WH1KlXsY32zxjaccPXsZr SFozZZWX1Tw+INDERnshP6UYVjCfPOlRGS/73VE0XNL5LPljrMIfVDn5hgN1JKFaHtWQFW/sCfD xyJl7mVuvn6iJQapNURUpQ3U7mkoxoMZU3bNOte7cFklDDENuQI04cnl6Iqi4X4r+Xd3WG4zAD+ zNiGzTz9sUNAUX2NMFnXHXHrxcyz2nMy8feUuKes8lSyd/5bJ7II6NFiKaJEEYi0GZPgbOpjjxz KNu284XcgWSqwHGPVQVq9e7Bx2Swj71e80UDCUILsa5aY7IfggSo3nJFSYIn3CIY6zKh8AcKwNj A4c8oBMkUblyrJQcl7ExyRp4pYVP5vvwO/hGivj2wv6HcU6t2qiOdjBsyKOG4+X0OWN9aFAKb7b UKRJd0OM/kmAYtrA== X-Received: by 2002:a05:622a:15d3:b0:509:17e4:ceed with SMTP id d75a77b69052e-50957cb5a7amr187473201cf.9.1773685873582; Mon, 16 Mar 2026 11:31:13 -0700 (PDT) X-Received: by 2002:a05:622a:15d3:b0:509:17e4:ceed with SMTP id d75a77b69052e-50957cb5a7amr187471881cf.9.1773685872774; Mon, 16 Mar 2026 11:31:12 -0700 (PDT) Received: from thinkpad-p1.localdomain (pool-174-112-193-187.cpe.net.cable.rogers.com. [174.112.193.187]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a0ea244sm124136001cf.16.2026.03.16.11.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 11:31:12 -0700 (PDT) Message-ID: <64d282fd94be1546df75d7df5b47eacc0479797a.camel@redhat.com> Subject: Re: [PATCH net-next v9 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains From: Radu Rendec To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , Martin Blumenstingl , Krzysztof Kozlowski , Lad Prabhakar , Konrad Dybcio Date: Mon, 16 Mar 2026 14:31:08 -0400 In-Reply-To: <20260316-qcom-sa8255p-emac-v9-0-c58934e76ff2@oss.qualcomm.com> References: <20260316-qcom-sa8255p-emac-v9-0-c58934e76ff2@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-16 at 13:05 +0100, Bartosz Golaszewski wrote: > Add support for the firmware-managed variant of the DesignWare MAC on > the sa8255p platform. This series contains new DT bindings and driver > changes required to support the MAC in the STMMAC driver. >=20 > It also reorganizes the ethqos code quite a bit to make the introduction > of power domains into the driver a bit easier on the eye. >=20 > The DTS changes will go in separately. I'm seeing some weird behavior with this version. The probe part looks good (but see below), but when I try to bring an interface up, it fails with ETIMEDOUT. The relevant part of the stack trace leading to the error is this: dwmac4_dma_reset+0x208/0x220 [stmmac] stmmac_reset+0x2c/0x68 [stmmac] stmmac_init_dma_engine+0x108/0x400 [stmmac] stmmac_hw_setup+0x5c/0x538 [stmmac] __stmmac_open+0xc8/0x2a0 [stmmac] stmmac_open+0xcc/0x238 [stmmac] __dev_open+0x138/0x2a8 Now dwmac4_dma_reset() is very simple. It sets the soft reset bit in the DMA_BUS_MODE register, then waits for the hardware to clear it, and that never happens. Now, getting back to the probe part, there is one extra message (compared to my previous successful test on v7), which I see at the very end of the probing: qcom-ethqos 23040000.ethernet: clk_csr value out of range (0xffffff00 exceeds mask 0x00000f00), truncating This is a sa8775p ride board, so there are two stmmac devices. I only see that message for the 2nd one, which is also the one I'm trying to enable, and which fails. I realize this may or may not be related to your changes. But there is no way to test on a SCMI-pd board without them. I'm not sure how relevant it would be to test on the non-SCMI variant. I'm assuming the DMA part should work the same way (regardless of SCMI-pd), so if I can reproduce it there, and since I know it works on mainline Linux (that's where I tested v7), I could bisect and see which commit in net-next breaks it. If you don't have any better idea, let me know and I can try. Meanwhile, I'll keep poking at v9. Radu > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > --- > Changes in v9: > - Rebase on top of current linux-next again > - Link to v8: https://patch.msgid.link/20260311-qcom-sa8255p-emac-v8-0-58= 227bcf1018@oss.qualcomm.com >=20 > Changes in v8: > - Rebase on top of recent changes in linux-next which required an > =C2=A0 extensive rework > - Drop partial R-b tags > - Link to v7: https://patch.msgid.link/20260306-qcom-sa8255p-emac-v7-0-d6= a3013094b7@oss.qualcomm.com >=20 > Changes in v7: > - Restored the correct authorship after learning git uses .mailmap for > =C2=A0 the --author switch > - Rebased on top of changes from Russell > - Fixed resource management issues in error paths > - Link to v6: https://lore.kernel.org/r/20260112-qcom-sa8255p-emac-v6-0-8= 6a3d4b2ad83@oss.qualcomm.com >=20 > Changes in v6: > - Fix $id value in the bindings > - Drop patch 3/8 from the series > - Update init/exit callback signatures > - Link to v5: https://lore.kernel.org/r/20251107-qcom-sa8255p-emac-v5-0-0= 1d3e3aaf388@linaro.org > - Link to v6: https://lore.kernel.org/r/20251219-qcom-sa8255p-emac-v6-0-4= 87f1082461e@oss.qualcomm.com >=20 > Changes in v5: > - Name the DT binding document after the new compatbile > - Add missing space > - Make the power-domains limits stricter > - Link to v4: https://lore.kernel.org/r/20251104-qcom-sa8255p-emac-v4-0-f= 76660087cea@linaro.org >=20 > Changes in v4: > - Remove the phys property from the SCMI bindings > - Mark the power-domain-names property as required > - Set maxItems for power-domains to 1 for all existing bindings to > =C2=A0 maintain the current requirements after modifying the value in the > =C2=A0 top-level document > - Link to v3: https://lore.kernel.org/r/20251027-qcom-sa8255p-emac-v3-0-7= 5767b9230ab@linaro.org >=20 > Changes in v3: > - Drop 'power' and 'perf' prefixes from power domain names > - Rebase on top of Russell's changes to dwmac > - Rebase on top of even more changes from Russell that are not yet > =C2=A0 in next (E1vB6ld-0000000BIPy-2Qi4@rmk-PC.armlinux.org.uk) > - Link to v2: https://lore.kernel.org/all/20251008-qcom-sa8255p-emac-v2-0= -92bc29309fce@linaro.org/ >=20 > Changes in v2: > - Fix the power-domains property in DT bindings > - Rework the DT bindings example > - Drop the DTS patch, it will go upstream separately > - Link to v1: https://lore.kernel.org/r/20250910-qcom-sa8255p-emac-v1-0-3= 2a79cf1e668@linaro.org >=20 > --- > Bartosz Golaszewski (6): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dt-bindings: net: qcom: document the ethqo= s device for SCMI-based systems > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: qcom-ethqos: use generic devi= ce properties > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: qcom-ethqos: wrap emac driver= data in additional structure > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: qcom-ethqos: split power mana= gement fields into a separate structure > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: qcom-ethqos: split power mana= gement context into a separate struct > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: qcom-ethqos: add support for = sa8255p >=20 > =C2=A0.../bindings/net/allwinner,sun7i-a20-gmac.yaml=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/altr,socfpga-stmmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/amlogic,meson-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/eswin,eic7700-eth.yaml |=C2=A0=C2=A0 3 = + > =C2=A0.../devicetree/bindings/net/intel,dwmac-plat.yaml=C2=A0 |=C2=A0=C2= =A0 3 + > =C2=A0.../bindings/net/loongson,ls1b-gmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/loongson,ls1c-emac.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/nxp,dwmac-imx.yaml=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/nxp,lpc1850-dwmac.yaml |=C2=A0=C2=A0 3 = + > =C2=A0.../devicetree/bindings/net/nxp,s32-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/qcom,ethqos.yaml=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/qcom,sa8255p-ethqos.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 98 +++++ > =C2=A0.../devicetree/bindings/net/renesas,rzn1-gmac.yaml |=C2=A0=C2=A0 3 = + > =C2=A0.../bindings/net/renesas,rzv2h-gbeth.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/rockchip-dwmac.yaml=C2=A0=C2=A0=C2=A0 |= =C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/snps,dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 +- > =C2=A0.../bindings/net/sophgo,cv1800b-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/sophgo,sg2044-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../bindings/net/starfive,jh7110-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/stm32-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0.../devicetree/bindings/net/tesla,fsd-ethqos.yaml=C2=A0 |=C2=A0=C2= =A0 3 + > =C2=A0.../devicetree/bindings/net/thead,th1520-gmac.yaml |=C2=A0=C2=A0 3 = + > =C2=A0.../bindings/net/toshiba,visconti-dwmac.yaml=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 + > =C2=A0MAINTAINERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > =C2=A0drivers/net/ethernet/stmicro/stmmac/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- > =C2=A0.../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c=C2=A0=C2=A0=C2=A0 |= 401 +++++++++++++++++---- > =C2=A026 files changed, 498 insertions(+), 72 deletions(-) > --- > base-commit: dac1315bf558e4895665aa1c278fd30113ca119d > change-id: 20250704-qcom-sa8255p-emac-8460235ac512 >=20 > Best regards,