From: Luca Weiss <luca@z3ntu.xyz>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <quic_tdas@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags
Date: Mon, 08 May 2023 22:47:57 +0200 [thread overview]
Message-ID: <6529911.lOV4Wx5bFT@z3ntu.xyz> (raw)
In-Reply-To: <20230507175335.2321503-2-dmitry.baryshkov@linaro.org>
On Sonntag, 7. Mai 2023 19:53:35 CEST Dmitry Baryshkov wrote:
> Using PWRSTS_RET on msm8974's MDSS_GDSC causes display to stop working.
> The gdsc doesn't fully come out of retention mode. Change it's pwrsts
> flags to PWRSTS_OFF_ON.
+CC Rajendra & Manivannan
Following the mails at [0] this was the suggested fix, which I haven't
made into a patch myself yet.
With this (and without the revert of the linked patch) panel init is fine
again on FP2. Thanks!
[0] https://lore.kernel.org/linux-arm-msm/5897497.lOV4Wx5bFT@g550jk/
Tested-by: Luca Weiss <luca@z3ntu.xyz>
>
> Fixes: d399723950c4 ("clk: qcom: gdsc: Fix the handling of PWRSTS_RET
> support") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/mmcc-msm8974.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/mmcc-msm8974.c
> b/drivers/clk/qcom/mmcc-msm8974.c index aa29c79fcd55..277ef0065aae 100644
> --- a/drivers/clk/qcom/mmcc-msm8974.c
> +++ b/drivers/clk/qcom/mmcc-msm8974.c
> @@ -2401,7 +2401,7 @@ static struct gdsc mdss_gdsc = {
> .pd = {
> .name = "mdss",
> },
> - .pwrsts = PWRSTS_RET_ON,
> + .pwrsts = PWRSTS_OFF_ON,
> };
>
> static struct gdsc camss_jpeg_gdsc = {
next prev parent reply other threads:[~2023-05-08 20:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 17:53 [PATCH 1/2] clk: qcom: mmcc-msm8974: use clk_rcg2_shared_ops for mdp_clk_src clock Dmitry Baryshkov
2023-05-07 17:53 ` [PATCH 2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags Dmitry Baryshkov
2023-05-08 8:27 ` Konrad Dybcio
2023-05-08 11:36 ` Dmitry Baryshkov
2023-05-08 20:47 ` Luca Weiss [this message]
2023-05-09 5:35 ` Rajendra Nayak
2023-05-09 5:50 ` Manivannan Sadhasivam
2023-05-09 11:20 ` Dmitry Baryshkov
2023-05-11 8:15 ` Manivannan Sadhasivam
2023-05-29 23:47 ` Dmitry Baryshkov
2023-06-14 6:05 ` Dmitry Baryshkov
2023-06-14 10:19 ` Konrad Dybcio
2023-05-08 7:55 ` [PATCH 1/2] clk: qcom: mmcc-msm8974: use clk_rcg2_shared_ops for mdp_clk_src clock Konrad Dybcio
2023-05-08 15:03 ` Dmitry Baryshkov
2023-05-08 20:45 ` Luca Weiss
2023-05-27 1:07 ` (subset) " Bjorn Andersson
2023-06-20 20:03 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6529911.lOV4Wx5bFT@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox