Re: [PATCH V5 1/6] dt-bindings: regulator: Add pm8008 regulator bindings

Satya Priya Kakitapalli (Temp)
2022-02-11T10:01:39Z

On 2/10/2022 6:54 AM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-02-08 06:52:15)
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml
>> new file mode 100644
>> index 0000000..0098845
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml
>> @@ -0,0 +1,31 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings
>> +
>> +maintainers:
>> + - Satya Priya <skakit@codeaurora.org>
>> +
>> +description:
>> + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC
>> + containing 7 LDO regulators.
>> +
>> +patternProperties:
>> + "^LDO[1-7]$":
> Any reason it needs to be capitalized vs. lowercase ldo?

I'll change this to lowercase.

>> + type: object
>> + $ref: "regulator.yaml#"
>> + description: PM8008 regulator peripherals of PM8008 regulator device
>> +
>> + properties:
>> + regulator-name: true
>> +
>> + required:
>> + - regulator-name