From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
djakov@kernel.org, dmitry.baryshkov@linaro.org,
quic_anusha@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: interconnect: Add Qualcomm IPQ9574 support
Date: Sat, 30 Mar 2024 11:30:03 +0100 [thread overview]
Message-ID: <65ef293a-5ae2-4d1e-ac03-a6a6eab24ba8@linaro.org> (raw)
In-Reply-To: <20240328075936.223461-2-quic_varada@quicinc.com>
On 28/03/2024 08:59, Varadarajan Narayanan wrote:
> Add interconnect-cells to clock provider so that it can be
> used as icc provider.
>
> Add master/slave ids for Qualcomm IPQ9574 Network-On-Chip
> interfaces. This will be used by the gcc-ipq9574 driver
> that will for providing interconnect services using the
> icc-clk framework.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Please remove my Reviewed tag.
It seems you do not use this binding header: neither in your DTS and nor
in the driver.
Consider the patch NAK-ed and send new version which removes unused header.
Please provide link to upstreamed DTS using this, so we can validate
your usage. Otherwise it looks just wrong and you try to upstream
something which will not pass dtbs checks on the first day, for example.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-30 10:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:59 [PATCH v5 0/5] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-03-28 7:59 ` [PATCH v5 1/5] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-03-30 10:30 ` Krzysztof Kozlowski [this message]
2024-03-28 7:59 ` [PATCH v5 2/5] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-03-28 7:59 ` [PATCH v5 3/5] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-03-28 21:54 ` Stephen Boyd
2024-03-29 10:48 ` Varadarajan Narayanan
2024-04-05 21:25 ` Stephen Boyd
2024-03-28 7:59 ` [PATCH v5 4/5] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-03-28 21:51 ` Stephen Boyd
2024-03-29 10:55 ` Varadarajan Narayanan
2024-03-29 12:10 ` Krzysztof Kozlowski
2024-03-30 9:30 ` Varadarajan Narayanan
2024-03-30 10:28 ` Krzysztof Kozlowski
2024-03-30 11:17 ` Varadarajan Narayanan
2024-04-01 14:20 ` kernel test robot
2024-03-28 7:59 ` [PATCH v5 5/5] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ef293a-5ae2-4d1e-ac03-a6a6eab24ba8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox